aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Add a comment and a check for why flag indices will be <= 63Nick Mathewson2013-07-08
|
* FIx undefined behavior in dirvote.cNick Mathewson2013-07-03
| | | | | | | | Fix a bug in the voting algorithm that could yield incorrect results when a non-naming authority declared too many flags. Fixes bug 9200; bugfix on 0.2.0.3-alpha. Found by coverity scan.
* Give a warning when bufferevents are enabled.Nick Mathewson2013-06-29
| | | | Ticket 9147.
* Fix bug 9122: don't allow newdefaultoptions to be NULLNick Mathewson2013-06-24
| | | | | | | (This caused a crash that was reported as bug 9122, but the underlying behavior has been wrong for a while.) Fix on 0.2.3.9-alpha.
* Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-18
|\
| * Fix some problems with the bug9002 fix.Nick Mathewson2013-06-18
| | | | | | | | Fixes bug 9090; bug not in any released Tor.
* | Tweak bug9063_redux patch: {n_p}_chan_cells, not {n,p}_conn_cellsNick Mathewson2013-06-18
| |
* | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-18
|\| | | | | | | | | | | Conflicts: src/or/config.c src/or/relay.c
| * Merge branch 'bug9063_redux_023_squashed' into maint-0.2.3Nick Mathewson2013-06-18
| |\
| | * Implement a real OOM-killer for too-long circuit queues.Nick Mathewson2013-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements "algorithm 1" from my discussion of bug #9072: on OOM, find the circuits with the longest queues, and kill them. It's also a fix for #9063 -- without the side-effects of bug #9072. The memory bounds aren't perfect here, and you need to be sure to allow some slack for the rest of Tor's usage. This isn't a perfect fix; the rest of the solutions I describe on codeable.
| * | Limit hidden service descriptors to at most 10 guard nodes.Nick Mathewson2013-06-16
| |/ | | | | | | | | Fixes bug 9002; bugfix on 0.1.1.11-alpha (which introduced guard nodes), or on 0.0.6pre1 (which introduced hidden services).
* | Merge branch 'bug9072-023' into bug9072-024Andrea Shepard2013-06-15
|\|
| * Disable middle relay queue overfill detection code due to possible guard ↵Andrea Shepard2013-06-15
| | | | | | | | discovery attack
| * Increase the limit so leaky pipe might workNick Mathewson2013-06-14
| |
| * Don't queue more cells as a middle relay than the spec allows to be in flightAndrea Shepard2013-06-13
| |
* | Increase the limit so leaky pipe might workNick Mathewson2013-06-14
| |
* | Don't queue more cells as a middle relay than the spec allows to be in flightAndrea Shepard2013-06-13
| |
* | Define SEEK_SET for platforms that lack it.Nick Mathewson2013-06-13
| |
* | If we write the annotation but not the microdescriptor, rewind.Nick Mathewson2013-06-13
| | | | | | | | | | This fixes bug 9047 (and some parts of 9031, 8922, 8883 that weren't fixed in 8822). Bugfix on 0.2.2.6-alpha.
* | Merge remote-tracking branch 'public/bug8822' into maint-0.2.4Nick Mathewson2013-06-13
|\ \
| * | Make all consumers of microdesc_t.body tolerate NULLNick Mathewson2013-06-12
| | | | | | | | | | | | This is another fix to try to mitigate recurrences of 8031/8822.
| * | Unmap the microdescriptor cache before replacing it.Nick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reprise of the fix in bdff7e3299d78; 6905c1f6 reintroduced that bug. Briefly: windows doesn't seem to like deleting a mapped file. I tried adding the PROT_SHARED_DELETE flag to the createfile all, but that didn't actually fix this issue. Fortunately, the unit test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should prevent us from making this particular screw-up again. This patch also tries to limit the crash potential of a failure to write by a little bit, although it could do a better job of retaining microdescriptor bodies. Fix for bug 8822, bugfix on 0.2.4.12-alpha.
* | | Merge remote-tracking branch 'andrea/bug8639_v3' into maint-0.2.4Nick Mathewson2013-06-12
|\ \ \ | |/ / |/| |
| * | When launching a resolve request on behalf of an AF_UNIX control, omit the ↵Andrea Shepard2013-05-31
| | | | | | | | | | | | address field of the new entry connection. Fixes bug 8639.
* | | Revert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping"Nick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | This reverts commit 884a0e269c382f9e927d8c8b1ef4ef9d2d48379d. I'm reverting this because it doesn't actually make the problem go away. It appears that instead we need to do unmap-then-replace.
* | | Merge remote-tracking branch 'public/bug2077_share_delete' into maint-0.2.4Nick Mathewson2013-06-12
|\ \ \
| * | | Use the FILE_SHARE_DELETE flag for CreateFile on a mappingNick Mathewson2013-06-12
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A comment by rransom on #8795 taken together with a comment by doorss recorded on #2077 suggest that *every* attempt to replace the md cache will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag passed to CreateFile, and if we try to replace the file ourselves before unmapping it. I'm adding the FILE_SHARE_DELETE, since that's this simplest fix. Broken indexers (the favored #2077 hypothesis) could still cause trouble here, but at least this patch should make us stop stepping on our own feet. Likely fix for #2077 and its numerous duplicates. Bugfix on 0.2.2.6-alpha, which first had a microdescriptor cache that would get replaced before remapping it.
* | | Expand microdesc cache testsNick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | Is it possible that *every* attempt to replace the microdesc cache on windows 7 is going to fail because of our lack of FILE_SHARE_DELETE while opening the file? If so, this test will catch #2077 and let us know when it's fixed.
* | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-10
|\| |
| * | Merge branch 'bug9017' into maint-0.2.3Nick Mathewson2013-06-10
| |\ \
| | * | Fix (Open?)BSD fast-connect bug with optimistic data.Nick Mathewson2013-06-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's an assertion failure that can occur if a connection has optimistic data waiting, and then the connect() call returns 0 on the first attempt (rather than -1 and EINPROGRESS). That latter behavior from connect() appears to be an (Open?)BSDism when dealing with remote addresses in some cases. (At least, I've only seen it reported with the BSDs under libevent, even when the address was 127.0.0.1. And we've only seen this problem in Tor with OpenBSD.) Fixes bug 9017; bugfix on 0.2.3.1-alpha, which first introduced optimistic data. (Although you could also argue that the commented-out connection_start_writing in 155c9b80 back in 2002 is the real source of the issue.)
* | | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-05
|\| | | | |_|/ |/| |
| * | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-06-05
| |\ \
| | * | Update to the June 2013 GeoIP database.Karsten Loesing2013-06-05
| | | |
* | | | Downgrade the unexpected sendme cell warnings for 0.2.4Nick Mathewson2013-05-21
| | | | | | | | | | | | | | | | See discussion on #8093
* | | | Copy-paste description of PathBias params from man page to or.h commentAndrea Shepard2013-05-20
| | | |
* | | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-05-20
|\| | |
| * | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-05-20
| |\| | | | |/ | |/|
| | * Update to the May 2013 GeoIP database.Karsten Loesing2013-05-13
| | |
* | | Fix bug 8846: better log message on IP version confusionNick Mathewson2013-05-17
| | |
* | | Fix unit tests to pass after fix for #8879Nick Mathewson2013-05-15
| | |
* | | Fix socks5 handshake for username/password authRoger Dingledine2013-05-15
| | | | | | | | | | | | | | | The fix for bug 8117 exposed this bug, and it turns out real-world applications like Pidgin do care. Bugfix on 0.2.3.2-alpha; fixes bug 8879.
* | | Merge bug5595-v2-squashed into maint-0.2.4Andrea Shepard2013-05-10
|\ \ \
| * | | Add some unit tests for fp_pair_map_t to test/containers.c based on the ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | strmap tests
| * | | Rephrase comment in trusted_dirs_load_certs_from_string() to reflect 5595 fixAndrea Shepard2013-05-09
| | | |
| * | | Make warning in authority_cert_dl_failed() LD_BUG per NickM code reviewAndrea Shepard2013-05-09
| | | |
| * | | Use tor_asprintf() and clean up string handling in ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | authority_certs_fetch_missing()
| * | | Clean up ugly constants in connection_dir_download_cert_failed(), and fix a ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | broken one
| * | | Avoid duplicate downloads by (fp,sk) and by fp for authority certs when ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | bootstrapping
| * | | When downloading certificates, distinguish requesting by identity digest ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | from requesting by ID digest, signing key pair; fixes bug 5595