aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Merge remote-tracking branch 'origin/maint-0.2.3'Nick Mathewson2012-09-18
|\
| * Whitespace fixesNick Mathewson2012-09-18
| |
| * Bug 6866: Convert pathbias asserts into log messages.Mike Perry2012-09-17
| | | | | | | | Asserts were hit by Tor2Web mode.
* | Print the correct address family in log printout.Linus Nordberg2012-09-18
| | | | | | | | | | | | | | | | Look at the address family of the preferred OR port rather than the node.ipv6_preferred flag since the logic has changed with new ClientUseIPv6 config option. Fixes ticket 6884.
* | Merge remote-tracking branch 'linus/bug6880'Nick Mathewson2012-09-17
|\ \
| * | Don't do reachability testing over IPv6 unless AuthDirPublishIPv6 is set.Linus Nordberg2012-09-17
| | | | | | | | | | | | This affects both directory authorities and bridge authoritites.
* | | Fix comment typo in tor_memeqRobert Ransom2012-09-17
| | |
* | | Add unit test for crypto_pk_cmp_keys and NULLNick Mathewson2012-09-17
| | |
* | | Fix documentation for crypto_pk_cmp_keysRobert Ransom2012-09-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that crypto_pk_cmp_keys might return the result of tor_memcmp, there is no guarantee that it will only return -1, 0, or 1. (It currently does only return -1, 0, or 1, but that's a lucky accident due to details of the current implementation of tor_memcmp and the particular input given to it.) Fortunately, none of crypto_pk_cmp_keys's callers rely on this behaviour, so changing its documentation is sufficient.
* | | Implement and use crypto_pk_eq_keysRobert Ransom2012-09-17
| | |
* | | Make crypto_pk_cmp_keys do something sane for NULL keysRobert Ransom2012-09-17
| | | | | | | | | | | | | | | Fixes bug 4283; bugfix on r76 (Git commit 01aadefbfc7dbd99ddaff922b897996b768cf2f9).
* | | Merge remote-tracking branch 'public/bug6853'Nick Mathewson2012-09-17
|\ \ \
| * | | Parse votes with >31 flags correctlyNick Mathewson2012-09-17
| | |/ | |/| | | | | | | | | | | | | | | | We were doing (1<<p) to generate a flag at position p, but we should have been doing (U64_LITERAL(1)<<p). Fixes bug 6861; bugfix on 0.2.0.3-alpha; reported pseudonymously.
* | | Merge branch 'bug6861_typofix'Nick Mathewson2012-09-17
|\ \ \
| * | | Avoid sign-extending when computing rend auth type.Nick Mathewson2012-09-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right-shifting negative values has implementation-defined behavior. On all the platforms we work on right now, the behavior is to sign-extend the input. That isn't what we wanted in auth_type_val = (descriptor_cookie_tmp[16] >> 4) + 1; Fix for 6861; bugfix on 0.2.1.5-alpha; reported pseudonymously. The broken behavior didn't actually hurt anything, I think, since the only way to get sign-extension to happen would be to have the top bit of descriptor_cookie_tmp[16] set, which would make the value of descriptor_cookie_tmp[16] >> 4 somewhere between 0b11111111 and 0b11111000 (that is, between -1 and -8). So auth_type_val would be between -7 and 0. And the immediate next line does: if (auth_type_val < 1 || auth_type_val > 2) { So the incorrectly computed auth_type_val would be rejected as invalid, just as a correctly computed auth_type_val would be. Still, this stuff shouldn't sit around the codebase.
* | | | Merge branch '6044_nm_squashed'Nick Mathewson2012-09-17
|\ \ \ \ | |/ / / |/| | |
| * | | Turn the read_file_until_eof tests into a single implementationNick Mathewson2012-09-17
| | | |
| * | | Handle FIFOs in read_file_to_strmeejah2012-09-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add read_file_to_str_until_eof which is used by read_file_to_str if the file happens to be a FIFO. change file_status() to return FN_FILE if st_mode matches S_IFIFO (on not-windows) so that init_key_from_file() will read from a FIFO.
* | | | Merge remote-tracking branch 'origin/maint-0.2.3'Nick Mathewson2012-09-14
|\ \ \ \ | | |/ / | |/| |
| * | | Use file-size-fixup code on cygwin too.Nick Mathewson2012-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already had code on windows to fix our file sizes when we're reading a file in text mode and its size doesn't match the size from fstat. But that code was only enabled when _WIN32 was defined, and Cygwin defines __CYGWIN__ instead. Fixes bug 6844; bugfix on 0.1.2.7-alpha.
* | | | Move functions for seeing if we know enough nodes into nodelistNick Mathewson2012-09-14
| | | |
* | | | Remove router_get_by_{nickname,hexdigest} entirelyNick Mathewson2012-09-14
| | | |
* | | | Remove the old disabled router_get_by_nickname implementationNick Mathewson2012-09-14
| | | |
* | | | Move many of the node_ functions from routerlist to nodelistNick Mathewson2012-09-14
| | | |
* | | | Split the routerset code out of routerlist.cNick Mathewson2012-09-14
| | | |
* | | | Merge branch 'bug6833'Nick Mathewson2012-09-14
|\ \ \ \
| * | | | document why we only allow 64 flags in votesNick Mathewson2012-09-14
| | | | |
| * | | | Reject votes (not consensuses) with >64 known-flagsNick Mathewson2012-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our flag voting code needs to handle unrecognized flags, so it stores them in a 64-bit bitfield. But we never actually checked for too many flags, so we were potentially doing stuff like U64_LITERAL(1)<<flagnum with flagnum >= 64. That's undefined behavior. Fix for bug 6833; bugfix on 0.2.0.1-alpha.
* | | | | Fix compilation with older gccsNick Mathewson2012-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They don't like to have #preprocessor directives inside macro arguments. Fixes #6842; fix on 0.2.4.2-alpha. Found by grarpamp.
* | | | | Remove a duplicate test in test_util_pow2Nick Mathewson2012-09-14
| | | | |
* | | | | Merge branch 'bug6831_v2'Nick Mathewson2012-09-14
|\ \ \ \ \
| * | | | | Don't compute ((uint64_t)1)<<64 in round_to_power_of_2Nick Mathewson2012-09-14
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This would be undefined behavior if it happened. (It can't actually happen as we're using round_to_power_of_2, since we would have to be trying to allocate exabytes of data.) While we're at it, fix the behavior of round_to_power_of_2(0), and document the function better. Fix for bug 6831.
* | | | | Split the or_state_t portions of config.c into their own fileNick Mathewson2012-09-13
| | | | |
* | | | | Remove all remaining spurious or_options_t invocations in confparse.cNick Mathewson2012-09-13
| | | | |
* | | | | Split the generic config_fmt_t code into a new confparse.c fileNick Mathewson2012-09-13
|/ / / / | | | | | | | | | | | | | | | | This helps us split up one of our larger files, and sets the stage for refactoring the configuration backend a little
* | | | Merge remote-tracking branch 'origin/maint-0.2.3'Nick Mathewson2012-09-13
|\| | |
| * | | Avoid undefined behaviour when parsing HS protocol versionsRobert Ransom2012-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 6827; bugfix on c58675ca728f12b42f65e5b8964ae695c2e0ec2d (when the v2 HS desc parser was implemented). Found by asn.
| * | | Revert "6819: typo in torrc.sample.in"Nick Mathewson2012-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4aff97cfc7965414ad8506ce28a296da1bc4a161. We don't actually want to be changing the torrc.sample on stable or near-stable stuff, since doing so makes pointless busywork for debian users.
* | | | Merge branch 'bug6815'Nick Mathewson2012-09-12
|\ \ \ \
| * | | | Fix a wide lineNick Mathewson2012-09-12
| | | | |
| * | | | Fix directory self-testing logicNick Mathewson2012-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When I removed version_supports_begindir, I accidentally removed the mechanism we had been using to make a directory cache self-test its directory port. This caused bug 6815, which caused 6814 (both in 0.2.4.2-alpha). To fix this bug, I'm replacing the "anonymized_connection" argument to directory_initiate_command_* with an enumeration to say how indirectly to connect to a directory server. (I don't want to reinstate the "version_supports_begindir" argument as "begindir_ok" or anything -- these functions already take too many arguments.) For safety, I made sure that passing 0 and 1 for 'indirection' gives the same result as you would have gotten before -- just in case I missed any 0s or 1s.
* | | | | Merge remote-tracking branch 'origin/maint-0.2.3'Nick Mathewson2012-09-12
|\ \ \ \ \ | | |/ / / | |/| | |
| * | | | Merge remote-tracking branch 'public/bug6341_a_v2' into maint-0.2.3Nick Mathewson2012-09-12
| |\ \ \ \
| | * | | | Check ewma_enabled before doing circ-has-become-inactive checkNick Mathewson2012-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids a possible crash bug in flush_from_first_active_circuit. Fixes bug 6341; bugfix on 0.2.2.7-alpha. Bug reported and fixed by a pseudonymous user on IRC.
* | | | | | Merge remote-tracking branch 'origin/maint-0.2.3'Nick Mathewson2012-09-12
|\| | | | | | |_|_|_|/ |/| | | |
| * | | | 6819: typo in torrc.sample.inNick Mathewson2012-09-12
| | | | |
* | | | | hot: we fixed incancations to be intancations.Roger Dingledine2012-09-12
| |_|/ / |/| | |
* | | | Merge remote-tracking branch 'public/bug6538'Nick Mathewson2012-09-11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: configure.ac
| * | | | Use a time-invariant comparison in choose_array_element_by_weightNick Mathewson2012-08-28
| | | | |
| * | | | In choose-by-bw, scale to better use the range of uint64Nick Mathewson2012-08-27
| | | | | | | | | | | | | | | | | | | | | | | | | The smart part of this is based on an approach and a suggestion by rransom. The unsmart part is my own fault.
generated by cgit v1.2.3 (git 2.45.0) at 2025-03-02 01:46:31 +0000