aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Remove a duplicated line, found by clangSebastian Hahn2011-05-09
|
* Fix potential null pointer deref during dirvoteSebastian Hahn2011-05-09
| | | | Found by using clang's analyzer.
* Fix a potential null deref when rebuilding md cacheSebastian Hahn2011-05-09
| | | | Issue discovered using clang's static analyzer
* CONN_LOG_PROTECT()'s first argument may not be 0Sebastian Hahn2011-05-09
| | | | | | Make that explicit by adding an assert and removing a null-check. All of its callers currently depend on the argument being non-null anyway. Silences a few clang complaints.
* Appease clang - and my tortured mindSebastian Hahn2011-05-09
| | | | | This possible div by 0 warning from clang's analyzer was quite fun to track down. Turns out the current behaviour is safe.
* Add an assert to un-confuse clang's analyzerSebastian Hahn2011-05-09
| | | | | | | The analyzer assumed that bootstrap_percent could be less than 0 when we call control_event_bootstrap_problem(), which would mean we're calling log_fn() with undefined values. The assert makes it clear this can't happen.
* Fix a docstringSebastian Hahn2011-05-09
|
* Fix up some check-spaces issuesNick Mathewson2011-05-05
|
* Merge remote-tracking branch 'rransom/bug3106' into maint-0.2.2Nick Mathewson2011-05-04
|\
| * Handle crypto_pk_get_digest failures semi-sensiblyRobert Ransom2011-05-04
| | | | | | | | Fixes bug 3106.
* | Merge remote-tracking branch 'sebastian/win_warning' into maint-0.2.2Nick Mathewson2011-05-04
|\ \ | |/ |/|
| * Fix compile warning on windowsSebastian Hahn2011-05-05
| |
* | Fix circuit_list_path_impl(): internal circuits do not have an "exit". ↵Nick Mathewson2011-05-03
|/ | | | Trivial fix for 3079.
* Change who calls microdesc_cache_rebuild().Nick Mathewson2011-05-03
| | | | | | | | Previously we ensured that it would get called periodically by doing it from inside the code that added microdescriptors. That won't work though: it would interfere with our code that tried to read microdescs from disk initially. Instead, we should consider rebuilding the cache periodically, and on startup.
* Rebuild the microdesc cache when a sufficient number of bytes are droppedNick Mathewson2011-05-03
| | | | | | | | | | Previously on 0.2.2, we'd never clean the cache. Now that we can clean it, we want to add a condition to rebuild it: that should happen whenever we have dropped enough microdescriptors that we could save a lot of space. No changes file, since 0.2.3 doesn't need one and 0.2.2 already has some changes files for the backport of the microdesc_clean_cahce() function.
* Backport microdesc_cache_clean to 0.2.2Nick Mathewson2011-05-03
| | | | | Otherwise we have no way to keep authorities' microdesc caches in 0.2.2 from growing without bound.
* Fix a check for when to rebuild the microdesc cache. (Backport from 0.2.3.Nick Mathewson2011-05-03
|
* Add missing code to set cache->journal_len when reading microdesc journalNick Mathewson2011-05-03
| | | | | | This could be one reason that authorities' journals would grow without bound; related to bug 2230. Bugfix on 0.2.2.6-alpha. Fix by "cypherpunks".
* Clean up a warning a bitNick Mathewson2011-04-29
|
* Merge remote-tracking branch 'arma/bug3012' into maint-0.2.2Nick Mathewson2011-04-28
|\
| * relays checkpoint their state file twice a dayRoger Dingledine2011-04-28
| |
* | Merge remote-tracking branch 'arma/bug3039' into maint-0.2.2Nick Mathewson2011-04-28
|\ \ | |/ |/|
| * stop putting wacky values into state->lastwrittenRoger Dingledine2011-04-28
| |
* | Clarify comment to say which version fixed 2722Nick Mathewson2011-04-28
| |
| |
| \
*-. \ Merge remote-tracking branches 'rransom/bug2722' and 'rransom/bug2722b' into ↵Nick Mathewson2011-04-28
|\ \ \ | | | | | | | | | | | | maint-0.2.2
| | * | Add an XXX to the DA code regarding bug 2722Robert Ransom2011-04-18
| | | |
| * | | Revert "If we are not using BEGIN_DIR cells, don't attempt to contact hidden ↵Robert Ransom2011-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | service directories with non-open dir port." This reverts commit 9a7098487b2c25f36112b3521758f42621dcd6af. Conflicts: ChangeLog (left unchanged by this commit)
* | | | Merge remote-tracking branch 'sebastian/bug3020' into maint-0.2.2Nick Mathewson2011-04-28
|\ \ \ \ | |_|_|/ |/| | |
| * | | Correctly check elapsed time in last hibernation periodSebastian Hahn2011-04-29
| | | | | | | | | | | | | | | | Fix bug 3020.
* | | | fix a function commentRoger Dingledine2011-04-28
|/ / /
* | | Avoid false positives from proxy_mode()Nick Mathewson2011-04-28
| | | | | | | | | | | | | | | | | | | | | Previously it would erroneously return true if ListenAddr was set for a client port, even if that port itself was 0. This would give false positives, which were not previously harmful... but which were about to become.
* | | Fix bug 1930Robert Ransom2011-04-28
| | |
* | | Ignore SIGNAL NEWNYM on relay-only Tor instancesRobert Ransom2011-04-28
| | |
* | | Don't allow v0 HS auths to act as clientsRobert Ransom2011-04-28
| | | | | | | | | | | | | | | | | | | | | A v0 HS authority stores v0 HS descriptors in the same descriptor cache that its HS client functionality uses. Thus, if the HS authority operator clears its client HS descriptor cache, ALL v0 HS descriptors will be lost. That would be bad.
* | | Correct the logic from f14754fbd for tor_gmtime_rJohn Brooks2011-04-28
| | |
* | | Detect and handle NULL returns from (gm/local)time_rNick Mathewson2011-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These functions can return NULL for otherwise-valid values of time_t. Notably, the glibc gmtime manpage says it can return NULL if the year if greater than INT_MAX, and the windows MSDN gmtime page says it can return NULL for negative time_t values. Also, our formatting code is not guaranteed to correctly handle years after 9999 CE. This patch tries to correct this by detecting NULL values from gmtime/localtime_r, and trying to clip them to a reasonable end of the scale. If they are in the middle of the scale, we call it a downright error. Arguably, it's a bug to get out-of-bounds dates like this to begin with. But we've had bugs of this kind in the past, and warning when we see a bug is much kinder than doing a NULL-pointer dereference. Boboper found this one too.
* | | Merge remote-tracking branch 'sebastian/bug2497' into maint-0.2.2Nick Mathewson2011-04-28
|\ \ \
| * | | Don't report empty bw-history lines in extrainfoSebastian Hahn2011-04-19
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tor relays would report lines like these in their extrainfo documents: dirreq-write-history 2011-03-14 16:46:44 (900 s) This was confusing to some people who look at the stats. It would happen whenever a relay first starts up, or when a relay has dirport disabled. Change this so that lines without actual bw entries are omitted. Implements ticket 2497.
* | | Clean up merge of bug3k_021Robert Ransom2011-04-28
| | |
* | | Merge branch 'bug3k_021' into bug3k_022Sebastian Hahn2011-04-28
|\ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: src/or/or.h src/or/rendclient.c
| * | | Fix a failure case of connection_ap_handshake_attach_circuit()Sebastian Hahn2011-04-28
| | | | | | | | | | | | | | | | | | | | tor_fragile_assert() might be a no-op, so we have to return something here to indicate failure to the caller.
| * | | Fix a bug introduced by purging rend_cache on NEWNYMRobert Ransom2011-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the user sent a SIGNAL NEWNYM command after we fetched a rendezvous descriptor, while we were building the introduction-point circuit, we would give up entirely on trying to connect to the hidden service. Original patch by rransom slightly edited to go into 0.2.1
| * | | Allow rend_client_send_introduction to fail transientlyRobert Ransom2011-04-28
| | | | | | | | | | | | | | | | i.e. without closing the AP connection.
| * | | Forget all rendezvous client state on SIGNAL NEWNYMRobert Ransom2011-04-28
| | | |
* | | | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson2011-04-27
|\| | | | | | | | | | | | | | | | | | | Conflicts: src/common/torint.h
| * | | Make SIZE_T_CEILING unsigned; add a signed SSIZE_T_CEILINGNick Mathewson2011-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | None of the comparisons were _broken_ previously, but avoiding signed/unsigned comparisons makes everybody happier. Fixes bug2475.
* | | | Fix clear_trackhostexits_mapping() to actually work as advertisedNick Mathewson2011-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, it would remove every trackhostexits-derived mapping *from* xyz.<exitname>.exit; it was supposed to remove every trackhostexits-derived mapping *to* xyz.<exitname>.exit. Bugfix on 0.2.0.20-rc: fixes an XXX020 added while staring at bug-1090 issues.
* | | | make make check-spaces happier.Roger Dingledine2011-04-27
| | | | | | | | | | | | | | | | (still not happy.)
* | | | Fix double-free bug in microdesc parsercypherpunks2011-04-27
| | | |
* | | | explain an argument in a function commentRoger Dingledine2011-04-27
| | | |