| Commit message (Expand) | Author | Age |
... | |
| * | | | | | | Make the "2 unknown, 7 missing key..." messages easier to understand•••This patch should fix the cases we care about for bugs 1290 and 1145.
"30-56-99 are correct. Limited 4 and 8 are missing".
| Nick Mathewson | 2010-08-19 |
* | | | | | | | Merge remote branch 'sebastian/bug1525' | Nick Mathewson | 2010-09-13 |
|\ \ \ \ \ \ \ |
|
| * | | | | | | | Update some documentation for the bug 1525 fix | Sebastian Hahn | 2010-08-08 |
| * | | | | | | | Ensure controller RESOLVE commands respect __LeaveStreamsUnattached•••https://trac.torproject.org/projects/tor/ticket/1525
"The codepath taken by the control port "RESOLVE" command to create a
synthetic SOCKS resolve request isn't the same as the path taken by
a real SOCKS request from 'tor-resolve'.
This prevents controllers who set LeaveStreamsUnattached=1 from
being able to attach RESOLVE streams to circuits of their choosing."
Create a new function connection_ap_rewrite_and_attach_if_allowed()
and call that when Tor needs to attach a stream to a circuit but
needs to know if the controller permits it.
No tests added.
| Robert Hogan | 2010-08-08 |
* | | | | | | | | Merge branch 'bug1138' | Nick Mathewson | 2010-09-12 |
|\ \ \ \ \ \ \ \ |
|
| * | | | | | | | | Clean up a couple more bug1138 issues mentioned by roger on code review | Nick Mathewson | 2010-09-12 |
| * | | | | | | | | Handle null conn->requested_resource rather than assert•••Per arma's comments in bug1138
| Robert Hogan | 2010-09-12 |
| * | | | | | | | | Nick points out:•••tor_assert(!conn->_base.purpose == DIR_PURPOSE_FETCH_EXTRAINFO)
!=
tor_assert(conn->_base.purpose != DIR_PURPOSE_FETCH_EXTRAINFO)
!!
| Robert Hogan | 2010-09-02 |
| * | | | | | | | | Amend per Sebastian's comments:••• - Move checks for extra_info to callers
- Change argument name from failed to descs
- Use strlen("fp/") instead of a magic number
- I passed on the suggestion to rename functions from *_failed() to
*_handle_failure(). There are a lot of these so for now just follow
the house style.
| Robert Hogan | 2010-09-02 |
| * | | | | | | | | Fall back to direct descriptor request to bridges when••• requests to authorities fail due to a network error.
Bug#1138
"When a Tor client starts up using a bridge, and UpdateBridgesFromAuthority
is set, Tor will go to the authority first and look up the bridge by
fingerprint. If the bridge authority is filtered, Tor will never notice that
the bridge authority lookup failed. So it will never fall back."
Add connection_dir_bridge_routerdesc_failed(), a function for unpacking
the bridge information from a failed request, and ensure
connection_dir_request_failed() calls it if the failed request
was for a bridge descriptor.
Test:
1. for ip in `grep -iR 'router ' cached-descriptors|cut -d ' ' -f 3`;
do sudo iptables -A OUTPUT -p tcp -d $ip -j DROP; done
2. remove all files from user tor directory
3. Put the following in torrc:
UseBridges 1
UpdateBridgesFromAuthority 1
Bridge 85.108.88.19:443 7E1B28DB47C175392A0E8E4A287C7CB8686575B7
4. Launch tor - it should fall back to downloading descriptors
directly from the bridge.
Initial patch reviewed and corrected by mingw-san.
| Robert Hogan | 2010-08-16 |
* | | | | | | | | | Make authorities download consensuses if appropriate•••An authority should never download a consensus if it has a live one,
but when it doesn't, it should admit that it's not going to get one,
and see if anybody else can give it one.
Fixes 1300, fix on 0.2.0.9-alpha
| Nick Mathewson | 2010-09-12 |
* | | | | | | | | | fix regression introduced by 1a65bdd2•••noticed while reviewing hoganrobert/bug1138
| Roger Dingledine | 2010-09-12 |
* | | | | | | | | | Update to the latest tinytest version•••This cleans up some whitespace consistency issues and, more
importantly, gives you the ability to skip tests from the command
line.
| Nick Mathewson | 2010-09-09 |
| |_|_|_|_|_|/ /
|/| | | | | | | |
|
* | | | | | | | | Merge remote branch 'origin/maint-0.2.1' | Nick Mathewson | 2010-09-08 |
|\ \ \ \ \ \ \ \
| | |_|_|_|_|_|/
| |/| | | | | | |
|
| * | | | | | | | Merge remote branch 'karsten/geoip-sep2010' into maint-0.2.1 | Nick Mathewson | 2010-09-08 |
| |\ \ \ \ \ \ \ |
|
| | * | | | | | | | Update to the September 1 2010 Maxmind GeoLite Country database. | Karsten Loesing | 2010-09-08 |
* | | | | | | | | | be more consistent in using streamid_t | Nick Mathewson | 2010-09-08 |
* | | | | | | | | | Merge branch 'bug1653' | Nick Mathewson | 2010-09-08 |
|\ \ \ \ \ \ \ \ \ |
|
| * | | | | | | | | | Fix a missing stream_id argument; found by "tracktor" | Nick Mathewson | 2010-09-03 |
| * | | | | | | | | | Fix behavior of adding a cell to a blocked queue.•••We frequently add cells to stream-blocked queues for valid reasons
that don't mean we need to block streams. The most obvious reason
is if the cell arrives over a circuit rather than from an edge: we
don't block circuits, no matter how full queues get. The next most
obvious reason is that we allow CONNECTED cells from a newly created
stream to get delivered just fine.
This patch changes the behavior so that we only iterate over the
streams on a circuit when the cell in question came from a stream,
and we only block the stream that generated the cell, so that other
streams can still get their CONNECTEDs in.
| Nick Mathewson | 2010-09-02 |
| * | | | | | | | | | Detect if we try to put a cell onto a supposedly blocked cell queue.•••When this happens, run through the streams on the circuit and make
sure they're all blocked. If some aren't, that's a bug: block them
all and log it! If they all are, where did the cell come from? Log
it!
(I suspect that this actually happens pretty frequently, so I'm making
these log messages appear at INFO.)
| Nick Mathewson | 2010-08-18 |
| * | | | | | | | | | Decide whether to ignore SENDMEs based on streams_blocked, not queue size | Nick Mathewson | 2010-08-18 |
| * | | | | | | | | | Avoid over-filling cell queues when we receive a SENDME•••Do not start reading on exit streams when we get a SENDME unless we
have space in the appropriate circuit's cell queue.
Draft fix for bug 1653.
(commit message by nickm)
| yetonetime | 2010-08-18 |
* | | | | | | | | | | Merge remote branch 'origin/maint-0.2.1' | Nick Mathewson | 2010-09-08 |
|\ \ \ \ \ \ \ \ \ \
| | |/ / / / / / / /
| |/| | | | | | | | |
|
| * | | | | | | | | | Remove a needless keep_open_until_flushed | Nick Mathewson | 2010-09-08 |
| * | | | | | | | | | Close a non-open OR connection *only* after KeepalivePeriod.•••When we introduced the code to close non-open OR connections after
KeepalivePeriod had passed, we replaced some code that said
if (!connection_is_open(conn)) {
/* let it keep handshaking forever */
} else if (do other tests here) {
...
with new code that said
if (!connection_is_open(conn) && past_keepalive) {
/* let it keep handshaking forever */
} else if (do other tests here) {
...
This was a mistake, since it made all the other tests start applying
to non-open connections, thus causing bug 1840, where non-open
connections get closed way early.
Fixes bug 1840. Bugfix on 0.2.1.26 (commit 67b38d50).
| Nick Mathewson | 2010-09-03 |
| | |/ / / / / / /
| |/| | | | | | | |
|
* | | | | | | | | | Merge remote branch 'public/win_unicode_fixes' | Nick Mathewson | 2010-09-06 |
|\ \ \ \ \ \ \ \ \
| |_|_|_|_|_|_|_|/
|/| | | | | | | | |
|
| * | | | | | | | | Make the windows build succeed with or without -DUNICODE enabled.•••This should keep WinCE working (unicode always-on) and get Win98
working again (unicode never-on).
There are two places where we explicitly use ASCII-only APIs, still:
in ntmain.c and in the unit tests.
This patch also fixes a bug in windoes tor_listdir that would cause
the first file to be listed an arbitrary number of times that was
also introduced with WinCE support.
Should fix bug 1797.
| Nick Mathewson | 2010-08-20 |
| | |_|_|_|_|/ /
| |/| | | | | | |
|
* | | | | | | | | Merge branch 'ratelim' | Nick Mathewson | 2010-08-31 |
|\ \ \ \ \ \ \ \ |
|
| * | | | | | | | | Fix some issues in rate-limiting noticed by Sebastian | Nick Mathewson | 2010-08-31 |
| * | | | | | | | | Add a generic rate-limited log mechanism, and use it in a few places•••Incidentally fixes bug 1042.
| Nick Mathewson | 2010-08-18 |
| | |_|/ / / / /
| |/| | | | | | |
|
* | | | | | | | | Fix a compile warning on OpenBSD | Sebastian Hahn | 2010-08-22 |
| |/ / / / / /
|/| | | | | | |
|
* | | | | | | | Add unit test for tor_listdir. | Nick Mathewson | 2010-08-20 |
* | | | | | | | Merge commit 'sebastian/bug1843' | Nick Mathewson | 2010-08-20 |
|\ \ \ \ \ \ \ |
|
| * | | | | | | | Warn for bad combination of cookie options•••Setting CookieAuthFileGroupReadable but without setting CookieAuthFile makes
no sense, because unix directory permissions for the data directory prevent
the group from accessing the file anyways.
| Sebastian Hahn | 2010-08-20 |
* | | | | | | | | Bump version to 0.2.2.15-alpha-dev | Nick Mathewson | 2010-08-19 |
|/ / / / / / / |
|
* | | | | / / | Fix up compilation on windows. | Nick Mathewson | 2010-08-19 |
| |_|_|_|/ /
|/| | | | | |
|
* | | | | | | bump to 0.2.2.15-alpha | Roger Dingledine | 2010-08-18 |
* | | | | | | delay geoip stats even more for relays-turned-bridges | Roger Dingledine | 2010-08-18 |
|/ / / / / |
|
* | | | | | Merge commit 'origin/maint-0.2.1'•••Conflicts:
src/or/reasons.c
| Nick Mathewson | 2010-08-18 |
|\| | | | |
|
| * | | | | Backport END_STREAM_REASON_NOROUTE for client use.•••(Partial backport of 150ed553dfce9, 161b275028e90, and 4c948ffd6.)
| Sebastian Hahn | 2010-08-18 |
* | | | | | Merge commit 'karsten/dirbytes2'•••Conflicts:
src/or/rephist.h
| Nick Mathewson | 2010-08-18 |
|\ \ \ \ \ |
|
| * | | | | | Correctly report written bytes on linked connections. | Karsten Loesing | 2010-08-18 |
| * | | | | | Count bytes we spend on answering directory requests. | Karsten Loesing | 2010-08-18 |
* | | | | | | Remove unused function declarations•••Also remove some #if 0'd code from the unit tests for buffers. The
code was killed in e6794e58081af773073c266e23fe3ab2ebecdb7e (5 years
ago), and is now broken anyways.
| Sebastian Hahn | 2010-08-17 |
* | | | | | | Merge branch 'maint-0.2.1'•••Resolved conflict in
src/or/networkstatus.c
| Nick Mathewson | 2010-08-17 |
|\ \ \ \ \ \
| | |/ / / /
| |/| | | | |
|
| * | | | | | Merge branch 'bug1141_v3' into maint-0.2.1 | Nick Mathewson | 2010-08-17 |
| |\ \ \ \ \ |
|
| | * | | | | | Scale CONSENSUS_MIN_SECONDS_BEFORE_CACHING by voting interval•••If the voting interval was short enough, the two-minutes delay
of CONSENSUS_MIN_SECONDS_BEFORE_CACHING would confuse bridges
to the point where they would assert before downloading a consensus.
It it was even shorter (<4 minutes, I think), caches would
assert too. This patch fixes that by having replacing the
two-minutes value with MIN(2 minutes, interval/16).
Bugfix for 1141; the cache bug could occur since 0.2.0.8-alpha, so
I'm calling this a bugfix on that. Robert Hogan diagnosed this.
Done as a patch against maint-0.2.1, since it makes it hard to
run some kinds of testing networks.
| Nick Mathewson | 2010-08-17 |
* | | | | | | | Merge commit 'public/warn1125' | Nick Mathewson | 2010-08-16 |
|\ \ \ \ \ \ \ |
|
| * | | | | | | | Make buf_shrink_freelists warn, not crash, when n_to_skip is too high•••This mitigates bug 1125, but doesn't fix its root cause (whatever
that is).
| Nick Mathewson | 2010-08-10 |