| Commit message (Expand) | Author | Age |
... | |
| * | | | Never emit the "opt" prefix in any directory stuff•••Fix for bug 5124.
| Nick Mathewson | 2012-06-28 |
* | | | | Speak not the name of INT_MIN; it can upset older compilers•••And more to the point, some GCCs will warn that you can't say it
before C90.
Bug not in any released version of Tor.
| Nick Mathewson | 2012-08-03 |
* | | | | Fix a bunch of "implicit 64->32" warnings from introduce refactoring | Nick Mathewson | 2012-08-03 |
* | | | | test_assert is always in affect: no need for extra gotos | Nick Mathewson | 2012-07-31 |
* | | | | Remove duplicate code in test_introduce.c•••Two of the do_*_test functions were actually prefixes of the third,
which suggests a trivial code elimination step
| Nick Mathewson | 2012-07-31 |
* | | | | Unit tests for new rend_intro_cell_t parser | Andrea Shepard | 2012-07-31 |
* | | | | Implement replaycache_t for bug 6177, and unit tests for the preceding | Andrea Shepard | 2012-07-31 |
* | | | | Merge remote-tracking branch 'origin/maint-0.2.3' | Nick Mathewson | 2012-07-18 |
|\ \ \ \
| | |/ /
| |/| | |
|
| * | | | Change all SMARTLIST_FOREACH loops of >=10 lines to use BEGIN/END•••The SMARTLIST_FOREACH macro is more convenient than BEGIN/END when
you have a nice short loop body, but using it for long bodies makes
your preprocessor tell the compiler that all the code is on the same
line. That causes grief, since compiler warnings and debugger lines
will all refer to that one line.
So, here's a new style rule: SMARTLIST_FOREACH blocks need to be
short.
| Nick Mathewson | 2012-07-17 |
* | | | | Fix compilation on 32-bit. Fix for bug 6277, not in any released tor. | Nick Mathewson | 2012-07-05 |
| |/ /
|/| | |
|
* | | | Make check-spaces happy again | Nick Mathewson | 2012-06-28 |
* | | | Extend tor_sscanf so it can replace sscanf in rephist.c•••Fixes bug 4195 and Coverity CID 448
| Nick Mathewson | 2012-06-28 |
|/ / |
|
* | | Merge remote-tracking branch 'public/bug6227' into maint-0.2.3 | Nick Mathewson | 2012-06-26 |
|\ \ |
|
| * | | Bump the test util/threads timeout up to 150 sec•••This should make some debian build systems happier.
Also, increase the select() timeout to a more reasonable 100 msec.
| Nick Mathewson | 2012-06-25 |
* | | | Add a unit test for environment_variable_names_equal•••I need this because I'm about to frob that function to stop using
strcspn() in order to get rid of a clang warning.
| Nick Mathewson | 2012-06-26 |
|/ / |
|
* | | Resolve crash caused by format_helper_exit_status changes in #5557•••Because the string output was no longer equal in length to
HEX_ERRNO_SIZE, the write() call would add some extra spaces and
maybe a NUL, and the NUL would trigger an assert in
get_string_from_pipe.
Fixes bug 6225; bug not in any released version of Tor.
| Nick Mathewson | 2012-06-23 |
* | | Add unit test for format_hex_number_for_helper_exit_status() | Andrea Shepard | 2012-06-22 |
* | | Make format_helper_exit_status() avoid unnecessary spaces | Andrea Shepard | 2012-06-22 |
* | | Merge remote-tracking branch 'public/bug3940_redux' | Nick Mathewson | 2012-06-13 |
|\ \ |
|
| * | | An attempt at bug3940 and making AllowDotExit 0 work with MapAddress•••This time, I follow grarpamp's suggestion and move the check for
.exit+AllowDotExit 0 to the top of connection_ap_rewrite_and_attach,
before any rewriting occurs. This way, .exit addresses are
forbidden as they arrive from a socks connection or a DNSPort
request, and not otherwise.
It _is_ a little more complicated than that, though. We need to
treat any .exit addresses whose source is TrackHostExits as meaning
that we can retry without that exit. We also need to treat any
.exit address that comes from an AutomapHostsOnResolve operation as
user-provided (and thus forbidden if AllowDotExits==0), so that
transitioning from AllowDotExits==1 to AllowDotExits==0 will
actually turn off automapped .exit addresses.
| Nick Mathewson | 2012-05-11 |
* | | | Fix mingw build with -DUNICODE -D_UNICODE•••This is a very blunt fix, and mostly just turns some func() calls
into FuncA() to make things build again. Fixes bug 6097.
| Nick Mathewson | 2012-06-07 |
* | | | Fix some mingw build warnings•••These include:
- Having a weird in_addr that can't be initialized with {0}
- Needing INVALID_HANDLE_VALUE instead of -1 for file handles.
- Having a weird dependent definition for struct stat.
- pid is signed, not unsigned.
| Nick Mathewson | 2012-06-05 |
* | | | Update copyright dates to 2012; add a few missing copyright statements | Nick Mathewson | 2012-06-04 |
* | | | Fix build warning on Lenny about strtok_r unit test•••This fixes a warning in efb8a09f, where Debain Lenny's GCC doesn't get
that
for (i=0; i<3; ++i) {
const char *p;
switch(i) {
case 0:
p="X"; break;
case 1:
p="Y"; break;
case 2:
p="Z"; break;
}
printf("%s\n", p);
}
will never try to print an uninitialezed value.
Found by buildbots. Bug in no released versions of Tor.
| Nick Mathewson | 2012-06-04 |
* | | | Merge remote-tracking branch 'public/bug5089'•••Conflicts:
src/test/test_util.c
Merge the unit tests; I added some when I did this branch against
0.2.2, and then the test format changed and master added more tests.
| Nick Mathewson | 2012-05-31 |
|\ \ \ |
|
| * | | | A few more get_parent_directory tests. | Nick Mathewson | 2012-05-31 |
| * | | | Have get_parent_directory() handle "/foo" and "/" correctly.•••The parent of "/foo" is "/"; and "/" is its own parent.
This would cause Tor to fail if you tried to have a PF_UNIX control
socket in the root directory. That would be a stupid thing to do
for other reasons, but there's no reason to fail like _this_.
Bug found by Esteban Manchado Velázquez. Fix for bug 5089; bugfix on
Tor 0.2.2.26-beta. Unit test included.
| Nick Mathewson | 2012-05-24 |
| | |/
| |/| |
|
* | | | Fix the unittest breakage introduced by a8a862c. | George Kadianakis | 2012-05-18 |
* | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2012-05-16 |
|\| | |
|
| * | | Make the succeeding parse_http_time tests more obviously right•••(When the correct answer is given in terms of seconds since the
epoch, it's hard to be sure that it really is the right answer
just by reading the code.)
| Nick Mathewson | 2012-05-16 |
| * | | Fix month check in parse_http_time, add test | Sebastian Hahn | 2012-05-16 |
| * | | Reject an additional type of bad date in parse_http_time | Nick Mathewson | 2012-05-16 |
| * | | Fix parse_http_time and add tests•••* It seems parse_http_time wasn't parsing correctly any date with commas (RFCs
1123 and 850). Fix that.
* It seems parse_http_time was reporting the wrong month (they start at 0, not
1). Fix that.
* Add some tests for parse_http_time, covering all three formats.
| Esteban Manchado Velázquez | 2012-05-16 |
* | | | Fix some remaining nmake/msvc build issues | Nick Mathewson | 2012-05-16 |
| |/
|/| |
|
* | | Fix a couple of wide lines | Nick Mathewson | 2012-05-11 |
* | | Merge remote-tracking branch 'public/bug5091' | Nick Mathewson | 2012-05-11 |
|\ \ |
|
| * | | Fix tor_strtok_r_impl and test cases per bug #5091•••==
Nick here. I tweaked this patch a little to make it apply cleanly to
master, to extract some common code into a function, and to replace
snprintf with tor_snprintf.
-- nickm
| nils | 2012-03-30 |
* | | | Merge remote-tracking branch 'origin/maint-0.2.2'•••Conflicts:
src/common/util.c
src/test/test_util.c
| Nick Mathewson | 2012-05-10 |
|\ \ \
| | |/
| |/| |
|
| * | | Handle out-of-range values in tor_parse_* integer functions•••The underlying strtoX functions handle overflow by saturating and
setting errno to ERANGE. If the min/max arguments to the
tor_parse_* functions are equal to the minimum/maximum of the
underlying type, then with the old approach, we wouldn't treat a
too-large value as genuinely broken.
Found this while looking at bug 5786; bugfix on 19da1f36 (in Tor
0.0.9), which introduced these functions.
| Nick Mathewson | 2012-05-07 |
| * | | Add a sha256 hmac function, with tests•••(cherry picked from commit fdbb9cdf746bbf0c39c34188baa8872471183ff7)
| Nick Mathewson | 2012-02-22 |
* | | | Fix a segfault in pt/protocol test•••Now that the pt code logs mp->argv[0] all over the place, we need to
be sure to set up mp->argv in our tests.
Bugfix on e603692adcd, not in any released version.
| Nick Mathewson | 2012-05-08 |
* | | | Several mingw/msvc/cross-compilation fixes•••They boil down to:
- MS_WINDOWS is dead and replaced with _WIN32, but we let a few
instances creep in when we merged Esteban's tests.
- Capitalizing windows header names confuses mingw.
- #ifdef 0 ain't C.
- One unit test wasn't compiled on windows, but was being listed
anyway.
- One unit test was checking for the wrong value.
Gisle Vanem found and fixed the latter 3 issues.
| Nick Mathewson | 2012-04-26 |
* | | | tor_vsscanf(): Don't return -1 if '%%' doesn't match.•••tor_vsscanf() is supposed to return the current number of matches on
match failure.
| George Kadianakis | 2012-04-03 |
| |/
|/| |
|
* | | Fix a couple of "unused assigned value" warnings in parse_config tests•••Coverity doesn't like the fact that we were storing the value of
parse_config_line_from_str() but not checking it in a couple of
cases.
Fixes CID 505 and 506.
| Nick Mathewson | 2012-03-30 |
* | | Fix a bunch of check-spaces complaints | Sebastian Hahn | 2012-03-28 |
* | | Refactor the API for setting up a block cipher.•••It allows us more flexibility on the backend if the user needs to
specify the key and IV at setup time.
| Nick Mathewson | 2012-03-27 |
* | | Remove support for PK_NO_PADDING in crypto_pk_public_hybrid_encrypt•••We never use it, and it would be a stupid thing if we started using it.
| Nick Mathewson | 2012-03-27 |
* | | Merge remote-tracking branch 'karsten/bug5053' | Nick Mathewson | 2012-03-27 |
|\ \ |
|
| * | | Count IPv6 connections in bridge and entry stats. | Karsten Loesing | 2012-02-09 |
* | | | Provide large enough buffer in test_util_sscanf()•••This was causing crashes during unit test runs, as stack smashing
protections got triggered. Issue spotted by weasel
| Sebastian Hahn | 2012-03-27 |