aboutsummaryrefslogtreecommitdiff
path: root/src/or
Commit message (Collapse)AuthorAge
* Bulletproof our 11246 fix a little, based on recommendation from andrea.Nick Mathewson2014-06-04
|
* count DATA cells with stream ID 0 as delivered for SENDME purposesNick Mathewson2013-03-22
| | | | | | | | | Found while investigating 8093, but probably not the cause of it, since this bug would result in us sending too few SENDMEs, not in us receiving SENDMEs unexpectedly. Bugfix on the fix for 7889, which has appeared in 0.2.4.10-alpha, but not yet in any released 0.2.3.x version.
* oops; add a missing semicolonNick Mathewson2013-02-12
| | | | (Cherry-picked from fc35ee4910326dc1ae718482b30e57666a71df85)
* Check whether ei is non-NULL before altering it.Nick Mathewson2013-02-11
| | | | | | | This fixes a crash bug if we fail to generate an extrainfo descriptor. Fixes bug 8208; bugfix on 0.2.3.16-alpha.
* Reject create/begin/etc cells with {circ,stream}ID 0.Nick Mathewson2013-01-14
| | | | | | | | Otherwise, it's possible to create streams or circuits with these bogus IDs, leading to orphaned circuits or streams, or to ones that can cause bandwidth DOS problems. Fixes bug 7889; bugfix on all released Tors.
* use a more logical operatorRoger Dingledine2012-11-12
| | | | | | | Fix a harmless bug when opting against publishing a relay descriptor because DisableNetwork is set. Fixes bug 7464; bugfix on 0.2.3.9-alpha.
* Add and use and unlikely-to-be-eliminated memwipe()Nick Mathewson2012-11-08
| | | | | | | | | | Apparently some compilers like to eliminate memset() operations on data that's about to go out-of-scope. I've gone with the safest possible replacement, which might be a bit slow. I don't think this is critical path in any way that will affect performance, but if it is, we can work on that in 0.2.4. Fixes bug 7352.
* Fix a remotely triggerable assertion failure (CVE-2012-2250)Nick Mathewson2012-10-23
| | | | | | | | | | | | | If we completed the handshake for the v2 link protocol but wound up negotiating the wong protocol version, we'd become so confused about what part of the handshake we were in that we'd promptly die with an assertion. This is a fix for CVE-2012-2250; it's a bugfix on 0.2.3.6-alpha. All servers running that version or later should really upgrade. Bug and fix from "some guy from France." I tweaked his code slightly to make it log the IP of the offending node.
* Let 0.2.3 clients exit to internal addresses if they wantRoger Dingledine2012-10-23
| | | | | | | Clients now consider the ClientRejectInternalAddresses config option when using a microdescriptor consensus stanza to decide whether an exit relay would allow exiting to an internal address. Fixes bug 7190; bugfix on 0.2.3.1-alpha.
* Fix parse_short_policy (bug 7192.)Nick Mathewson2012-10-23
| | | | | | | | | | | Our implementation of parse_short_policy was screwed up: it would ignore the last character of every short policy. Obviously, that's broken. This patch fixes the busted behavior, and adds a bunch of unit tests to make sure the rest of that function is okay. Fixes bug 7192; fix on 0.2.3.1-alpha.
* add a unit test to expose bug 7192Roger Dingledine2012-10-22
|
* Merge branch 'block_renegotiate_023' into maint-0.2.3Nick Mathewson2012-10-19
|\
| * Discard extraneous renegotiation attempts in the v3 link protocolNick Mathewson2012-10-17
| | | | | | | | | | | | Failure to do so left us open to a remotely triggerable assertion failure. Fixes CVE-2012-2249; bugfix on 0.2.3.6-alpha. Reported by "some guy from France".
* | Don't serve or accept v2 HS descs over a DirPortRobert Ransom2012-10-19
|/ | | | (changes file tweaked by nickm)
* Don't call fmt_addr() twice in a parameter list.George Kadianakis2012-10-09
|
* Merge remote-tracking branch 'arma/bug7037' into maint-0.2.3Nick Mathewson2012-10-04
|\
| * Refuse extra create cells with reason "resource limit"Roger Dingledine2012-10-03
| | | | | | | | | | In the past we had used reason "internal", which is more vague than it needs to be. Resolves bug 7037.
* | properly free the return values of rate_limit_log()Roger Dingledine2012-10-03
|/ | | | resolves bug 7022.
* add faravahar as our ninth v3 dir authRoger Dingledine2012-09-22
|
* Whitespace fixesNick Mathewson2012-09-18
|
* Bug 6866: Convert pathbias asserts into log messages.Mike Perry2012-09-17
| | | | Asserts were hit by Tor2Web mode.
* Avoid undefined behaviour when parsing HS protocol versionsRobert Ransom2012-09-13
| | | | | | | Fixes bug 6827; bugfix on c58675ca728f12b42f65e5b8964ae695c2e0ec2d (when the v2 HS desc parser was implemented). Found by asn.
* Merge remote-tracking branch 'public/bug6341_a_v2' into maint-0.2.3Nick Mathewson2012-09-12
|\
| * Check ewma_enabled before doing circ-has-become-inactive checkNick Mathewson2012-07-18
| | | | | | | | | | | | | | | | This avoids a possible crash bug in flush_from_first_active_circuit. Fixes bug 6341; bugfix on 0.2.2.7-alpha. Bug reported and fixed by a pseudonymous user on IRC.
* | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2012-09-11
|\ \ | | | | | | | | | | | | Conflicts: src/test/test_util.c
| * | Fix assertion failure in tor_timegm.Nick Mathewson2012-09-11
| | | | | | | | | | | | Fixes bug 6811.
* | | Avoid segfault when reading state file from ancient torNick Mathewson2012-09-10
| | | | | | | | | | | | | | | | | | | | | If s_values is null in rep_hist_load_bwhist_state_section, we would call smartlist_len() on it, and die. Fixes bug 6801.
* | | Avoid segfault if EntryGuardPathBias precedes EntryGuardNick Mathewson2012-09-05
| | | | | | | | | | | | Fix for bug 6774; bugfix on 0.2.3.17-beta.
* | | Merge remote-tracking branch 'arma/bug6743' into maint-0.2.3Nick Mathewson2012-09-04
|\ \ \
| * | | Make begindir_cutoff the same as general_cutoffRoger Dingledine2012-09-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow one-hop directory fetching circuits the full "circuit build timeout" period, rather than just half of it, before failing them and marking the relay down. This fix should help reduce cases where clients declare relays (or worse, bridges) unreachable because the TLS handshake takes a few seconds to complete. Fixes bug 6743 (one piece of bug 3443); bugfix on 0.2.2.2-alpha, where we changed the timeout from a static 30 seconds.
* | | | fix whitespace and trivial typoRoger Dingledine2012-09-03
|/ / /
* | | Quiet "Set buildtimeout to low val" warnings: make them infoNick Mathewson2012-08-27
| | | | | | | | | | | | Fix for #6251
* | | Downgrade path-bias warning messages to INFO for now.Nick Mathewson2012-08-27
| | | | | | | | | | | | | | | | | | | | | We've had over two months to fix them, and didn't. Now we need 0.2.3.x stable. Yes, it would be cool to get this working in 0.2.3.x, but not at the expense of delaying every other feature that _does_ work in 0.2.3.x. We can do a real fix in 0.2.4.
* | | Merge branch 'bug6710_023' into maint-0.2.3Nick Mathewson2012-08-27
|\ \ \
| * | | Disable extending to private/internal addresses by defaultNick Mathewson2012-08-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is important, since otherwise an attacker can use timing info to probe the internal network. Also, add an option (ExtendAllowPrivateAddresses) so that TestingTorNetwork won't break. Fix for bug 6710; bugfix on all released versions of Tor.
* | | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2012-08-27
|\ \ \ \ | |/ / / |/| / / | |/ / | | | Conflicts: src/or/policies.c
| * | Do not assert when comparing a null address/port against a policyNick Mathewson2012-08-27
| | | | | | | | | | | | | | | This can create a remote crash opportunity for/against directory authorities.
* | | Merge remote-tracking branch 'public/bug6472' into maint-0.2.3Nick Mathewson2012-08-24
|\ \ \
| * | | When iterating over connections pending DNS, skip marked onesNick Mathewson2012-08-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Failure to do this would lead to double-free cases and similar, especially when the exit's DNS was broken. See bug 6472 for full details; this is a fix for 6472. Anonymous patch from "cypherpunks" on trac.
* | | | Merge remote-tracking branch 'public/bug6404' into maint-0.2.3Nick Mathewson2012-08-21
|\ \ \ \
| * | | | Fix memory leak in dirvote_create_microdescriptorNick Mathewson2012-08-14
| | | | | | | | | | | | | | | | | | | | Found by George, who gets a cookie.
| * | | | Remove the upper limit on the size of MD we can generate.Nick Mathewson2012-07-31
| | | | |
| * | | | Warn at parse time for routerstatus entry missing a microdesc consensusNick Mathewson2012-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 0.2.3.18-rc, we started warning on this case while building a list of missing microdescriptor digests. That turned out to spam the logs; instead let's warn at parse time. Partial fix for bug 6404.
| * | | | Don't include a router in an md consensus if we can't find a md for it.Nick Mathewson2012-07-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec requires that every router in a microdesc consensus have an m line; we weren't obeying that spec. This creates a new consensus method (13) to allow voting to continue to work right. Partial fix for bug 6404; fix on 0.2.2.6-alpha.
| * | | | Allow microdescs to be up to 2k. Partial fix for 6404.Nick Mathewson2012-07-31
| | | | |
* | | | | whitespace fixNick Mathewson2012-08-17
| |/ / / |/| | |
* | | | Consider IPv6 OR ports when deciding whether a routerinfo change is cosmetic.Linus Nordberg2012-08-17
| | | | | | | | | | | | | | | | Closes #6423.
* | | | Merge remote-tracking branch 'public/bug6244_part_c' into maint-0.2.3Nick Mathewson2012-08-17
|\ \ \ \
| * | | | Fix wildcarded address mappings from the control portNick Mathewson2012-08-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apparently, we weren't actually detecting wildcardedness when parsing them: whoops! bug 6244. Bugfix on 0.2.3.9-alpha
| * | | | Raise the part of torrc mapaddress handling that knows wildcardsNick Mathewson2012-08-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch extracts the inner part of config_register_addressmaps -- the part that knows about detecting wildcard addresses addresses -- and makes it into a new function. The new function is deliberately not moved or reindented, so that the diff is smaller. I need this to fix bug 6244.