aboutsummaryrefslogtreecommitdiff
path: root/src/or
Commit message (Collapse)AuthorAge
* Avoid double-free on failure to dump_descriptor() a cached mdNick Mathewson2013-12-17
| | | | | | This is a fix for 10423, which was introducd in caa0d15c in 0.2.4.13-alpha. Spotted by bobnomnom.
* Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-11-15
|\ | | | | | | | | | | | | | | | | | | Conflicts: src/or/or.h src/or/relay.c Conflicts were simple to resolve. More fixes were needed for compilation, including: reinstating the tv_to_msec function, and renaming *_conn_cells to *_chan_cells.
| * Improved circuit queue out-of-memory handlerNick Mathewson2013-11-07
| | | | | | | | | | | | | | | | | | | | | | Previously, when we ran low on memory, we'd close whichever circuits had the most queued cells. Now, we close those that have the *oldest* queued cells, on the theory that those are most responsible for us running low on memory, and that those are the least likely to actually drain on their own if we wait a little longer. Based on analysis from a forthcoming paper by Jansen, Tschorsch, Johnson, and Scheuermann. Fixes bug 9093.
* | Fix two more DirServer mentions in logNick Mathewson2013-11-10
| |
* | Fix a wide lineNick Mathewson2013-11-10
| |
* | Change documentation DirServer->DirAuthorityNick Mathewson2013-11-10
| | | | | | | | | | | | | | We renamed the option, but we didn't actually fix it in the log messages or the docs. This patch does that. For #10124. Patch by sqrt2.
* | Merge remote-tracking branch 'public/bug9645' into maint-0.2.4Nick Mathewson2013-10-31
|\ \
| * | Fix bug 9645: don't forget an md just because we can't save it.Nick Mathewson2013-09-03
| | |
* | | Merge remote-tracking branch 'public/bug9731b' into maint-0.2.4Nick Mathewson2013-10-31
|\ \ \
| * | | Don't apply read/write buckets to cpuworker connectionsNick Mathewson2013-09-13
| | | | | | | | | | | | | | | | Fixes bug 9731
* | | | be willing to bootstrap from all three of our directory guardsRoger Dingledine2013-10-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also fix a bug where if the guard we choose first doesn't answer, we would try the second guard, but once we connected to the second guard we would abandon it and retry the first one, slowing down bootstrapping. The fix in both cases is to treat all our initially chosen guards as acceptable to use. Fixes bug 9946.
* | | | Merge branch 'bug9644_024' into maint-0.2.4Nick Mathewson2013-10-10
|\ \ \ \
| * | | | When freeing a cert_list_t, avoid memory leak.Nick Mathewson2013-09-19
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were freeing these on exit, but when we added the dl_status_map field to them in fddb814f, we forgot to arrange for it to be freed. I've moved the cert_list_free() code into its own function, and added an appropriate dsmap_free() call. Fixes bug 9644; bugfix on 0.2.4.13-alpha.
* | | | Merge remote-tracking branch 'public/bug9927' into maint-0.2.4Nick Mathewson2013-10-08
|\ \ \ \
| * | | | Generate bootstrapping status messages for microdescs tooNick Mathewson2013-10-08
| | | | | | | | | | | | | | | | | | | | Fix for 9927.
* | | | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-10-08
|\ \ \ \ \ | | |_|_|/ | |/| | |
| * | | | Fix an assert when disabling ORPort with accounting disabled.Nick Mathewson2013-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was that the server_identity_key_is_set() function could return true under conditions where we don't really have an identity key -- specifically, where we used to have one, but we stopped being a server. This is a fix for 6979; bugfix on 0.2.2.18-alpha where we added that assertion to get_server_identity_key().
* | | | | Merge remote-tracking branch 'public/bug9596' into maint-0.2.4Nick Mathewson2013-10-08
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Increase POLICY_BUF_LEN to 72 to accomodate IPv6 exit policy items.Nick Mathewson2013-08-26
| | |_|/ | |/| | | | | | | | | | Fixes bug 9596; bugfix on 0.2.4.7-alpha.
* | | | Fix a bug in our bug 9776 fix.Nick Mathewson2013-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By calling circuit_n_chan_done() unconditionally on close, we were closing pending connections that might not have been pending quite for the connection we were closing. Fix for bug 9880. Thanks to skruffy for finding this and explaining it patiently until we understood.
* | | | Always call circuit_n_chan_done(chan, 0) from channel_closed()Andrea Shepard2013-09-24
| | | |
* | | | Fix a compilation warning with older gccNick Mathewson2013-09-23
| | | |
* | | | Relays should send timestamp in NETINFO.Nick Mathewson2013-09-21
| | | | | | | | | | | | | | | | | | | | | | | | This avoids skew warnings as authorities test reachability. Fix 9798; fix not on any released Tor.
* | | | back out most of 1d0ba9aRoger Dingledine2013-09-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this was causing directory authorities to send a time of 0 on all connections they generated themselves, which means everybody reachability test caused a time skew warning in the log for that relay. (i didn't just revert, because the changes file has been modified by other later commits.)
* | | | Round down hidden service descriptor publication times to nearest hourNick Mathewson2013-09-20
| | | | | | | | | | | | | | | | | | | | Implements part of proposal 222. We can do this safely, since REND_CACHE_MAX_SKEW is 24 hours.
* | | | Remove the timestamp from AUTHENTICATE cells; replace with random bytesNick Mathewson2013-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This isn't actually much of an issue, since only relays send AUTHENTICATE cells, but while we're removing timestamps, we might as well do this too. Part of proposal 222. I didn't take the approach in the proposal of using a time-based HMAC, since that was a bad-prng-mitigation hack from SSL3, and in real life, if you don't have a good RNG, you're hopeless as a Tor server.
* | | | Get ready to stop sending timestamps in INTRODUCE cellsNick Mathewson2013-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For now, round down to the nearest 10 minutes. Later, eliminate entirely by setting a consensus parameter. (This rounding is safe because, in 0.2.2, where the timestamp mattered, REND_REPLAY_TIME_INTERVAL was a nice generous 60 minutes.)
* | | | Stop sending the current time in client NETINFO handshakes.Nick Mathewson2013-09-20
| |_|/ |/| | | | | | | | Implements part of proposal 222.
* | | collect and log statistics about onionskins received/processedRoger Dingledine2013-09-05
| | | | | | | | | | | | | | | | | | | | | we skip onionskins that came from non-relays, so we're less likely to run into privacy troubles. starts to implement ticket 9658.
* | | Revert e443beff and solve it a different wayRoger Dingledine2013-09-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | Now we explicitly check for overflow. This approach seemed smarter than a cascade of "change int to unsigned int and hope nothing breaks right before the release". Nick, feel free to fix in a better way, maybe in master.
* | | don't let recently_chosen_ntors overflowRoger Dingledine2013-09-05
| | | | | | | | | | | | | | | | | | with commit c6f1668d we let it grow arbitrarily large. it can still overflow, but the damage is very small now.
* | | nickm wants us to prioritize tap in a currently-rare edge caseRoger Dingledine2013-09-04
| | |
* | | Be more general in calculating expected onion queue processing timeRoger Dingledine2013-09-04
| | | | | | | | | | | | | | | Now we consider the TAP cells we'll process while draining the NTor queue, and vice versa.
* | | let the NumNTorsPerTAP consensus param override our queue choiceRoger Dingledine2013-09-04
| | |
* | | do a lopsided round-robin between the onion queuesRoger Dingledine2013-09-04
| | | | | | | | | | | | | | | that way tap won't starve entirely, but we'll still handle ntor requests quicker.
* | | check bounds on handshake_type more thoroughlyRoger Dingledine2013-09-04
| | |
* | | add info-level logs to help track onion queue sizesRoger Dingledine2013-09-04
| | |
* | | refactor and give it unit testsRoger Dingledine2013-09-04
| | |
* | | Separate cpuworker queues by handshake typeRoger Dingledine2013-09-04
| | | | | | | | | | | | | | | | | | Now we prioritize ntor create cells over tap create cells. Starts to address ticket 9574.
* | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-09-04
|\ \ \ | |/ / |/| / | |/ | | Conflicts: src/or/circuitbuild.c
| * use !cbt_disabled in place of LearnCBT to avoid needless circsNick Mathewson2013-09-04
| | | | | | | | | | | | | | | | | | | | This would make us do testing circuits "even when cbt is disabled by consensus, or when we're a directory authority, or when we've failed to write cbt history to our state file lately." (Roger's words.) This is a fix for 9671 and an improvement in our fix for 5049. The original misbehavior was in 0.2.2.14-alpha; the incomplete fix was in 0.2.3.17-beta.
| * Merge remote-tracking branch 'public/bug9546_023_v2' into maint-0.2.3Nick Mathewson2013-08-25
| |\
| | * Make bridges send AUTH_CHALLENGE cellsNick Mathewson2013-08-21
| | | | | | | | | | | | | | | | | | | | | | | | The spec requires them to do so, and not doing so creates a situation where they can't send-test because relays won't extend to them because of the other part of bug 9546. Fixes bug 9546; bugfix on 0.2.3.6-alpha.
| | * Send NETINFO on receiving a NETINFO if we have not yet sent one.Nick Mathewson2013-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (Backport to Tor 0.2.3) Relays previously, when initiating a connection, would only send a NETINFO after sending an AUTHENTICATE. But bridges, when receiving a connection, would never send AUTH_CHALLENGE. So relays wouldn't AUTHENTICATE, and wouldn't NETINFO, and then bridges would be surprised to be receiving CREATE cells on a non-open circuit. Fixes bug 9546.
* | | Merge remote-tracking branch 'public/bug9546_v2' into maint-0.2.4Nick Mathewson2013-08-25
|\ \ \
| * | | Make bridges send AUTH_CHALLENGE cellsNick Mathewson2013-08-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec requires them to do so, and not doing so creates a situation where they can't send-test because relays won't extend to them because of the other part of bug 9546. Fixes bug 9546; bugfix on 0.2.3.6-alpha.
| * | | Send NETINFO on receiving a NETINFO if we have not yet sent one.Nick Mathewson2013-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relays previously, when initiating a connection, would only send a NETINFO after sending an AUTHENTICATE. But bridges, when receiving a connection, would never send AUTH_CHALLENGE. So relays wouldn't AUTHENTICATE, and wouldn't NETINFO, and then bridges would be surprised to be receiving CREATE cells on a non-open circuit. Fixes bug 9546.
* | | | Merge remote-tracking branch 'public/bug9366' into maint-0.2.4Nick Mathewson2013-08-25
|\ \ \ \
| * | | | Don't allow all ORPort values to be NoAdvertiseNick Mathewson2013-08-05
| | | | | | | | | | | | | | | | | | | | Fix for bug #9366
* | | | | Merge remote-tracking branch 'public/bug9543' into maint-0.2.4Nick Mathewson2013-08-25
|\ \ \ \ \