| Commit message (Expand) | Author | Age |
|---|
| * | Rename routerstatus_t.is_running to is_flagged_running•••This was the only flag in routerstatus_t that we would previously
change in a routerstatus_t in a consensus. We no longer have reason
to do so -- and probably never did -- as you can now confirm more
easily than you could have done by grepping for is_running before
this patch.
The name change is to emphasize that the routerstatus_t is_running
flag is only there to tell you whether the consensus says it's
running, not whether it *you* think it's running.
| Nick Mathewson | 2010-10-01 |
| * | Initial conversion to use node_t throughout our codebase.•••A node_t is an abstraction over routerstatus_t, routerinfo_t, and
microdesc_t. It should try to present a consistent interface to all
of them. There should be a node_t for a server whenever there is
* A routerinfo_t for it in the routerlist
* A routerstatus_t in the current_consensus.
(note that a microdesc_t alone isn't enough to make a node_t exist,
since microdescriptors aren't usable on their own.)
There are three ways to get a node_t right now: looking it up by ID,
looking it up by nickname, and iterating over the whole list of
microdescriptors.
All (or nearly all) functions that are supposed to return "a router"
-- especially those used in building connections and circuits --
should return a node_t, not a routerinfo_t or a routerstatus_t.
A node_t should hold all the *mutable* flags about a node. This
patch moves the is_foo flags from routerinfo_t into node_t. The
flags in routerstatus_t remain, but they get set from the consensus
and should not change.
Some other highlights of this patch are:
* Looking up routerinfo and routerstatus by nickname is now
unified and based on the "look up a node by nickname" function.
This tries to look only at the values from current consensus,
and not get confused by the routerinfo_t->is_named flag, which
could get set for other weird reasons. This changes the
behavior of how authorities (when acting as clients) deal with
nodes that have been listed by nickname.
* I tried not to artificially increase the size of the diff here
by moving functions around. As a result, some functions that
now operate on nodes are now in the wrong file -- they should
get moved to nodelist.c once this refactoring settles down.
This moving should happen as part of a patch that moves
functions AND NOTHING ELSE.
* Some old code is now left around inside #if 0/1 blocks, and
should get removed once I've verified that I don't want it
sitting around to see how we used to do things.
There are still some unimplemented functions: these are flagged
with "UNIMPLEMENTED_NODELIST()." I'll work on filling in the
implementation here, piece by piece.
I wish this patch could have been smaller, but there did not seem to
be any piece of it that was independent from the rest. Moving flags
forces many functions that once returned routerinfo_t * to return
node_t *, which forces their friends to change, and so on.
| Nick Mathewson | 2010-10-01 |
| * | Try to make most routerstatus_t interfaces const | Nick Mathewson | 2010-10-01 |
| * | Try to make most routerinfo_t interfaces const | Nick Mathewson | 2010-10-01 |
| * | Implement a basic node and nodelist type•••The node_t type is meant to serve two key functions:
1) Abstracting difference between routerinfo_t and microdesc_t
so that clients can use microdesc_t instead of routerinfo_t.
2) Being a central place to hold mutable state about nodes
formerly held in routerstatus_t and routerinfo_t.
This patch implements a nodelist type that holds a node for every
router that we would consider using.
| Nick Mathewson | 2010-10-01 |
| * | Merge branch 'maint-0.2.2' | Roger Dingledine | 2010-10-01 |
| |\ |
|
| | * | fix comment | Roger Dingledine | 2010-10-01 |
| | * | log when we guess our ip address, not just when we fail | Roger Dingledine | 2010-10-01 |
| * | | Merge branch 'tor-fw-squashed2'•••Conflicts:
src/common/util.c
| Nick Mathewson | 2010-09-30 |
| |\ \ |
|
| | * | | Start tor-fw-helper in the background, and log whatever it outputs | Steven Murdoch | 2010-09-30 |
| * | | | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2010-09-30 |
| |\ \ \
| |/ /
|/| /
| |/ |
|
| | * | Note an XXX about potential overflow | Sebastian Hahn | 2010-09-30 |
| | * | Use an upper and lower bound for bridge weights•••When picking bridges (or other nodes without a consensus entry (and
thus no bandwidth weights)) we shouldn't just trust the node's
descriptor. So far we believed anything between 0 and 10MB/s, where 0
would mean that a node doesn't get any use from use unless it is our
only one, and 10MB/s would be a quite siginficant weight. To make this
situation better, we now believe weights in the range from 20kB/s to
100kB/s. This should allow new bridges to get use more quickly, and
means that it will be harder for bridges to see almost all our traffic.
| Sebastian Hahn | 2010-09-30 |
| * | | Whitespace fixes on recent merges to master. | Nick Mathewson | 2010-09-30 |
| * | | Merge branch 'maint-0.2.2' | Roger Dingledine | 2010-09-30 |
| |\| |
|
| | * | Merge commit 'mikeperry/bug1772' into maint-0.2.2 | Roger Dingledine | 2010-09-30 |
| | |\ |
|
| | | * | Nominaly lower the minimum timeout value to 1500.•••This won't change any behavior, since it will still be rounded back
up to 2seconds, but should reduce the chances of some extra warns.
| Mike Perry | 2010-09-29 |
| | * | | Merge branch 'bug1772' into maint-0.2.2 | Roger Dingledine | 2010-09-29 |
| | |\ \ |
|
| | | * | | fix two casts | Roger Dingledine | 2010-09-29 |
| | | |/ |
|
| | | * | Comment network liveness and change detection behavior. | Mike Perry | 2010-09-29 |
| | | * | no measurement circs if not enough build times•••In the first 100 circuits, our timeout_ms and close_ms
are the same. So we shouldn't transition circuits to purpose
CIRCUIT_PURPOSE_C_MEASURE_TIMEOUT, since they will just timeout again
next time we check.
| Roger Dingledine | 2010-09-29 |
| | | * | refactor and recomment; no actual changes | Roger Dingledine | 2010-09-29 |
| | | * | Cap the circuit build timeout to the max time we've seen.•••Also, cap the measurement timeout to 2X the max we've seen.
| Mike Perry | 2010-09-29 |
| | | * | Do away with the complexity of the network liveness detection.•••We really should ignore any timeouts that have *no* network activity for their
entire measured lifetime, now that we have the 95th percentile measurement
changes. Usually this is up to a minute, even on fast connections.
| Mike Perry | 2010-09-29 |
| | | * | Fix state checks on liveness handling.•••If we really want all this complexity for these stages here, we need to handle
it better for people with large timeouts. It should probably go away, though.
| Mike Perry | 2010-09-29 |
| | | * | Fix non-live condition checks.•••Rechecking the timeout condition was foolish, because it is checked on the
same codepath. It was also wrong, because we didn't round.
Also, the liveness check itself should be <, and not <=, because we only have
1 second resolution.
| Mike Perry | 2010-09-29 |
| * | | | Merge branch 'maint-0.2.2' | Roger Dingledine | 2010-09-29 |
| |\| | |
|
| | * | | Merge commit 'mikeperry/bug1739' into maint-0.2.2 | Roger Dingledine | 2010-09-29 |
| | |\| |
|
| | | * | Send control port events for timeouts.•••We now differentiate between timeouts and cutoffs by the REASON string and
the PURPOSE string.
| Mike Perry | 2010-09-29 |
| | * | | Merge commit 'mikeperry/bug1740' into maint-0.2.2 | Roger Dingledine | 2010-09-29 |
| | |\| |
|
| | | * | Only count timeout data for 3 hop circuits.•••Use 4/3 of this timeout value for 4 hop circuits, and use half of it for
canabalized circuits.
| Mike Perry | 2010-09-29 |
| * | | | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2010-09-29 |
| |\| | |
|
| | * | | even more comment | Roger Dingledine | 2010-09-28 |
| | * | | improve code comments, based on comments from nick | Roger Dingledine | 2010-09-28 |
| | * | | handle ugly edge case in retrying entrynodes•••Specifically, a circ attempt that we'd launched while the network was
down could timeout after we've marked our entrynodes up, marking them
back down again. The fix is to annotate as bad the OR conns that were
around before we did the retry, so if a circuit that's attached to them
times out we don't do anything about it.
| Roger Dingledine | 2010-09-28 |
| | * | | Actually notice when our last entrynode goes down•••Otherwise we'd never set have_minimum_dir_info to false, so the
"optimistic retry" would never trigger.
| Roger Dingledine | 2010-09-28 |
| | * | | optimistically retry EntryNodes on socks request•••We used to mark all our known bridges up when they're all down and we
get a new socks request. Now do that when we've set EntryNodes too.
| Roger Dingledine | 2010-09-28 |
| | * | | remove a redundant assert | Roger Dingledine | 2010-09-28 |
| | * | | refactor; no actual changes | Roger Dingledine | 2010-09-28 |
| * | | | Remove the has_old_dnsworkers flag. | Nick Mathewson | 2010-09-28 |
| * | | | Merge branch 'maint-0.2.2' | Roger Dingledine | 2010-09-28 |
| |\| | |
|
| | * | | Merge branch 'maint-0.2.1' into maint-0.2.2 | Roger Dingledine | 2010-09-28 |
| | |\ \ |
|
| | | * | | actually retry bridges when your network goes away | Roger Dingledine | 2010-09-28 |
| * | | | | Autodetect the number of CPUs when possible if NumCPUs==0•••This is needed for IOCP, since telling the IOCP backend about all
your CPUs is a good idea. It'll also come in handy with asn's
multithreaded crypto stuff, and for people who run servers without
reading the manual.
| Nick Mathewson | 2010-09-28 |
| * | | | | Add a new option to enable/disable IOCP support | Nick Mathewson | 2010-09-28 |
| * | | | | Merge branch 'microdesc_dl_v2' | Nick Mathewson | 2010-09-28 |
| |\ \ \ \ |
|
| | * | | | | Clean long-unlisted microdescs from the cache | Nick Mathewson | 2010-09-27 |
| | * | | | | Download microdescriptors if you're a cache•••This commit adds some functions to see what microdescriptors we're missing,
and adds fetch-microdesc/store-microdesc logic to the directory code.
| Nick Mathewson | 2010-09-27 |
| | * | | | | When updating routerdesc downloads, look specifically at the ns consensus•••This will be needed when "get_live_consensus" potentially returns a
microdesc consensus.
| Nick Mathewson | 2010-09-27 |
| | * | | | | Actually parse the m lines from a microdesc consensus | Nick Mathewson | 2010-09-27 |