| Commit message (Expand) | Author | Age |
... | |
| * | | | | Raise the part of torrc mapaddress handling that knows wildcards•••This patch extracts the inner part of config_register_addressmaps --
the part that knows about detecting wildcard addresses addresses --
and makes it into a new function. The new function is deliberately
not moved or reindented, so that the diff is smaller.
I need this to fix bug 6244.
| Nick Mathewson | 2012-08-15 |
* | | | | | Merge remote-tracking branch 'public/bug6507' into maint-0.2.3 | Nick Mathewson | 2012-08-17 |
|\ \ \ \ \ |
|
| * | | | | | Reject attempts to say FooPort and FooPort 0 in the same cfg domain | Nick Mathewson | 2012-08-09 |
| * | | | | | Fix spaces from last patch | Nick Mathewson | 2012-08-09 |
| * | | | | | Don't infer we have a FooPort from the presence of a FooPort line•••Thanks to the changes we started making with SocksPort and friends
in 0.2.3.3-alpha, any of our code that did "if (options->Sockport)"
became wrong, since "SocksPort 0" would make that test true whereas
using the default SocksPort value would make it false. (We didn't
actually do "if (options->SockPort)" but we did have tests for
TransPort. When we moved DirPort, ORPort, and ControlPort over to
the same system in 0.2.3.9-alpha, the problem got worse, since our
code is littered with checks for DirPort and ORPort as booleans.
This code renames the current linelist-based FooPort options to
FooPort_lines, and adds new FooPort_set options which get set at
parse-and-validate time on the or_options_t. FooPort_set is true
iff we will actually try to open a listener of the given type. (I
renamed the FooPort options rather than leave them alone so that
every previous user of a FooPort would need to get inspected, and so
that any new code that forgetfully uses FooPort will need fail to
compile.)
Fix for bug 6507.
| Nick Mathewson | 2012-08-09 |
| |/ / / / |
|
* | | | | | Whitespace and build fixes on 6475 patch | Nick Mathewson | 2012-08-17 |
* | | | | | Merge remote-tracking branch 'mikeperry/bug6475' into maint-0.2.3 | Nick Mathewson | 2012-08-17 |
|\ \ \ \ \ |
|
| * | | | | | Address Nick's comments from code review.•••Also promote log messages to notice and rate-limit them.
| Mike Perry | 2012-08-16 |
| * | | | | | Bug 6475: Explicitly track our path bias state.•••This is done to avoid spurious warns. Additional log lines are also
added to try to track down the codepaths where we are somehow overcounting
success counts.
| Mike Perry | 2012-08-15 |
| |/ / / / |
|
* | | | | | Merge remote-tracking branch 'public/bug6514' into maint-0.2.3 | Nick Mathewson | 2012-08-17 |
|\ \ \ \ \
| |/ / / /
|/| | | | |
|
| * | | | | Defensive programming: clear rs_out between iterations.•••I can't currently find a bug here, but there are a couple of
near-misses. Addresses ticket 6514; reported pseudonymously on
IRC.
| Nick Mathewson | 2012-08-01 |
* | | | | | Merge remote-tracking branch 'public/bug6252_again' into maint-0.2.3 | Nick Mathewson | 2012-08-09 |
|\ \ \ \ \ |
|
| * | | | | | Detect bug 6252 (unexpected sendme cell)•••I only check on circuits, not streams, since bloating your stream
window past the initial circuit window can't help you much.
Also, I compare to CIRCWINDOW_START_MAX so we don't have surprising
races if we lower CIRCWINDOW_START for an experiment.
| Roger Dingledine | 2012-07-18 |
| | |_|_|/
| |/| | | |
|
* | | | | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3•••Conflicts:
src/or/routerlist.c
| Nick Mathewson | 2012-08-03 |
|\ \ \ \ \
| | |_|_|/
| |/| | | |
|
| * | | | | Mitigate a side-channel leak of which relays Tor chooses for a circuit•••Tor's and OpenSSL's current design guarantee that there are other leaks,
but this one is likely to be more easily exploitable, and is easy to fix.
| Robert Ransom | 2012-08-03 |
* | | | | | Remove bogus comment claiming that an assertion is triggerable by consensus | Robert Ransom | 2012-08-03 |
* | | | | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3 | Nick Mathewson | 2012-08-03 |
|\| | | |
| |_|/ /
|/| | | |
|
| * | | | Avoid possible segfault when handling networkstatus vote with bad flavor•••Fix for 6530; fix on 0.2.2.6-alpha.
| Nick Mathewson | 2012-08-03 |
* | | | | Avoid hard (impossible?)-to-trigger double-free in dns_resolve()•••Fixes 6480; fix on 0.2.0.1-alpha; based on pseudonymous patch.
| Nick Mathewson | 2012-07-31 |
| |_|/
|/| | |
|
* | | | Merge branch 'bug6490_v2' into maint-0.2.3 | Nick Mathewson | 2012-07-31 |
|\ \ \ |
|
| * | | | Warn when accounting is used in a way likely to link hidden services•••Fix for 6490.
| Nick Mathewson | 2012-07-31 |
* | | | | trivial grammar fix | Roger Dingledine | 2012-07-31 |
|/ / / |
|
* | | | Merge remote-tracking branch 'asn/bug6274_take3' into maint-0.2.3 | Nick Mathewson | 2012-07-23 |
|\ \ \
| |_|/
|/| | |
|
| * | | Better handling of server managed proxies when Tor is not a relay. | George Kadianakis | 2012-07-18 |
* | | | Merge branch 'smartlist_shorten' into maint-0.2.3 | Nick Mathewson | 2012-07-18 |
|\ \ \ |
|
| * | | | Fix the remaining instances of nexted SMARTLIST_FOREACH | Nick Mathewson | 2012-07-17 |
| * | | | Change all SMARTLIST_FOREACH loops of >=10 lines to use BEGIN/END•••The SMARTLIST_FOREACH macro is more convenient than BEGIN/END when
you have a nice short loop body, but using it for long bodies makes
your preprocessor tell the compiler that all the code is on the same
line. That causes grief, since compiler warnings and debugger lines
will all refer to that one line.
So, here's a new style rule: SMARTLIST_FOREACH blocks need to be
short.
| Nick Mathewson | 2012-07-17 |
* | | | | Improve message on spurious SOCKSListenAddress | Nick Mathewson | 2012-07-17 |
|/ / / |
|
* | | | Allow TestingTorNetwork when alternate dir and bridge authorities are set.•••Allow TestingTorNetwork when AlternateDirAuthority and
AlternateBridgeAuthority is set even if DirServer is not.
| Linus Nordberg | 2012-07-17 |
* | | | Refer to the correct variable in a loop when parsing entry guard state•••Fixes bug 6397 and coverity issue 709599. Bugfix on 0.2.3.17-beta.
| Nick Mathewson | 2012-07-16 |
|/ / |
|
* | | Merge remote-tracking branch 'nickm/bug6271_part_a' into maint-0.2.3 | Roger Dingledine | 2012-07-06 |
|\ \ |
|
| * | | Fix a bug handling SENDME cells on nonexistent streams.•••This could result in bizarre window values. Report and patch
contributed pseudymously. Fixes part of bug 6271. This bug was
introduced before the first Tor release, in svn commit r152.
(bug 6271, part a.)
| Nick Mathewson | 2012-07-06 |
| |/ |
|
* | | On windows, ENOBUFS starts with WSA. #6296. Fix on 0.2.18-rc | Nick Mathewson | 2012-07-05 |
* | | Revert "Detect bug 6252 (unexpected sendme cell)"•••This reverts commit c32ec9c425e9539bcc8ede95612e2d331c2cc2dd.
It turns out the two sides of the circuit don't actually stay in sync,
so it is perfectly normal for the circuit window on the exit relay to
grow to 2000+. We should fix that bug and then reconsider this patch.
| Roger Dingledine | 2012-07-01 |
* | | Detect bug 6252 (unexpected sendme cell)•••I only check on circuits, not streams, since bloating your stream
window past the initial circuit window can't help you much.
Also, I compare to CIRCWINDOW_START_MAX so we don't have surprising
races if we lower CIRCWINDOW_START for an experiment.
| Roger Dingledine | 2012-07-01 |
* | | fix grammar in comment | Roger Dingledine | 2012-06-28 |
* | | Merge remote-tracking branch 'public/bug6244_part2' into maint-0.2.3 | Nick Mathewson | 2012-06-28 |
|\ \ |
|
| * | | Fix GETINFO address-mappings/... with wildcarded addresses. | Nick Mathewson | 2012-06-27 |
* | | | Downgrade 'Got a certificate, but we already have it' log message from warnin... | Andrea Shepard | 2012-06-28 |
|/ / |
|
* | | Allow wildcarded mapaddress targets in controller MAPADDRESS command | Nick Mathewson | 2012-06-27 |
* | | Downgrade message about md cache cleaning from notice to info•••Fix for #6238
| Nick Mathewson | 2012-06-26 |
* | | Don't do DNS lookups when parsing corrupted managed proxy messages.•••The functions parse_{s,c}method_line() were using
tor_addr_port_lookup() which is capable of doing DNS lookups. DNS
lookups should not be necessary when parsing {C,S}METHOD lines.
| George Kadianakis | 2012-06-25 |
* | | Catch a few more K&R violations with make check-spaces•••We now catch bare {s that should be on the previous line with a do,
while, if, or for, and elses that should share a line with their
preceding }.
That is,
if (foo)
{
and
if (foo) {
...
}
else
are now detected.
We should think about maybe making Tor uncrustify-clean some day,
but configuring uncrustify is an exercise in bizarreness, and
reformatting huge gobs of Tor is always painful.
| Nick Mathewson | 2012-06-23 |
* | | Improve log message issued when a managed proxy fails to launch. | George Kadianakis | 2012-06-23 |
* | | Merge remote-tracking branch 'public/bug6211' into maint-0.2.3 | Nick Mathewson | 2012-06-22 |
|\ \ |
|
| * | | Fix a regression bug in AllowDotExit•••The code that detected the source of a remapped address checked that
an address mapping's source was a given rewrite rule if addr_orig had
no .exit, and addr did have a .exit after processing that rule. But
addr_orig was formatted for logging: it was not the original address
at all, but rather was the address escaped for logging and possibly
replaced with "[scrubbed]".
This new logic will correctly set ADDRMAPSRC_NONE in the case when the
address starts life as a .exit address, so that AllowDotExit can work
again.
Fixes bug 6211; bugfix on 0.2.3.17-beta
| Nick Mathewson | 2012-06-19 |
* | | | Disable warning for marked-but-reading in main.c•••It turns out this can happen. Even though there is no reason for
connections to be marked but reading, we leave them reading anyway,
so warning here is unwarranted. Let's turn that back on once we do
something sensible and disable reading when we mark. Bugfix for
6203 on Tor 0.2.3.17-beta.
Thanks to cypherpunks for pointing out the general stupidity of the
original code here.
| Nick Mathewson | 2012-06-19 |
|/ / |
|
* | | Merge remote-tracking branch 'public/bug3311' | Nick Mathewson | 2012-06-18 |
|\ \ |
|
| * | | Clarify some messages about publishing hidden service descriptors•••Fix for bug 3311.
| Nick Mathewson | 2012-06-15 |
* | | | Merge remote-tracking branch 'andrea/bug6028' | Nick Mathewson | 2012-06-18 |
|\ \ \ |
|