| Commit message (Expand) | Author | Age |
|---|
| * | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-06-14 |
| |\ |
|
| | * | Make ControlSocketsGroupWritable work with User.•••Original message from bug3393:
check_private_dir() to ensure that ControlSocketsGroupWritable is
safe to use. Unfortunately, check_private_dir() only checks against
the currently running user… which can be root until privileges are
dropped to the user and group configured by the User config option.
The attached patch fixes the issue by adding a new effective_user
argument to check_private_dir() and updating the callers. It might
not be the best way to fix the issue, but it did in my tests.
(Code by lunar; changelog by nickm)
| Jérémy Bobbio | 2011-06-14 |
| | * | Fix a rare memleak during stats writing•••If rep_hist_buffer_stats_write() was called unitinitalized, we'd leak
memory.
| Sebastian Hahn | 2011-06-08 |
| | * | remove some dead code, found by coverity | Sebastian Hahn | 2011-06-08 |
| * | | Merge remote-tracking branch 'origin/maint-0.2.2'•••The conflicts were mainly caused by the routerinfo->node transition.
Conflicts:
src/or/circuitbuild.c
src/or/command.c
src/or/connection_edge.c
src/or/directory.c
src/or/dirserv.c
src/or/relay.c
src/or/rendservice.c
src/or/routerlist.c
| Nick Mathewson | 2011-05-30 |
| |\| |
|
| | * | Log descriptions of nodes, not just nicknames.•••This patch introduces a few new functions in router.c to produce a
more helpful description of a node than its nickame, and then tweaks
nearly all log messages taking a nickname as an argument to call these
functions instead.
There are a few cases where I left the old log messages alone: in
these cases, the nickname was that of an authority (whose nicknames
are useful and unique), or the message already included an identity
and/or an address. I might have missed a couple more too.
This is a fix for bug 3045.
| Nick Mathewson | 2011-05-15 |
| * | | Merge remote-tracking branch 'public/bug3122_memcmp_022' into bug3122_memcmp_023•••Conflicts in various places, mainly node-related. Resolved them in
favor of HEAD, with copying of tor_mem* operations from bug3122_memcmp_022.
src/common/Makefile.am
src/or/circuitlist.c
src/or/connection_edge.c
src/or/directory.c
src/or/microdesc.c
src/or/networkstatus.c
src/or/router.c
src/or/routerlist.c
src/test/test_util.c
| Nick Mathewson | 2011-05-11 |
| |\| |
|
| | * | Merge remote-tracking branch 'public/3122_memcmp_squashed' into bug3122_memcm...•••Conflicts throughout. All resolved in favor of taking HEAD and
adding tor_mem* or fast_mem* ops as appropriate.
src/common/Makefile.am
src/or/circuitbuild.c
src/or/directory.c
src/or/dirserv.c
src/or/dirvote.c
src/or/networkstatus.c
src/or/rendclient.c
src/or/rendservice.c
src/or/router.c
src/or/routerlist.c
src/or/routerparse.c
src/or/test.c
| Nick Mathewson | 2011-05-11 |
| | |\ |
|
| | | * | Hand-conversion and audit phase of memcmp transition•••Here I looked at the results of the automated conversion and cleaned
them up as follows:
If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I
changed it to a fast_memcmp or fast_memeq.
Otherwise if there was a tor_memcmp that could turn into a
tor_memneq or tor_memeq, I converted it.
This wants close attention.
[*] I'm erring on the side of caution here, and leaving some things
as tor_memcmp that could in my opinion use the data-dependent
fast_memcmp variant.
| Nick Mathewson | 2011-05-11 |
| * | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-04-28 |
| |\| | |
|
| | * | | Merge remote-tracking branch 'sebastian/bug2497' into maint-0.2.2 | Nick Mathewson | 2011-04-28 |
| | |\ \ |
|
| | | * | | Don't report empty bw-history lines in extrainfo•••Some tor relays would report lines like these in their extrainfo
documents:
dirreq-write-history 2011-03-14 16:46:44 (900 s)
This was confusing to some people who look at the stats. It would happen
whenever a relay first starts up, or when a relay has dirport disabled.
Change this so that lines without actual bw entries are omitted.
Implements ticket 2497.
| Sebastian Hahn | 2011-04-19 |
| * | | | | Merge remote-tracking branch 'origin/maint-0.2.2'•••Conflicts:
src/or/rephist.c
| Nick Mathewson | 2011-04-26 |
| |\| | | |
|
| | * | | | fix some comments before they create conflicts | Roger Dingledine | 2011-04-26 |
| * | | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-04-26 |
| |\| | | |
|
| | * | | | Fix compilation in last patch | Nick Mathewson | 2011-04-26 |
| | * | | | Fix more of bug 2704•••The last entry of the *Maxima values in the state file was inflated by a
factor of NUM_SECS_ROLLING_MEASURE (currently 10). This could lead to
a wrong maximum value propagating through the state file history.
| Sebastian Hahn | 2011-04-26 |
| * | | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-04-19 |
| |\| | | |
|
| | * | | | Prevent hugely inflated observed bandwidth values•••When reading the bw history from the state file, we'd add the 900-second
value as traffic that occured during one second. Fix that by adding the
average value to each second.
This bug was present since 0.2.0.5-alpha, but was hidden until
0.2.23-alpha when we started using the saved values.
| Sebastian Hahn | 2011-04-19 |
| | * | | | Don't sometimes undercount bw average•••This fixes the first part of bug 2704. It should occur only rarely when
no bw maxima are known. Bugfix on 0.2.2.23-alpha. Fixes bug 2704.
| Sebastian Hahn | 2011-04-19 |
| | |/ / |
|
| * | | | Merge remote-tracking branch 'origin/maint-0.2.2'•••Conflicts:
src/or/rephist.c
| Nick Mathewson | 2011-04-08 |
| |\| | |
|
| | * | | Free circuits_for_buffer_stats on shutdown | Nick Mathewson | 2011-04-07 |
| | * | | Fix up some cell-queue stats issues in rephist.c•••- Document the structure and variables.
- Make circuits_for_buffer_stats into a static variable.
- Don't die horribly if interval_length is 0.
- Remove the unused local_circ_id field.
- Reorder the fields of circ_buffer_stats_t for cleaner alignment layout.
| Nick Mathewson | 2011-04-07 |
| * | | | Merge remote-tracking branch 'origin/maint-0.2.2'•••Conflicts:
src/common/address.c
src/common/compat_libevent.c
src/common/memarea.c
src/common/util.h
src/or/buffers.c
src/or/circuitbuild.c
src/or/circuituse.c
src/or/connection.c
src/or/directory.c
src/or/networkstatus.c
src/or/or.h
src/or/routerlist.c
| Nick Mathewson | 2011-04-07 |
| |\| | |
|
| | * | | Merge remote-tracking branch 'public/xxx_fixups' into maint-0.2.2•••Conflicts:
src/or/or.h
| Nick Mathewson | 2011-04-07 |
| | |\ \ |
|
| | | * | | Triage the XXX022 and XXX021 comments remaining in the code•••Remove some, postpone others, leave some alone. Now the only
remaining XXX022s are ones that seem important to fix or investigate.
| Nick Mathewson | 2011-03-25 |
| | * | | | Use timevals, not time_t, when expiring circuits.•••We've got millisecond timers now, we might as well use them.
This change won't actually make circuits get expiered with microsecond
precision, since we only call the expiry functions once per second.
Still, it should avoid the situation where we have a circuit get
expired too early because of rounding.
A couple of the expiry functions now call tor_gettimeofday: this
should be cheap since we're only doing it once per second. If it gets
to be called more often, though, we should onsider having the current
time be an argument again.
| Nick Mathewson | 2011-03-30 |
| | |/ / |
|
| * | | | Merge remote-tracking branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-03-16 |
| |\| | |
|
| | * | | Remove a useless doxygen comment | Nick Mathewson | 2011-03-16 |
| * | | | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-03-11 |
| |\| | |
|
| | * | | Clarify threat description and avoid negative uptimes. | Nick Mathewson | 2011-03-11 |
| | * | | Use observed instead of declared uptime for HSDir•••It is important to verify the uptime claim of a relay instead of just
trusting it, otherwise it becomes too easy to blackhole a specific
hidden service. rephist already has data available that we can use here.
Bugfix on 0.2.0.10-alpha.
| Sebastian Hahn | 2011-03-11 |
| * | | | Merge remote branch 'origin/maint-0.2.2'•••Resolved trivial one-line conflicts.
Conflicts:
src/or/dirserv.c
src/or/rephist.c
| Nick Mathewson | 2011-03-08 |
| |\| | |
|
| | * | | Merge remote branch 'sebastian/bug1035' into maint-0.2.2 | Nick Mathewson | 2011-03-08 |
| | |\ \ |
|
| | | * | | clarify an assert•••also log about running changes, even on a bridge authority.
| Sebastian Hahn | 2011-02-26 |
| | | * | | Routers count as down when they change ORPort, too•••rransom noticed that a change of ORPort is just as bad as a change of IP
address from a client's perspective, because both mean that the relay is
not available to them while the new information hasn't propagated.
Change the bug1035 fix accordingly.
Also make sure we don't log a bridge's IP address (which might happen
when we are the bridge authority).
| Sebastian Hahn | 2011-02-08 |
| | | * | | Fix spelling and an unused #define•••both noticed by rransom
| Sebastian Hahn | 2011-02-07 |
| | | * | | Fix compile without warnings on OS X 10.6 | Sebastian Hahn | 2010-12-27 |
| | | * | | Handle negative run lengths in wfu/mtbf calculations | Nick Mathewson | 2010-11-22 |
| | | * | | Treat routers whose IPs have changed as having been down for MTBF/routerinfo•••calculation purposes.
| Nick Mathewson | 2010-11-22 |
| * | | | | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-03-01 |
| |\| | | |
|
| | * | | | Avoid spurious bwhist parsing failures•••This should fix a bug that special ran into, where if your state file
didn't record period maxima, it would never decide that it had
successfully parsed itself unless you got lucky with your
uninitialized-variable values.
This patch also tries to improve error messags in the case where a
maximum value legitimately doesn't parse.
| Nick Mathewson | 2011-03-01 |
| * | | | | Merge remote branch 'origin/maint-0.2.2' | Nick Mathewson | 2011-02-25 |
| |\| | | |
|
| | * | | | Fix two potential bugs in the bug1863 code. | Karsten Loesing | 2011-02-24 |
| | * | | | fix some spelling in rephist comments | Nick Mathewson | 2011-01-10 |
| | * | | | Add Maxima lists to bandwidth state.•••Right now, Tor routers don't save the maxima values from the
bw_history_t between sessions. That's no good, since we use those
values to determine bandwidth. This code adds a new BWHist.*Maximum
set of values to the state file. If they're not present, we estimate
them by taking the observed total bandwidth and dividing it by the
period length, which provides a lower bound.
This should fix bug 1863. I'm calling it a feature.
| Nick Mathewson | 2011-01-10 |
| | * | | | On bwhist state load failure, clear dir_read/write hist too | Nick Mathewson | 2011-01-10 |
| | * | | | Fix bug when parsing bwhist with unexpected Interval•••Previously, our state parsing code would fail to parse a bwhist
correctly if the Interval was anything other than the default
hardcoded 15 minutes. This change makes the parsing less incorrect,
though the resulting history array might get strange values in it if
the intervals don't match the one we're using. (That is, if stuff was
generated in 15 minute intervals, and we read it into an array that
expects 30 minute intervals, we're fine, since values can be combined
pairwise. But if we generate data at 30 minute intervals and read it
into 15 minute intervals, alternating buckets will be empty.)
Bugfix on 0.1.1.11-alpha.
| Nick Mathewson | 2011-01-10 |
| | * | | | Turn the loop bodies of rep_hist_save/load_state into functions•••The trick of looping from i=0..4 , switching on i to set up some
variables, then running some common code is much better expressed by
just calling a function 4 times with 4 sets of arguments. This should
make the code a little easier to follow and maintain here.
| Nick Mathewson | 2011-01-10 |
| * | | | | Add a note about _compare_int not doing overflow right | Nick Mathewson | 2011-01-03 |