aboutsummaryrefslogtreecommitdiff
path: root/src/or/rendservice.c
Commit message (Collapse)AuthorAge
...
| * | Allow intro points to expire somewhat gracefullyRobert Ransom2011-10-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Right Way to expire an intro point is to establish a new one to replace it, publish a new descriptor that doesn't list any expiring intro points, and *then*, once our upload attempts for the new descriptor have ended (whether in success or failure), close the expiring intro points. Unfortunately, we can't find out when the new descriptor has actually been uploaded, so we'll have to settle for a five-minute timer. There should be no significant behaviour changes due to this commit (only a log-message change or two), despite the rather massive overhaul, so this commit doesn't include a changes/ file. (The commit that teaches intro_point_should_expire_now to return non-zero gets a changes/ file, though.)
| * | Use SMARTLIST_FOREACH_BEGIN and _END, not a for loopRobert Ransom2011-10-30
| | |
| * | Correct bogus commentsRobert Ransom2011-10-30
| | | | | | | | | | | | | | | The behaviour of rend_services_introduce here is likely as bogus as the comments were.
| * | Use a more meaningful variable nameRobert Ransom2011-10-30
| | |
| * | Determine whether an intro point was in the last HS desc in a sane wayRobert Ransom2011-10-30
| | |
| * | Record which intro points were listed in the last HS descRobert Ransom2011-10-30
| | |
| * | Record the number of INTRODUCE2 cells each intro point has receivedRobert Ransom2011-10-30
| | |
| * | Correct a log messageRobert Ransom2011-10-30
| | |
| * | Record the time at which each intro point was first publishedRobert Ransom2011-10-30
| | |
| * | Improve a commentRobert Ransom2011-10-30
| | |
| * | Allow different HSes to maintain different numbers of intro pointsRobert Ransom2011-10-30
| | |
* | | Fix a couple of memory leaks in rend_add_service spotted by coverityNick Mathewson2011-11-17
| | |
* | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-11-09
|\ \ \ | | |/ | |/|
| * | Include HiddenServiceDir in some warning messagesRobert Ransom2011-11-07
| | |
* | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-10-20
|\| |
| * | Free rend_data and intro_key when extra intro circs become general-purposeRobert Ransom2011-10-18
| |/
* | Fix names of functions that convert strings to addrsNick Mathewson2011-10-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now let's have "lookup" indicate that there can be a hostname resolution, and "parse" indicate that there wasn't. Previously, we had one "lookup" function that did resolution; four "parse" functions, half of which did resolution; and a "from_str()" function that didn't do resolution. That's confusing and error-prone! The code changes in this commit are exactly the result of this perl script, run under "perl -p -i.bak" : s/tor_addr_port_parse/tor_addr_port_lookup/g; s/parse_addr_port(?=[^_])/addr_port_lookup/g; s/tor_addr_from_str/tor_addr_parse/g; This patch leaves aton and pton alone: their naming convention and behavior is is determined by the sockets API. More renaming may be needed.
* | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-09-11
|\|
| * Demote 'INTRODUCE2 cell is too {old,new}' message to info levelRobert Ransom2011-09-10
| |
| * Demote HS 'replay detected' log message for DH public keys to info levelRobert Ransom2011-09-10
| |
* | Merge remote-tracking branch 'rransom-tor/typo-fix-ohkah8Ah'Nick Mathewson2011-09-10
|\|
| * Fix log message typo.Robert Ransom2011-09-10
| |
* | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-09-09
|\| | | | | | | | | | | Conflicts: configure.in src/or/circuitbuild.c
| * Merge remote-tracking branch 'public/enhance_replay_detection' into maint-0.2.2Nick Mathewson2011-09-09
| |\
| | * Check for replays in PK-encrypted part of intro cell, not just in the g^x valueNick Mathewson2011-09-09
| | |
* | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-07-19
|\| |
| * | Specify text or binary mode in every start_writing_to_stdio_file callRobert Ransom2011-07-19
| | |
* | | Fix bug in upload/download of hsdesc with microdescsNick Mathewson2011-07-15
| | | | | | | | | | | | | | | | | | | | | | | | Previously we were using router_get_by_id(foo) to test "do we have a descriptor that will let us make an anonymous circuit to foo". But that isn't right for microdescs: we should have been using node_t. Fixes bug 3601; bugfix on 0.2.3.1-alpha.
* | | Kill redundant checks around routerset_contains_*()Nick Mathewson2011-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All of the routerset_contains*() functions return 0 if their routerset_t argument is NULL. Therefore, there's no point in doing "if (ExcludeNodes && routerset_contains*(ExcludeNodes...))", for example. This patch fixes every instance of if (X && routerstatus_contains*(X,...)) Note that there are other patterns that _aren't_ redundant. For example, we *don't* want to change: if (EntryNodes && !routerstatus_contains(EntryNodes,...)) Fixes #2797. No bug here; just needless code.
* | | Merge remote-tracking branch 'rransom-tor/bug3332-v2'Nick Mathewson2011-06-15
|\ \ \
| * | | Assert that HS operations are not performed using single-hop circuitsRobert Ransom2011-06-14
| | | | | | | | | | | | | | | | (with fixes by Nick Mathewson to unbreak the build)
* | | | Make the get_options() return constNick Mathewson2011-06-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us make a lot of other stuff const, allows the compiler to generate (slightly) better code, and will make me get slightly fewer patches from folks who stick mutable stuff into or_options_t. const: because not every input is an output!
* | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-06-14
|\ \ \ \ | |/ / / |/| / / | |/ /
| * | Make ControlSocketsGroupWritable work with User.Jérémy Bobbio2011-06-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original message from bug3393: check_private_dir() to ensure that ControlSocketsGroupWritable is safe to use. Unfortunately, check_private_dir() only checks against the currently running user… which can be root until privileges are dropped to the user and group configured by the User config option. The attached patch fixes the issue by adding a new effective_user argument to check_private_dir() and updating the callers. It might not be the best way to fix the issue, but it did in my tests. (Code by lunar; changelog by nickm)
* | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-05-30
|\| |
| * | Warn when two hs use the same directorySebastian Hahn2011-05-30
| | | | | | | | | | | | | | | This simple implementation has a few issues, but it should do for 0.2.2.x. We will want to revisit this later and make it smarter.
* | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-05-30
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The conflicts were mainly caused by the routerinfo->node transition. Conflicts: src/or/circuitbuild.c src/or/command.c src/or/connection_edge.c src/or/directory.c src/or/dirserv.c src/or/relay.c src/or/rendservice.c src/or/routerlist.c
| * | Log descriptions of nodes, not just nicknames.Nick Mathewson2011-05-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch introduces a few new functions in router.c to produce a more helpful description of a node than its nickame, and then tweaks nearly all log messages taking a nickname as an argument to call these functions instead. There are a few cases where I left the old log messages alone: in these cases, the nickname was that of an authority (whose nicknames are useful and unique), or the message already included an identity and/or an address. I might have missed a couple more too. This is a fix for bug 3045.
* | | Merge remote-tracking branch 'public/bug3122_memcmp_022' into bug3122_memcmp_023Nick Mathewson2011-05-11
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts in various places, mainly node-related. Resolved them in favor of HEAD, with copying of tor_mem* operations from bug3122_memcmp_022. src/common/Makefile.am src/or/circuitlist.c src/or/connection_edge.c src/or/directory.c src/or/microdesc.c src/or/networkstatus.c src/or/router.c src/or/routerlist.c src/test/test_util.c
| * | Merge remote-tracking branch 'public/3122_memcmp_squashed' into ↵Nick Mathewson2011-05-11
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bug3122_memcmp_022 Conflicts throughout. All resolved in favor of taking HEAD and adding tor_mem* or fast_mem* ops as appropriate. src/common/Makefile.am src/or/circuitbuild.c src/or/directory.c src/or/dirserv.c src/or/dirvote.c src/or/networkstatus.c src/or/rendclient.c src/or/rendservice.c src/or/router.c src/or/routerlist.c src/or/routerparse.c src/or/test.c
| | * Hand-conversion and audit phase of memcmp transitionNick Mathewson2011-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here I looked at the results of the automated conversion and cleaned them up as follows: If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I changed it to a fast_memcmp or fast_memeq. Otherwise if there was a tor_memcmp that could turn into a tor_memneq or tor_memeq, I converted it. This wants close attention. [*] I'm erring on the side of caution here, and leaving some things as tor_memcmp that could in my opinion use the data-dependent fast_memcmp variant.
| | * Automated conversion of memcmp to tor_memcmp/tor_mem[n]eqNick Mathewson2011-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is _exactly_ the result of perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch] perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch] git checkout src/common/di_ops.[ch] git checkout src/or/test.c git checkout src/common/test.h
| | * Make the DH parameter we use for TLS match the one from Apache's mod_sslNick Mathewson2011-02-10
| | | | | | | | | | | | | | | | | | | | | | | | Our regular DH parameters that we use for circuit and rendezvous crypto are unchanged. This is yet another small step on the path of protocol fingerprinting resistance. (Backport from 0.2.2's 5ed73e3807d90dd0a3)
* | | Merge maint-0.2.2 for the bug1090-part1-squashed branchNick Mathewson2011-04-27
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved conflicts in: doc/tor.1.txt src/or/circuitbuild.c src/or/circuituse.c src/or/connection_edge.c src/or/connection_edge.h src/or/directory.c src/or/rendclient.c src/or/routerlist.c src/or/routerlist.h These were mostly releated to the routerinfo_t->node_t conversion.
| * | Check transition of circuit purpose from INTRO->GENERAL if nodes are constrainedNick Mathewson2011-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This looked at first like another fun way around our node selection logic: if we had introduction circuits, and we wound up building too many, we would turn extras into general-purpose circuits. But when we did so, we wouldn't necessarily check whether the general-purpose circuits conformed to our node constraints. For example, the last node could totally be in ExcludedExitNodes and we wouldn't have cared... ...except that the circuit should already be internal, so it won't get user streams attached to it, so the transition should generally be allowed. Add an assert to make sure we're right about this, and have it not check whether ExitNodes is set, since that's irrelevant to internal circuits.
| * | Note that circuit purpose changing can violate ExcludeNodesNick Mathewson2011-04-26
| | |
| * | refuse excluded hidserv nodes if strictnodesRoger Dingledine2011-04-26
| | | | | | | | | | | | | | | Make hidden services more flaky for people who set both ExcludeNodes and StrictNodes. Not recommended, especially for hidden service operators.
* | | Merge remote branch 'origin/maint-0.2.2'Nick Mathewson2011-01-24
|\| |
| * | Make the DH parameter we use for TLS match the one from Apache's mod_sslNick Mathewson2011-01-24
| | | | | | | | | | | | | | | | | | Our regular DH parameters that we use for circuit and rendezvous crypto are unchanged. This is yet another small step on the path of protocol fingerprinting resistance.
* | | Merge remote branch 'origin/maint-0.2.2'Nick Mathewson2011-01-15
|\| |