aboutsummaryrefslogtreecommitdiff
path: root/src/or/relay.c
Commit message (Collapse)AuthorAge
* Add XXX023s for our timestamp_dirty abuse.Nick Mathewson2011-03-25
|
* Move the decl for tor_gettimofday_cache_clear to the right headerNick Mathewson2011-03-16
|
* Fix comment for connection_edge_consider_sending_sendmeNick Mathewson2011-03-15
|
* Sanity-check consensus param valuesSebastian Hahn2011-01-15
| | | | | | | | | | | | | | | We need to make sure that the worst thing that a weird consensus param can do to us is to break our Tor (and only if the other Tors are reliably broken in the same way) so that the majority of directory authorities can't pull any attacks that are worse than the DoS that they can trigger by simply shutting down. One of these worse things was the cbtnummodes parameter, which could lead to heap corruption on some systems if the value was sufficiently large. This commit fixes this particular issue and also introduces sanity checking for all consensus parameters.
* Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson2011-01-03
|\ | | | | | | | | | | Conflicts: src/common/test.h src/or/test.c
| * Bump copyright statements to 2011Nick Mathewson2011-01-03
| |
* | Merge remote branch fix_security_bug_021 into fix_security_bug_022Nick Mathewson2010-12-15
|\| | | | | | | | | | | | | Conflicts: src/common/memarea.c src/or/or.h src/or/rendclient.c
| * Make payloads into uint8_t.Nick Mathewson2010-12-15
| | | | | | | | This will avoid some signed/unsigned assignment-related bugs.
| * Backport END_STREAM_REASON_NOROUTE for client use.Sebastian Hahn2010-08-18
| | | | | | | | (Partial backport of 150ed553dfce9, 161b275028e90, and 4c948ffd6.)
* | Revise comment on 2210 a little; clean up n_streams/num_streams confusionNick Mathewson2010-11-29
| | | | | | | | Also add a changes file
* | Add wrappers function for libc random()Nick Mathewson2010-11-29
| | | | | | | | On windows, it's called something different.
* | Fix whitespace in patch for 2210 and backport to 0.2.2Nick Mathewson2010-11-29
| |
* | Improve fairness when activating streams in circuit_resume_edge_reading_helperMashael AlSabah2010-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reason the "streams problem" occurs is due to the complicated interaction between Tor's congestion control and libevent. At some point during the experiment, the circuit window is exhausted, which blocks all edge streams. When a circuit level sendme is received at Exit, it resumes edge reading by looping over linked list of edge streams, and calling connection_start_reading() to inform libevent to resume reading. When the streams are activated again, Tor gets the chance to service the first three streams activated before the circuit window is exhausted again, which causes all streams to be blocked again. As an experiment, we reversed the order in which the streams are activated, and indeed the first three streams, rather than the last three, got service, while the others starved. Our solution is to change the order in which streams are activated. We choose a random edge connection from the linked list, and then we activate streams starting from that chosen stream. When we reach the end of the list, then we continue from the head of the list until our chosen stream (treating the linked list as a circular linked list). It would probably be better to actually remember which streams have received service recently, but this way is simple and effective.
* | Send relay_early cells in rend circsSebastian Hahn2010-10-18
| | | | | | | | | | There are no relay left that run version 0.2.1.3 through 0.2.1.18, so changing this behaviour should be safe now.
* | I hear we are close to a release. Clean up the whitespace.Nick Mathewson2010-09-16
| |
* | Demote a warn when enabling CellStatisticsSebastian Hahn2010-09-16
| | | | | | | | | | | | | | | | When the CellStatistics option is off, we don't store cell insertion times. Doing so would also not be very smart, because there seem to still be some performance issues with this type of statistics. Nothing harmful happens when we don't have insertion times, so we don't need to alarm the user.
* | Merge branch 'bug1184'Nick Mathewson2010-09-15
|\ \
| * | Never queue a cell on a marked circuitNick Mathewson2010-09-15
| | |
| * | Clear cell queues when marking or truncating a circuit.Nick Mathewson2010-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | At best, this patch helps us avoid sending queued relayed cells that would get ignored during the time between when a destroy cell is sent and when the circuit is finally freed. At worst, it lets us release some memory a little earlier than it would otherwise. Fix for bug #1184. Bugfix on 0.2.0.1-alpha.
* | | Add a simple integer-ceiling-division macro before we get it wrongNick Mathewson2010-09-14
| | |
* | | Make circuit_resume_edge_reading_helper treat streams more fairly.Nick Mathewson2010-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously[*], the function would start with the first stream on the circuit, and let it package as many cells as it wanted before proceeding to the next stream in turn. If a circuit had many live streams that all wanted to package data, the oldest would get preference, and the newest would get ignored. Now, we figure out how many cells we're willing to send per stream, and try to allocate them fairly. Roger diagnosed this in the comments for bug 1298. [*] This bug has existed since before the first-ever public release of Tor. It was added by r152 of Tor on 26 Jan 2003, which was the first commit to implement streams (then called "topics"). This is not the oldest bug to be fixed in 0.2.2.x: that honor goes to the windowing bug in r54, which got fixed in e50b7768 by Roger with diagnosis by Karsten. This is, however, the most long-lived bug to be fixed in 0.2.2.x: the r54 bug was fixed 2580 days after it was introduced, whereas I am writing this commit message 2787 days after r152.
* | | Add a max_cells arg to connection_edge_process_raw_inbufNick Mathewson2010-09-13
| | | | | | | | | | | | | | | | | | | | | I'm going to use this to implement more fairness in circuit_resume_edge_reading_helper in an attempt to fix bug 1298. (Updated with fixes from arma and Sebastian)
* | | Fix function declaration linebreaks at start of relay.cNick Mathewson2010-09-13
| | |
* | | be more consistent in using streamid_tNick Mathewson2010-09-08
| | |
* | | Fix a missing stream_id argument; found by "tracktor"Nick Mathewson2010-09-03
| | |
* | | Fix behavior of adding a cell to a blocked queue.Nick Mathewson2010-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We frequently add cells to stream-blocked queues for valid reasons that don't mean we need to block streams. The most obvious reason is if the cell arrives over a circuit rather than from an edge: we don't block circuits, no matter how full queues get. The next most obvious reason is that we allow CONNECTED cells from a newly created stream to get delivered just fine. This patch changes the behavior so that we only iterate over the streams on a circuit when the cell in question came from a stream, and we only block the stream that generated the cell, so that other streams can still get their CONNECTEDs in.
* | | Detect if we try to put a cell onto a supposedly blocked cell queue.Nick Mathewson2010-08-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When this happens, run through the streams on the circuit and make sure they're all blocked. If some aren't, that's a bug: block them all and log it! If they all are, where did the cell come from? Log it! (I suspect that this actually happens pretty frequently, so I'm making these log messages appear at INFO.)
* | | Decide whether to ignore SENDMEs based on streams_blocked, not queue sizeNick Mathewson2010-08-18
| | |
* | | Avoid over-filling cell queues when we receive a SENDMEyetonetime2010-08-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Do not start reading on exit streams when we get a SENDME unless we have space in the appropriate circuit's cell queue. Draft fix for bug 1653. (commit message by nickm)
* | | 161b2750 didn't really retry the stream. this does.Roger Dingledine2010-08-16
| | |
* | | Merge commit 'sebastian/bug1831'Nick Mathewson2010-08-15
|\ \ \
| * | | Fix misplaced labelsSebastian Hahn2010-08-16
| |/ /
* | | Merge commit 'sebastian/misc-reason'Nick Mathewson2010-08-15
|\ \ \ | |/ / |/| |
| * | Retry streams that ended with NOROUTE errorSebastian Hahn2010-08-04
| |/ | | | | | | Also add the NOROUTE reason to control-spec.
* | Create routerparse.hSebastian Hahn2010-07-27
| |
* | Create relay.hSebastian Hahn2010-07-27
| |
* | Create reasons.hSebastian Hahn2010-07-27
| |
* | Create policies.hSebastian Hahn2010-07-27
| |
* | Create networkstatus.hSebastian Hahn2010-07-27
| |
* | Create main.hSebastian Hahn2010-07-27
| |
* | Create control.hSebastian Hahn2010-07-27
| |
* | Create connection_or.hSebastian Hahn2010-07-27
| |
* | Create connection_edge.hSebastian Hahn2010-07-27
| |
* | Create connection.hSebastian Hahn2010-07-27
| |
* | Create config.hSebastian Hahn2010-07-27
| |
* | Create circuitlist.hSebastian Hahn2010-07-27
| |
* | Create circuitbuild.hSebastian Hahn2010-07-27
| |
* | Create buffers.hSebastian Hahn2010-07-27
| |
* | Create rendcommon.hSebastian Hahn2010-07-27
| |
* | Create routerlist.hSebastian Hahn2010-07-27
| |