| Commit message (Expand) | Author | Age |
|---|
| * | Merge remote-tracking branch 'linus/bug6757' | Nick Mathewson | 2012-10-04 |
| |\ |
|
| | * | Have node_get_pref_orport() return an IPv6 OR port when UseBridges is set.•••We used to never return an IPv6 address unless ClientUseIPv6 was
set. We should allow clients running with bridges use IPv6 OR ports
even without setting ClientUseIPv6. Configuring an IPv6 address in a
Bridge line should imply that.
Fixes th second part of #6757.
| Linus Nordberg | 2012-09-19 |
| * | | Remove the testing_since* fields•••They weren't actually used since 7a35dad00
Bug 5809
| Nick Mathewson | 2012-09-21 |
| |/ |
|
| * | Move functions for seeing if we know enough nodes into nodelist | Nick Mathewson | 2012-09-14 |
| * | Move many of the node_ functions from routerlist to nodelist | Nick Mathewson | 2012-09-14 |
| * | minor typos i found while constructing the changelog | Roger Dingledine | 2012-09-05 |
| * | Take microdesc into account when deciding about preferred OR port. | Linus Nordberg | 2012-09-04 |
| * | Make node_ipv6_preferred() take microdescs into account.•••Also, make node_get_prim_orport() indicate in its return value whether
a valid OR port was copied or not.
Maybe we should make it legal to pass ap_out==NULL?
| Linus Nordberg | 2012-09-04 |
| * | Take microdesc IPv6 address into account when setting node->ipv6_preferred.•••Also, do this only for clients, explicitly.
Also, give the flag a value every time we set consensus. We used to
touch it only when ClientPreferIPv6ORPort was set, which was wrong.
| Linus Nordberg | 2012-09-04 |
| * | Clients connect to public relays over IPv6.•••Add ClientUseIPv6 and ClientPreferIPv6ORPort configuration options.
Use "preferred OR port" for all entry nodes, not only for bridges.
Mark bridges with "prefer IPv6 OR port" if an IPv6 address is
configured in Bridge line and ClientPreferIPv6ORPort is set.
Mark relays with "prefer IPv6 OR port" if an IPv6 address is found in
descriptor and ClientPreferIPv6ORPort is set.
Filter "preferred OR port" through the ClientUseIPv6 config option. We
might want to move this test to where actual connection is being set
up once we have a fall back mechanism in place.
Have only non-servers pick an IPv6 address for the first hop: We
don't want relays to connect over IPv6 yet. (IPv6 has never been used
for second or third hops.)
Implements ticket 5535.
| Linus Nordberg | 2012-09-04 |
| * | Clear the ipv6_preferred flag like the others.•••I'm not entirely sure that this is meningful but I'm pretty sure it's
not harmful. Seems like the logical thing to do.
| Linus Nordberg | 2012-09-04 |
| * | Fix a comment. | Linus Nordberg | 2012-09-04 |
| * | Fix whitespace | Nick Mathewson | 2012-08-27 |
| * | Move ipv6_preferred from routerinfo_t to node_t.•••Move extend_info_from_router() from circuitbuild.c to router.c and
make it static.
Add get_configured_bridge_by_orports_digest() and have
get_configured_bridge_by_routerinfo() and
node_is_a_configured_bridge() use it. We now consider all OR ports of
a bridge when looking for it.
Move node_get_*_orport to nodelist.c.
Fix a cut'n'paste error in header of nodelist.h.
Add node_assert_ok().
Add router_get_all_orports(). It's duplicating code from
node_get_all_orports(). Worth fixing at the cost of complicating the
API slightly?
| Linus Nordberg | 2012-08-23 |
| * | Try to re-approximate the older semantics of nodelist_add_routerinfo | Nick Mathewson | 2012-07-19 |
| * | Rename routers_have_same_or_addr() to reflect the fact that it now checks bot... | Linus Nordberg | 2012-07-19 |
| * | Add last_reachable and testing_since for IPv6 OR port. | Linus Nordberg | 2012-07-19 |
| * | Move last_reachable and testing_since from routerinfo_t to node_t. | Linus Nordberg | 2012-07-19 |
| * | Catch a few more K&R violations with make check-spaces•••We now catch bare {s that should be on the previous line with a do,
while, if, or for, and elses that should share a line with their
preceding }.
That is,
if (foo)
{
and
if (foo) {
...
}
else
are now detected.
We should think about maybe making Tor uncrustify-clean some day,
but configuring uncrustify is an exercise in bizarreness, and
reformatting huge gobs of Tor is always painful.
| Nick Mathewson | 2012-06-23 |
| * | Update copyright dates to 2012; add a few missing copyright statements | Nick Mathewson | 2012-06-04 |
| * | Rename nonconformant identifiers.•••Fixes bug 4893.
These changes are pure mechanical, and were generated with this
perl script:
/usr/bin/perl -w -i.bak -p
s/crypto_pk_env_t/crypto_pk_t/g;
s/crypto_dh_env_t/crypto_dh_t/g;
s/crypto_cipher_env_t/crypto_cipher_t/g;
s/crypto_digest_env_t/crypto_digest_t/g;
s/aes_free_cipher/aes_cipher_free/g;
s/crypto_free_cipher_env/crypto_cipher_free/g;
s/crypto_free_digest_env/crypto_digest_free/g;
s/crypto_free_pk_env/crypto_pk_free/g;
s/_crypto_dh_env_get_dh/_crypto_dh_get_dh/g;
s/_crypto_new_pk_env_rsa/_crypto_new_pk_from_rsa/g;
s/_crypto_pk_env_get_evp_pkey/_crypto_pk_get_evp_pkey/g;
s/_crypto_pk_env_get_rsa/_crypto_pk_get_rsa/g;
s/crypto_new_cipher_env/crypto_cipher_new/g;
s/crypto_new_digest_env/crypto_digest_new/g;
s/crypto_new_digest256_env/crypto_digest256_new/g;
s/crypto_new_pk_env/crypto_pk_new/g;
s/crypto_create_crypto_env/crypto_cipher_new/g;
s/connection_create_listener/connection_listener_new/g;
s/smartlist_create/smartlist_new/g;
s/transport_create/transport_new/g;
| Nick Mathewson | 2012-01-18 |
| * | Rename one more recalcitrant function. | Nick Mathewson | 2011-11-30 |
| * | Make the router_get_*_orport interface consistent with node_*. | Linus Nordberg | 2011-11-30 |
| * | Make router_get_{prim,alt,pref}_addr_port take tor_addr_port_t *.•••Rename to *_orport for consistency with node_*.
| Linus Nordberg | 2011-11-30 |
| * | Merge node_get_{prim,pref,pref_ipv6}_addr with their _orport counterparts.•••This keeps the IP address and TCP for a given OR port together,
reducing the risk of using an address for one address family with a
port of another.
Make node_get_addr() a wrapper function for compatibility.
| Linus Nordberg | 2011-11-30 |
| * | First chunk of support for bridges on IPv6•••Comments below focus on changes, see diff for added code.
New type tor_addr_port_t holding an IP address and a TCP/UDP port.
New flag in routerinfo_t, ipv6_preferred. This should go in the
node_t instead but not now.
Replace node_get_addr() with
- node_get_prim_addr() for primary address, i.e. IPv4 for now
- node_get_pref_addr() for preferred address, IPv4 or IPv6.
Rename node_get_addr_ipv4h() node_get_prim_addr_ipv4h() for
consistency. The primary address will not allways be an IPv4 address.
Same for node_get_orport() -> node_get_prim_orport().
Rewrite node_is_a_configured_bridge() to take all OR ports into account.
Extend argument list to extend_info_from_node and
extend_info_from_router with a flag indicating if we want to use the
routers primary address or the preferred address. Use the preferred
address in as few situtations as possible for allowing clients to
connect to bridges over IPv6.
| Linus Nordberg | 2011-11-30 |
| * | Make sure the microdesc cache is loaded before setting a v3 md consensus•••Otherwise, we can wind up munging our reference counts if we set it in
the middle of loading the nodes. This happens because
nodelist_set_consensus() and microdesc_reload_cache() are both in the
business of adjusting microdescriptors' references.
| Nick Mathewson | 2011-09-28 |
| * | Fix a crash bug in tor_assert(md->held_by_node)•••The fix is to turn held_by_node into a reference count.
Fixes bug 4118; bugfix on 0.2.3.1-alpha.
| Nick Mathewson | 2011-09-28 |
| * | Make nodelist_purge avoid orphaned microdescs in rs-less nodes•••We have an invariant that a node_t should have an md only if it has
a routerstatus. nodelist_purge tried to preserve this by removing
all nodes without a routerstatus or a routerinfo. But this left
nodes with a routerinfo and a microdesc untouched, even if they had
a routerstatus.
Bug found by frosty_un.
| Nick Mathewson | 2011-07-07 |
| * | Merge remote-tracking branch 'public/bug3153'•••Conflicts:
src/or/nodelist.c
| Nick Mathewson | 2011-07-07 |
| |\ |
|
| | * | Track where microdescs are referenced to prevent free errs•••On IRC, wanoskarnet notes that if we ever do microdesc_free() on a
microdesc that's in the nodelist, we're in trouble. Also, we're in
trouble if we free one that's still in the microdesc_cache map.
This code adds a flag to microdesc_t to note where the microdesc is
referenced from, and checks those flags from microdesc_free(). I
don't believe we have any errors here now, but if we introduce some
later, let's log and recover from them rather than introducing
heisenbugs later on.
Addresses bug 3153.
| Nick Mathewson | 2011-05-12 |
| * | | Make the get_options() return const•••This lets us make a lot of other stuff const, allows the compiler to
generate (slightly) better code, and will make me get slightly fewer
patches from folks who stick mutable stuff into or_options_t.
const: because not every input is an output!
| Nick Mathewson | 2011-06-14 |
| * | | Fix a memleak in nodelist_assert_ok() | Sebastian Hahn | 2011-06-08 |
| * | | Hand-tune the new tor_memcmp instances in 0.2.3 | Nick Mathewson | 2011-05-11 |
| * | | Reapply the automated memcmp conversion to 0.2.3 to catch newly added memcmps | Nick Mathewson | 2011-05-11 |
| |/ |
|
| * | Bump copyright statements to 2011 (master) | Nick Mathewson | 2011-01-03 |
| * | Remove a ??? comment in node_get_by_nickname•••Bug 1859 shows that the router_get_by_nickname behavior was wrong,
and the node_get_by_nickname is right.
| Nick Mathewson | 2010-10-21 |
| * | Add a node_get_by_hex_id(). | Nick Mathewson | 2010-10-21 |
| * | Make check-spaces happy | Sebastian Hahn | 2010-10-14 |
| * | Implement node_set_exit_policy_to_reject_all with a flag•••Also remove some debugging code.
| Nick Mathewson | 2010-10-13 |
| * | Fix a couple more node_t-related nullpointer bugs | Nick Mathewson | 2010-10-04 |
| * | More debugging code for node_t branch | Nick Mathewson | 2010-10-01 |
| * | Implement policies for nodes (and for microdescriptors too) | Nick Mathewson | 2010-10-01 |
| * | Implement a few more node-based functions•••Some of these functions only work for routerinfo-based nodes, and as
such are only usable for advisory purposes. Fortunately, our uses
of them are compatible with this limitation.
| Nick Mathewson | 2010-10-01 |
| * | Implement node-based router family code•••Also, make the NodeFamily option into a list of routersets. This
lets us git rid of router_in_nickname_list (or whatever it was
called) without porting it to work with nodes, and also lets people
specify country codes and IP ranges in NodeFamily
| Nick Mathewson | 2010-10-01 |
| * | Rename routerstatus_t.is_running to is_flagged_running•••This was the only flag in routerstatus_t that we would previously
change in a routerstatus_t in a consensus. We no longer have reason
to do so -- and probably never did -- as you can now confirm more
easily than you could have done by grepping for is_running before
this patch.
The name change is to emphasize that the routerstatus_t is_running
flag is only there to tell you whether the consensus says it's
running, not whether it *you* think it's running.
| Nick Mathewson | 2010-10-01 |
| * | Initial conversion to use node_t throughout our codebase.•••A node_t is an abstraction over routerstatus_t, routerinfo_t, and
microdesc_t. It should try to present a consistent interface to all
of them. There should be a node_t for a server whenever there is
* A routerinfo_t for it in the routerlist
* A routerstatus_t in the current_consensus.
(note that a microdesc_t alone isn't enough to make a node_t exist,
since microdescriptors aren't usable on their own.)
There are three ways to get a node_t right now: looking it up by ID,
looking it up by nickname, and iterating over the whole list of
microdescriptors.
All (or nearly all) functions that are supposed to return "a router"
-- especially those used in building connections and circuits --
should return a node_t, not a routerinfo_t or a routerstatus_t.
A node_t should hold all the *mutable* flags about a node. This
patch moves the is_foo flags from routerinfo_t into node_t. The
flags in routerstatus_t remain, but they get set from the consensus
and should not change.
Some other highlights of this patch are:
* Looking up routerinfo and routerstatus by nickname is now
unified and based on the "look up a node by nickname" function.
This tries to look only at the values from current consensus,
and not get confused by the routerinfo_t->is_named flag, which
could get set for other weird reasons. This changes the
behavior of how authorities (when acting as clients) deal with
nodes that have been listed by nickname.
* I tried not to artificially increase the size of the diff here
by moving functions around. As a result, some functions that
now operate on nodes are now in the wrong file -- they should
get moved to nodelist.c once this refactoring settles down.
This moving should happen as part of a patch that moves
functions AND NOTHING ELSE.
* Some old code is now left around inside #if 0/1 blocks, and
should get removed once I've verified that I don't want it
sitting around to see how we used to do things.
There are still some unimplemented functions: these are flagged
with "UNIMPLEMENTED_NODELIST()." I'll work on filling in the
implementation here, piece by piece.
I wish this patch could have been smaller, but there did not seem to
be any piece of it that was independent from the rest. Moving flags
forces many functions that once returned routerinfo_t * to return
node_t *, which forces their friends to change, and so on.
| Nick Mathewson | 2010-10-01 |
| * | Try to make most routerstatus_t interfaces const | Nick Mathewson | 2010-10-01 |
| * | Implement a basic node and nodelist type•••The node_t type is meant to serve two key functions:
1) Abstracting difference between routerinfo_t and microdesc_t
so that clients can use microdesc_t instead of routerinfo_t.
2) Being a central place to hold mutable state about nodes
formerly held in routerstatus_t and routerinfo_t.
This patch implements a nodelist type that holds a node for every
router that we would consider using.
| Nick Mathewson | 2010-10-01 |