| Commit message (Expand) | Author | Age |
* | Merge branch 'safelogging2'•••Conflicts:
ChangeLog
| Nick Mathewson | 2009-12-15 |
|\ |
|
| * | Refactor the safe_str_*() API to make more sense.•••The new rule is: safe_str_X() means "this string is a piece of X
information; make it safe to log." safe_str() on its own means
"this string is a piece of who-knows-what; make it safe to log".
| Nick Mathewson | 2009-12-15 |
| * | Allow SafeLogging to exclude client related information | Sebastian Hahn | 2009-12-12 |
* | | Refactor a bit so that it is safe to include math.h, and mostly not needed. | Nick Mathewson | 2009-12-15 |
* | | Now that FOO_free(NULL) always works, remove checks before calling it. | Nick Mathewson | 2009-12-12 |
* | | *_free functions now accept NULL•••Some *_free functions threw asserts when passed NULL. Now all of them
accept NULL as input and perform no action when called that way.
This gains us consistence for our free functions, and allows some
code simplifications where an explicit null check is no longer necessary.
| Sebastian Hahn | 2009-12-12 |
|/ |
|
* | Remove checks for array existence. (CID 410..415)•••In C, the code "char x[10]; if (x) {...}" always takes the true branch of
the if statement. Coverity notices this now.
In some cases, we were testing arrays to make sure that an operation
we wanted to do would suceed. Those cases are now always-true.
In some cases, we were testing arrays to see if something was _set_.
Those caes are now tests for strlen(s), or tests for
!tor_mem_is_zero(d,len).
| Nick Mathewson | 2009-10-26 |
* | fix compile on windows | Roger Dingledine | 2009-10-11 |
* | Fix a memleak when throwing away some build times•••This was introduced in f7e6e852e80c22b40a8f09bc1c85074726d7078e.
Found by Coverity
| Sebastian Hahn | 2009-10-10 |
* | Tweak an assert that shouldn't fire either way.•••There were however other places where we used to call this
function that might have caused this to fire. Better
safe than sorry now.
| Mike Perry | 2009-10-07 |
* | Tweak values for when to discard all of our history.•••This seems to be happening to me a lot on a garbage DSL line.
We may need to come up with 2 threshholds: a high short onehop
count and a lower longer count.
| Mike Perry | 2009-10-07 |
* | Remove another overzealous assert.•••Pretimeouts may have build time data, just no timeout data.
| Mike Perry | 2009-10-07 |
* | try to stem the 'sea of fail' | Roger Dingledine | 2009-10-01 |
* | Ignore one-hop circuits for circuit timeout calc•••Don't count one-hop circuits when we're estimating how long it
takes circuits to build on average. Otherwise we'll set our circuit
build timeout lower than we should. Bugfix on 0.2.2.2-alpha.
| Roger Dingledine | 2009-10-01 |
* | Fix 1108: Handle corrupt or large build times state.•••1108 was actually just a fencepost error in an assert,
but making the state file handling code resilient is a
good idea.
| Mike Perry | 2009-09-29 |
* | Fix memory leak•••Some memory could be lost in the error case of
circuit_build_times_parse_state.
Found by Coverity
| Sebastian Hahn | 2009-09-27 |
* | Fix Bug 1103.•••Don't pass in a quantile that is too high during pretimeout
calcualtion.
| Mike Perry | 2009-09-21 |
* | Change the condition on the nonlive timeout counting.•••Try to clarify things in the comment too.
| Mike Perry | 2009-09-20 |
* | Fix typos and comments, plus two bugs•••A) We were considering a circuit had timed out in the special cases
where we close rendezvous circuits because the final rendezvous
circuit couldn't be built in time.
B) We were looking at the wrong timestamp_created when considering
a timeout.
| Roger Dingledine | 2009-09-20 |
* | Implement and document new network liveness algorithm.•••Based on irc discussion with arma.
| Mike Perry | 2009-09-20 |
* | Fix some precision-related asserts in unit tests.•••Mostly by storing the timeout as milliseconds and not seconds
internally.
| Mike Perry | 2009-09-20 |
* | Fix compile on freebsd | Sebastian Hahn | 2009-09-18 |
* | give proposal 151 a changelog and other touchups | Roger Dingledine | 2009-09-17 |
* | Clarify use of magic number 0.98 with #define. | Mike Perry | 2009-09-16 |
* | Fix unit tests and compile issues on Snow Leopard | Sebastian Hahn | 2009-09-16 |
* | Change liveness value to be a function of the timeout.•••And also the number of recent circuits used to decide
when the network changes.
| Mike Perry | 2009-09-16 |
* | Add log message so we have accurate build time values. | Mike Perry | 2009-09-16 |
* | Address nickm's issues from his review #1. | Mike Perry | 2009-09-16 |
* | Move circuitbuildtimeout config check.•••We want it to be under our control so it doesn't mess
up initialization. This is likely the cause for
the bug the previous assert-adding commit (09a75ad) was
trying to address.
| Mike Perry | 2009-09-16 |
* | Time for some debugging by asserts.•••Got a negative timeout value on startup. Need to narrow it down.
| Mike Perry | 2009-09-16 |
* | Fix bugs relating to not counting timeouts as circuit builds.•••Also use bin midpoints for time values.
| Mike Perry | 2009-09-16 |
* | Document functions and constants. | Mike Perry | 2009-09-16 |
* | Remove an assert.•••It seems to fire because of precision issues. Added
more debug info to the warn to try to figure out for sure.
| Mike Perry | 2009-09-16 |
* | Fix issues found by arma in review. | Mike Perry | 2009-09-16 |
* | space/indent cleanups, plus point out three bugs | Roger Dingledine | 2009-09-16 |
* | Woops. Fix a couple memory leaks.•••Also change the max timeout quantile to 0.98, so we can
avoid huge synthetic timeout values.
| Mike Perry | 2009-09-16 |
* | Remove trailing spaces. As if bytes were free...•••Also correct some typos.
| Karsten Loesing | 2009-09-16 |
* | Resolve mode ties in favor of the higher (slower) mode. | Mike Perry | 2009-09-16 |
* | More detail for some log msgs. | Mike Perry | 2009-09-16 |
* | Use our variable directly for timeout.•••Using CircuitBuildTimeout is prone to issues with SIGHUP, etc.
Also, shuffle the circuit build times array after loading it
in so that newer measurements don't replace chunks of
similarly timed measurements.
| Mike Perry | 2009-09-16 |
* | Fix a couple of assert bugs. | Mike Perry | 2009-09-16 |
* | Fix timeout edge case when we get enough samples.•••Also switch Xm calculation to mode, not min.
| Mike Perry | 2009-09-16 |
* | Fix the math.h log() conflict.•••It was compiling, but causing segfaults.
Also, adjust when the timer starts for new test circs
and save state every 25 circuits.
| Mike Perry | 2009-09-16 |
* | Recover from changing network connections.•••Also add code to keep creating circuits every minute until we
hit our minimum threshhold.
| Mike Perry | 2009-09-16 |
* | Factor out the pretimeout handling code.•••We need to also call it if we're going to calculate alpha
after a normal circuit build.
| Mike Perry | 2009-09-16 |
* | Write unit tests and fix issues they uncovered. | Mike Perry | 2009-09-16 |
* | Implement the pareto fitting and timeout calculating bits. | Mike Perry | 2009-09-16 |
* | Clean up Fallon's partially complete GSoC project.•••The code actually isn't that bad. It's a shame she didn't finish.
Using it as the base for this feature.
| Mike Perry | 2009-09-16 |
* | Merge commit 'origin/maint-0.2.1'•••Resolved conflicts in:
src/or/circuitbuild.c
| Nick Mathewson | 2009-09-15 |
|\ |
|
| * | make some bug 1090 warnings go away•••When we excluded some Exits, we were sometimes warning the user that we
were going to use the node regardless. Many of those warnings were in
fact bogus, because the relay in question was not used to connect to
the outside world.
Based on patch by Rotor, thanks!
| Sebastian Hahn | 2009-09-16 |