| Commit message (Expand) | Author | Age |
* | Bug 8235: Fix scaling adjustments.•••We need to subtract both the current built circuits *and* the attempted
circuits from the attempt count during scaling, since *both* have already been
counted there.
| Mike Perry | 2013-04-24 |
* | Fix a wide line | Nick Mathewson | 2013-04-03 |
* | Add additional checks for Path Bias scaling.•••Just in case more issues remain with scaling, it would be nice to pin-point
them as such.
| Mike Perry | 2013-04-03 |
* | Bug #8196: Demote a path bias notice that can be caused by controllers.•••We didn't see this in normal usage anyway.
| Mike Perry | 2013-03-29 |
* | Bug 8230: Mark circuits as opened before reachability testing.•••Should silence two path bias Bug messages seen on relays at startup.
| Mike Perry | 2013-03-29 |
* | Add some missing case values to please clang•••It seems that some versions of clang that would prefer the
-Wswitch-enum compiler flag to warn about switch statements with
missing enum values, even if those switch statements have a
default.
Fixes bug 8598; bugfix on 0.2.4.10-alpha.
| Nick Mathewson | 2013-03-27 |
* | Bug 7065: Use $ for idhex instead of = | Mike Perry | 2013-03-26 |
* | Merge remote-tracking branch 'public/bug6174' into maint-0.2.4 | Nick Mathewson | 2013-03-18 |
|\ |
|
| * | Rename circuit_expire_all_dirty_circs•••The new name is circuit_mark_all_dirty_circs_as_unusable.
This resolves an XXX024
| Nick Mathewson | 2013-02-19 |
* | | Merge remote-tracking branch 'public/no_dup_guards' into maint-0.2.4 | Nick Mathewson | 2013-03-18 |
|\ \ |
|
| * | | Be more robust when excluding existing nodes as new dirguards•••In addition to rejecting them post-hoc, avoid picking them in the
first place. This makes us less likely to decide that we can't add
guards at all.
| Nick Mathewson | 2013-02-14 |
* | | | Fix 8447: use %u to format circid_t.•••Now that circid_t is 4 bytes long, the default integer promotions will
leave it alone when sizeof(int) == 4, which will leave us formatting an
unsigned as an int. That's technically undefined behavior.
Fixes bug 8447 on bfffc1f0fc7616a25c32da2eb759dade4651659e. Bug not
in any released Tor.
| Nick Mathewson | 2013-03-10 |
| |/
|/| |
|
* | | Downgrade an assert to LD_BUG•••This should prevent crashes on further recurrence of 8065, and help
diagnose such if they occur
| Nick Mathewson | 2013-02-19 |
* | | Merge remote-tracking branch 'public/wide_circ_ids'•••Conflicts:
src/or/channel.h
src/or/connection_or.c
src/or/cpuworker.c
| Nick Mathewson | 2013-02-15 |
|\ \ |
|
| * | | Allow a v4 link protocol for 4-byte circuit IDs.•••Implements proposal 214.
Needs testing.
| Nick Mathewson | 2012-11-06 |
* | | | Merge remote-tracking branch 'public/feature4994-rebased' | Nick Mathewson | 2013-02-15 |
|\ \ \
| |_|/
|/| | |
|
| * | | Restore the entry/dirguard distinction.•••We shouldn't be calling choose_random_entry() for directory
conncetions; that's what choose_random_dirguard() is for.
| Nick Mathewson | 2013-02-12 |
| * | | generalize choose_random_entry()'s dirinfo parameter•••Now we can specify to skip bridges that wouldn't be able to answer the
type of dir fetch we're launching.
It's still the responsibility of the rest of the code to prevent us from
launching a given dir fetch if we have no bridges that could handle it.
| Roger Dingledine | 2013-02-02 |
| * | | use microdescriptors if *any* of our bridges can handle them•••Now as we move into a future where most bridges can handle microdescs
we will generally find ourselves using them, rather than holding back
just because one of our bridges doesn't use them.
| Roger Dingledine | 2013-02-02 |
* | | | Avoid null-pointer deref in pathbias_is_new_circ_attempt•••Coverity is worried about this (CID 980653). It hasn't happened in
testing, but we might as well make sure it can't happen.
| Nick Mathewson | 2013-02-11 |
* | | | Mention a trac ticket relevant to an XXX comment. | Mike Perry | 2013-02-07 |
* | | | Better document an XXX comment about refactoring. | Mike Perry | 2013-02-07 |
* | | | Separate the flags for logging use bias.•••I think we want both sets of messages to appear independently to help us know
what needs tuning.
| Mike Perry | 2013-02-07 |
* | | | Lower path use bias thresholds.•••I noticed bad wifi networks can have low use success rates.
| Mike Perry | 2013-02-04 |
* | | | Reinstate some fixes/tweaks from 6e4a4002•••These seem to have gotten conflicted out of existence while mike was
working on path bias stuff.
Thanks to sysrqb for collecting these in a handy patch.
| Nick Mathewson | 2013-02-04 |
|/ / |
|
* | | Fix a couple of warnings on the 8081 branch. | Nick Mathewson | 2013-02-01 |
* | | Increment an informational counter for use failed state.•••This informational counter is probably now redundant, but might as well keep
it consistent I guess.
| Mike Perry | 2013-02-01 |
* | | Fix a log typo found by sysrqb. | Mike Perry | 2013-02-01 |
* | | Refactor code that rolls back the use state•••Also document it better.
Mention this refactoring in the comments for the path state machine.
| Mike Perry | 2013-02-01 |
* | | Refactor and rename pathbias rate evaluation. | Mike Perry | 2013-02-01 |
* | | Refactor the scaling parameter fetching into a single function.•••Also, deprecate the torrc options for the scaling values. It's unlikely anyone
but developers will ever tweak them, even if we provided a single ratio value.
| Mike Perry | 2013-02-01 |
* | | Mark entry guard state dirty everwhere the pathbias code touches it. | Mike Perry | 2013-02-01 |
* | | Add a tristate to guard against unexpected circ purpose transitions | Mike Perry | 2013-02-01 |
* | | Clarify state transition and related pathbias comments | Mike Perry | 2013-02-01 |
* | | Bug 8024: Check for null/closed channel before probing. | Mike Perry | 2013-01-22 |
* | | squash! Remove a source of error during path bias scaling•••Improve debug logs and fix a state fencepost error.
| Mike Perry | 2013-01-20 |
* | | squash! Implement Path use bias accounting.•••Make a debug log more informative.
| Mike Perry | 2013-01-20 |
* | | squash! Remove a source of error during path bias scaling•••Move a log message about scaling to after we scale
| Mike Perry | 2013-01-20 |
* | | Remove a source of error during path bias scaling•••If any circuits were opened during a scaling event, we were scaling attempts
and successes by different amounts. This leads to rounding error.
The fix is to record how many circuits are in a state that hasn't been fully
counted yet, and subtract that before scaling, and add it back afterwords.
| Mike Perry | 2013-01-18 |
* | | Don't immediately count cannibalized circs as used.•••Since they use RELAY_EARLY (which can be seen by all hops on the path),
it's not safe to say they actually count as a successful use.
There are also problems with trying to allow them to finish extending due to
the circuit purpose state machine logic. It is way less complicated (and
possibly more semantically coherent) to simply wait until we actually try to
do something with them before claiming we 'used' them.
Also, we shouldn't call timed out circuits 'used' either, for semantic
consistency.
| Mike Perry | 2013-01-18 |
* | | Implement Path use bias accounting.•••Path use bias measures how often we can actually succeed using the circuits we
actually try to use. It is a subset of path bias accounting, but it is
computed as a separate statistic because the rate of client circuit use may
vary depending on use case.
| Mike Perry | 2013-01-18 |
* | | Rename *_isin to *_contains•••This is an automatically generated commit, from the following perl script,
run with the options "-w -i -p".
s/smartlist_string_num_isin/smartlist_contains_int_as_string/g;
s/smartlist_string_isin((?:_case)?)/smartlist_contains_string$1/g;
s/smartlist_digest_isin/smartlist_contains_digest/g;
s/smartlist_isin/smartlist_contains/g;
s/digestset_isin/digestset_contains/g;
| Nick Mathewson | 2013-01-16 |
* | | Update the copyright date to 201. | Nick Mathewson | 2013-01-16 |
* | | Clean up odds and ends | Roger Dingledine | 2013-01-15 |
* | | Better log message to diagnose #7959 | Nick Mathewson | 2013-01-15 |
* | | Bug 7691 review fixes.•••Also add in the random nonce generation.
| Mike Perry | 2013-01-08 |
* | | Bug 7691: Send a probe cell down certain types of circs.•••In general, if we tried to use a circ for a stream, but then decided to place
that stream on a different circuit, we need to probe the original circuit
before deciding it was a "success".
We also need to do the same for cannibalized circuits that go unused.
| Mike Perry | 2013-01-08 |
* | | Fix bug 7341.•••Fix cannibalize, rend circ and intro circ timeout handling.
| Mike Perry | 2013-01-08 |
* | | Merge branch 'ntor-resquashed'•••Conflicts:
src/or/cpuworker.c
src/or/or.h
src/test/bench.c
| Nick Mathewson | 2013-01-03 |
|\ \ |
|
| * | | Complete all DOCDOC entries from the ntor branch | Nick Mathewson | 2013-01-03 |