| Commit message (Expand) | Author | Age |
* | Mention a trac ticket relevant to an XXX comment. | Mike Perry | 2013-02-07 |
* | Better document an XXX comment about refactoring. | Mike Perry | 2013-02-07 |
* | Separate the flags for logging use bias.•••I think we want both sets of messages to appear independently to help us know
what needs tuning.
| Mike Perry | 2013-02-07 |
* | Lower path use bias thresholds.•••I noticed bad wifi networks can have low use success rates.
| Mike Perry | 2013-02-04 |
* | Reinstate some fixes/tweaks from 6e4a4002•••These seem to have gotten conflicted out of existence while mike was
working on path bias stuff.
Thanks to sysrqb for collecting these in a handy patch.
| Nick Mathewson | 2013-02-04 |
* | Fix a couple of warnings on the 8081 branch. | Nick Mathewson | 2013-02-01 |
* | Increment an informational counter for use failed state.•••This informational counter is probably now redundant, but might as well keep
it consistent I guess.
| Mike Perry | 2013-02-01 |
* | Fix a log typo found by sysrqb. | Mike Perry | 2013-02-01 |
* | Refactor code that rolls back the use state•••Also document it better.
Mention this refactoring in the comments for the path state machine.
| Mike Perry | 2013-02-01 |
* | Refactor and rename pathbias rate evaluation. | Mike Perry | 2013-02-01 |
* | Refactor the scaling parameter fetching into a single function.•••Also, deprecate the torrc options for the scaling values. It's unlikely anyone
but developers will ever tweak them, even if we provided a single ratio value.
| Mike Perry | 2013-02-01 |
* | Mark entry guard state dirty everwhere the pathbias code touches it. | Mike Perry | 2013-02-01 |
* | Add a tristate to guard against unexpected circ purpose transitions | Mike Perry | 2013-02-01 |
* | Clarify state transition and related pathbias comments | Mike Perry | 2013-02-01 |
* | Bug 8024: Check for null/closed channel before probing. | Mike Perry | 2013-01-22 |
* | squash! Remove a source of error during path bias scaling•••Improve debug logs and fix a state fencepost error.
| Mike Perry | 2013-01-20 |
* | squash! Implement Path use bias accounting.•••Make a debug log more informative.
| Mike Perry | 2013-01-20 |
* | squash! Remove a source of error during path bias scaling•••Move a log message about scaling to after we scale
| Mike Perry | 2013-01-20 |
* | Remove a source of error during path bias scaling•••If any circuits were opened during a scaling event, we were scaling attempts
and successes by different amounts. This leads to rounding error.
The fix is to record how many circuits are in a state that hasn't been fully
counted yet, and subtract that before scaling, and add it back afterwords.
| Mike Perry | 2013-01-18 |
* | Don't immediately count cannibalized circs as used.•••Since they use RELAY_EARLY (which can be seen by all hops on the path),
it's not safe to say they actually count as a successful use.
There are also problems with trying to allow them to finish extending due to
the circuit purpose state machine logic. It is way less complicated (and
possibly more semantically coherent) to simply wait until we actually try to
do something with them before claiming we 'used' them.
Also, we shouldn't call timed out circuits 'used' either, for semantic
consistency.
| Mike Perry | 2013-01-18 |
* | Implement Path use bias accounting.•••Path use bias measures how often we can actually succeed using the circuits we
actually try to use. It is a subset of path bias accounting, but it is
computed as a separate statistic because the rate of client circuit use may
vary depending on use case.
| Mike Perry | 2013-01-18 |
* | Rename *_isin to *_contains•••This is an automatically generated commit, from the following perl script,
run with the options "-w -i -p".
s/smartlist_string_num_isin/smartlist_contains_int_as_string/g;
s/smartlist_string_isin((?:_case)?)/smartlist_contains_string$1/g;
s/smartlist_digest_isin/smartlist_contains_digest/g;
s/smartlist_isin/smartlist_contains/g;
s/digestset_isin/digestset_contains/g;
| Nick Mathewson | 2013-01-16 |
* | Update the copyright date to 201. | Nick Mathewson | 2013-01-16 |
* | Clean up odds and ends | Roger Dingledine | 2013-01-15 |
* | Better log message to diagnose #7959 | Nick Mathewson | 2013-01-15 |
* | Bug 7691 review fixes.•••Also add in the random nonce generation.
| Mike Perry | 2013-01-08 |
* | Bug 7691: Send a probe cell down certain types of circs.•••In general, if we tried to use a circ for a stream, but then decided to place
that stream on a different circuit, we need to probe the original circuit
before deciding it was a "success".
We also need to do the same for cannibalized circuits that go unused.
| Mike Perry | 2013-01-08 |
* | Fix bug 7341.•••Fix cannibalize, rend circ and intro circ timeout handling.
| Mike Perry | 2013-01-08 |
* | Merge branch 'ntor-resquashed'•••Conflicts:
src/or/cpuworker.c
src/or/or.h
src/test/bench.c
| Nick Mathewson | 2013-01-03 |
|\ |
|
| * | Complete all DOCDOC entries from the ntor branch | Nick Mathewson | 2013-01-03 |
| * | Enable the ntor handshake on the client side.•••"works for me"
| Nick Mathewson | 2013-01-03 |
| * | Don't check create cells too much when we're relaying them•••We want to sanity-check our own create cells carefully, and other
people's loosely.
| Nick Mathewson | 2013-01-03 |
| * | Use created_cell_format where appropriate | Nick Mathewson | 2013-01-03 |
| * | Use new wrappers for making,sending,processing create/extend cells | Nick Mathewson | 2013-01-03 |
| * | Teach cpuworker and others about create_cell_t and friends•••The unit of work sent to a cpuworker is now a create_cell_t; its
response is now a created_cell_t. Several of the things that call or
get called by this chain of logic now take create_cell_t or
created_cell_t too.
Since all cpuworkers are forked or spawned by Tor, they don't need a
stable wire protocol, so we can just send structs. This saves us some
insanity, and helps p
| Nick Mathewson | 2013-01-03 |
| * | Rename handshake_digest to rend_circ_nonce•••The handshake_digest field was never meaningfully a digest *of* the
handshake, but rather is a digest *from* the handshake that we exapted
to prevent replays of ESTABLISH_INTRO cells. The ntor handshake will
generate it as more key material rather than taking it from any part
of the circuit handshake reply..
| Nick Mathewson | 2013-01-03 |
| * | Massive refactoring of the various handshake types•••The three handshake types are now accessed from a unified interface;
their state is abstracted from the rest of the cpath state, and so on.
| Nick Mathewson | 2013-01-03 |
| * | Refactor the CREATE_FAST handshake code to match the others. | Nick Mathewson | 2013-01-03 |
| * | Split onion.[ch] into onion{,_fast,_tap}.[ch]•••I'm going to want a generic "onionskin" type and set of wrappers, and
for that, it will be helpful to isolate the different circuit creation
handshakes. Now the original handshake is in onion_tap.[ch], the
CREATE_FAST handshake is in onion_fast.[ch], and onion.[ch] now
handles the onion queue.
This commit does nothing but move code and adjust header files.
| Nick Mathewson | 2013-01-02 |
* | | Fix whitespace | Nick Mathewson | 2012-12-25 |
* | | Nick's Code review #3 part 2. | Mike Perry | 2012-12-18 |
* | | Changes from Nick's code review 'part 1'•••I think this is actually his third code review of this branch so far.
| Mike Perry | 2012-12-18 |
* | | Tags on relay cells can result in certain reason codes.•••Close the circuit (it's probably junk anyways), and make sure we don't probe
it/count it as a success.
| Mike Perry | 2012-12-11 |
* | | Woops, this log message triggers with the 2-hop bias commit. | Mike Perry | 2012-12-11 |
* | | Add a missing comment. | Mike Perry | 2012-12-10 |
* | | More log message and space fixups. | Mike Perry | 2012-12-10 |
* | | Clean up some XXX comments. | Mike Perry | 2012-12-09 |
* | | Space fixes. | Mike Perry | 2012-12-09 |
* | | Fix a rather serious use-count state bug.•••We need to use the success count or the use count depending on the consensus
parameter.
| Mike Perry | 2012-12-09 |
* | | Convert to doubles for all pathbias state.•••Let's hope this solves the rounding error issue..
| Mike Perry | 2012-12-09 |