aboutsummaryrefslogtreecommitdiff
path: root/src/common
Commit message (Collapse)AuthorAge
* Don't attempt to log messages to a controller from a worker thread.Nick Mathewson2009-05-30
| | | | | | | | | | | This patch adds a function to determine whether we're in the main thread, and changes control_event_logmsg() to return immediately if we're in a subthread. This is necessary because otherwise we will call connection_write_to_buf, which modifies non-locked data structures. Bugfix on 0.2.0.x; fix for at least one of the things currently called "bug 977".
* Fixes to spelling fixes. Thanks, Roger!Nick Mathewson2009-05-28
|
* Spell-check Tor.Nick Mathewson2009-05-27
|
* Spelling fixes in comments and stringsNick Mathewson2009-05-27
|
* Stop using malloc_usable_size(): valgrind hates it.Nick Mathewson2009-05-17
|
* Fix an assertion-failure in memarea_alloc() on 64-bit platforms.Nick Mathewson2009-05-17
| | | | | | | The trick is that we should assert that our next_mem pointer has not run off the end of the array _before_ we realign the pointer, since doing that could take us over the end... but only if we're on a system where malloc() gives us ram in increments smaller than sizeof(void*).
* Use a mutex to protect the count of open sockets.Nick Mathewson2009-05-13
| | | | | | | This matters because a cpuworker can close its socket when it finishes. Cpuworker typically runs in another thread, so without a lock here, we can have a race condition and get confused about how many sockets are open. Possible fix for bug 939.
* Update copyright to 2009.Karsten Loesing2009-05-04
|
* Actually do that memarea_strndup fix right. Not only must you not examine ↵Nick Mathewson2009-03-21
| | | | | | unmapped ram, but you also must not copy it. From lark. svn:r19095
* fix from lark: make memarea_strndup() work even at the end of a mmap chunk. ↵Nick Mathewson2009-03-21
| | | | | | Bug was harmless for now, I think. svn:r19094
* Add some asserts to try to catch bug 930Nick Mathewson2009-03-18
| | | | svn:r19074
* doxygen tweakRoger Dingledine2009-03-09
| | | | svn:r18818
* Actually use tor_sscanf() to parse untrusted input.Nick Mathewson2009-03-03
| | | | svn:r18761
* Add a simple locale-independent no-surprises sscanf replacement.Nick Mathewson2009-03-03
| | | | | | | | | | tor_sscanf() only handles %u and %s for now, which will make it adequate to replace sscanf() for date/time/IP parsing. We want this to prevent attackers from constructing weirdly formed descriptors, cells, addresses, HTTP responses, etc, that validate under some locales but not others. svn:r18760
* Add and use set/get_uint64 on onion tags. [bug 604; backportable]Nick Mathewson2009-03-02
| | | | | | | | | It seems that 64-bit Sparc Solaris demands 64-bit-aligned access to uint64_t, but does not 64-bit-align the stack-allocated char array we use for cpuworker tags. So this patch adds a set/get_uint64 pair, and uses them to access the conn_id field in the tag. svn:r18743
* Use prctl to reenable core dumps when we have setuid to a non-root user.Nick Mathewson2009-02-09
| | | | svn:r18449
* Remove some deadcode and use tor_inet_aton uniformly.Nick Mathewson2009-02-09
| | | | svn:r18422
* Fix typo found by Justin Coffi on or-talkNick Mathewson2009-01-23
| | | | svn:r18258
* Support 64-bit time_t. Patch from Matthias Drochner. Partial backport ↵Nick Mathewson2009-01-22
| | | | | | candidate. svn:r18234
* Make sure that even in the weird fiddly paths that lead to init_keys,Nick Mathewson2009-01-21
| | | | | | | | | | crypto_global_init gets called. Also have it be crypto_global_init that calls crypto_seed_rng, so we are not dependent on OpenSSL's RAND_poll in these fiddly cases. Should fix bug 907. Bugfix on 0.0.9pre6. Backport candidate. svn:r18210
* Fix an error in tor_addr_parse that kept us from having a hidden service or ↵Nick Mathewson2009-01-21
| | | | | | a bridge live at an IPv6 address. svn:r18206
* Fix warning on panther compile, and bug 913. Backport candidate.Nick Mathewson2009-01-21
| | | | svn:r18203
* Add a better (non-locale-having) ctypes implementation to avoid protocol and ↵Nick Mathewson2009-01-20
| | | | | | parsing mismatches on different platforms. svn:r18189
* Fix up (I hope) most ot the things that coverity suddenly claimed were ↵Nick Mathewson2009-01-13
| | | | | | REVERSE_INULL. This is what we get for bragging about being down to 0 issues. svn:r18096
* Fix a leak memory on the failing case of test_memeq_hexNick Mathewson2009-01-13
| | | | svn:r18094
* Fix a harmless-to-us bug in ht.h.Nick Mathewson2009-01-10
| | | | | | There was a field that _HT_FOI_INSERT was never setting. Everything that calls _HT_FOI_INSERT was setting it via tor_malloc_zero, but that's fragile. svn:r18064
* Note a problem in the interface tor_addr_to_sockaddr.Nick Mathewson2009-01-06
| | | | svn:r17982
* Another fun openbsd warning fix. On ioerror's computer at least, they ↵Nick Mathewson2009-01-04
| | | | | | redefined an unsigned field in zlib.h to be signed. I am quite sure this makes me more secure somehow. svn:r17892
* OpenBSD malloc.h believes that you should be able to detect headers with ↵Nick Mathewson2009-01-04
| | | | | | autoconf, or build without warnings, but not both. So never include malloc.h on OpenBSD. Backport candidate. svn:r17891
* Fix the oldest bug in a while: stop accepting 1.2.3 as a valid IPv4 address ↵Nick Mathewson2009-01-04
| | | | | | on any platform. svn:r17887
* Remove svn $Id$s from our source, and remove tor --version --version.Nick Mathewson2009-01-04
| | | | | | | | The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867
* Only set sin_len/sin6_len when they exist.Nick Mathewson2009-01-02
| | | | svn:r17851
* Try harder to make sure we zero-out the extraneous sockaddr fields and that ↵Nick Mathewson2009-01-02
| | | | | | we set sockaddr_len. Conceivably a backport candidate, though nothing has yet been sen to break. svn:r17849
* Remove some code that is #ifdefed out, and that we no longer seem to use, if ↵Nick Mathewson2008-12-30
| | | | | | we ever did. svn:r17827
* Use a consistent naming standard for header file guard macros, taking care ↵Nick Mathewson2008-12-29
| | | | | | not to collide with any system headers. This tripped us up on Android. svn:r17805
* Use RSA_generate_key_ex where available.Nick Mathewson2008-12-29
| | | | svn:r17804
* Fix bug in recent address.c patch: actually set the value of address * to ↵Nick Mathewson2008-12-29
| | | | | | 0.0.0.0 as we did before. This makes CMP_EXACT comparisons with bitmask 0 work on address * again. svn:r17801
* Fix compilation under gethostbyname-based systems.Nick Mathewson2008-12-27
| | | | svn:r17800
* Refactor tor_addr_t manipulation functions so that as few as possible look ↵Nick Mathewson2008-12-26
| | | | | | at the tor_addr_t representation. svn:r17790
* get_interface_addr6(), and by extension get_interface_addr(), were pretty ↵Nick Mathewson2008-12-26
| | | | | | borked. Copying a tor_addr_t from a sockaddr_storage using memcpy is a poor notion. svn:r17789
* Refactor tor_addr_compare_masked() so that CMP_SEMANTIC makes more sense, ↵Nick Mathewson2008-12-26
| | | | | | and has decent semantics for maskbits; and so that CMP_EXACT works right for bits==0. svn:r17788
* Document our Bloom filter parameter choices.Nick Mathewson2008-12-26
| | | | svn:r17785
* Add more missing documentation, and correct an error in container.c ↵Nick Mathewson2008-12-26
| | | | | | documentation: Don't introduce two parameters called n when you're calling an algorithm O(n). svn:r17783
* some fixes i found in my sandboxRoger Dingledine2008-12-25
| | | | svn:r17771
* Document most undocumented variables.Nick Mathewson2008-12-23
| | | | svn:r17754
* Properly zero-out addresses when setting them. Probably this was not ↵Nick Mathewson2008-12-23
| | | | | | hurting anything. svn:r17749
* Make freelist_len in memarea.c static; document a few variables.Nick Mathewson2008-12-22
| | | | svn:r17741
* Add DOCDOC entries for undocumented static and global variables.Nick Mathewson2008-12-22
| | | | svn:r17739
* Fix most DOCDOCs remaining and/or added by redox.Nick Mathewson2008-12-22
| | | | svn:r17734
* Add DOCDOC comments for all undocumented functions. Add missing *s to other ↵Nick Mathewson2008-12-22
| | | | | | comments so that they will get recognized as doxygen. svn:r17729