aboutsummaryrefslogtreecommitdiff
path: root/src/common
Commit message (Expand)AuthorAge
* Fix compile error in procmon.c•••An elusive compile-error (MingW-gcc v4.50 on Win_XP); a missing comma (!) and a typo ('err_msg' at line 277 changed to 'errmsg'). Aso changed the format for 'err_code' at line 293 into a "%ld" to suppress a warning. How did this go unnoticed for ~1 month? Btw. This is my 1st ever 'git commit', so it better work. Gisle2011-06-01
* whitespace fixesNick Mathewson2011-05-30
* Merge remote-tracking branch 'public/bug3270' into maint-0.2.2Nick Mathewson2011-05-30
|\
| * Use a 64-bit type to hold sockets on win64.•••On win64, sockets are of type UINT_PTR; on win32 they're u_int; elsewhere they're int. The correct windows way to check a socket for being set is to compare it with INVALID_SOCKET; elsewhere you see if it is negative. On Libevent 2, all callbacks take sockets as evutil_socket_t; we've been passing them int. This patch should fix compilation and correctness when built for 64-bit windows. Fixes bug 3270. Nick Mathewson2011-05-23
* | Unbreak the build on libevent 1.x systemsRobert Ransom2011-05-22
* | Merge branch 'feature3049-v2' into maint-0.2.2•••Conflicts: src/common/Makefile.am Nick Mathewson2011-05-23
|\ \ | |/ |/|
| * The first argument for a libevent callback should be evutil_socket_tNick Mathewson2011-05-23
| * Appease make check-spaces wrt procmon.hNick Mathewson2011-05-23
| * Fix some commentsRobert Ransom2011-05-20
| * Implement __OwningControllerProcess option•••Implements part of feature 3049. Robert Ransom2011-05-20
| * Improve a documentation commentRobert Ransom2011-05-12
| * Fix comment typoRobert Ransom2011-05-12
| * Fix comment typoRobert Ransom2011-05-10
* | what's up with this trailing whitespaceRoger Dingledine2011-05-20
* | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2•••Fixed trivial conflict due to headers moving into their own .h files from or.h. Conflicts: src/or/or.h Nick Mathewson2011-05-16
|\ \
| * | squash! Add crypto_pk_check_key_public_exponent function•••Rename crypto_pk_check_key_public_exponent to crypto_pk_public_exponent_ok: it's nice to name predicates s.t. you can tell how to interpret true and false. Nick Mathewson2011-05-16
| * | Add crypto_pk_check_key_public_exponent functionRobert Ransom2011-05-16
* | | Increase the length of the buffer in smartlist_string_num_isin().•••This was harmless, since we only used this for checking for lists of port values, but it's the principle of the thing. Fixes 3175; bugfix on 0.1.0.1-rc Nick Mathewson2011-05-15
* | | Make check_private_dir check for group ownership as appropriateNick Mathewson2011-05-15
* | | Fix up some comment issues spotted by rransomNick Mathewson2011-05-15
* | | Add a new flag to check_private_dir to make it _not_ change permissions•••We'll need this for checking permissions on the directories that hold control sockets: if somebody says "ControlSocket ~/foo", it would be pretty rude to do a chmod 700 on their homedir. Nick Mathewson2011-05-15
* | | Add a function to pull off the final component of a pathNick Mathewson2011-05-15
* | | Make check_private_dir accept g+rx dirs if told to do so.Nick Mathewson2011-05-15
* | | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2•••Conflicts: src/or/networkstatus.c Nick Mathewson2011-05-15
|\| |
| * | Fixup whitespace issues from 3122 commitNick Mathewson2011-05-15
* | | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson2011-05-15
|\| |
| * | Another doc tweak on tor_memcmp: <b>b</b>, not <b>.Nick Mathewson2011-05-15
| * | minor tweaks to 4b19730c8234dRoger Dingledine2011-05-15
* | | New smartlist function to see if two lists of strings are equal.•••We'll use this to detect changes in CSV options. Nick Mathewson2011-05-13
* | | Add a new "tor_sockaddr_to_str()" function•••It does what it says on the tin. It turns out I'll want this in a couple of places. Nick Mathewson2011-05-13
* | | Re-apply the automated conversion to 0.2.2 to make handle any memcmps that sn...Nick Mathewson2011-05-11
* | | Merge remote-tracking branch 'public/3122_memcmp_squashed' into bug3122_memcm...•••Conflicts throughout. All resolved in favor of taking HEAD and adding tor_mem* or fast_mem* ops as appropriate. src/common/Makefile.am src/or/circuitbuild.c src/or/directory.c src/or/dirserv.c src/or/dirvote.c src/or/networkstatus.c src/or/rendclient.c src/or/rendservice.c src/or/router.c src/or/routerlist.c src/or/routerparse.c src/or/test.c Nick Mathewson2011-05-11
|\| | | |/ |/|
| * Hand-conversion and audit phase of memcmp transition•••Here I looked at the results of the automated conversion and cleaned them up as follows: If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I changed it to a fast_memcmp or fast_memeq. Otherwise if there was a tor_memcmp that could turn into a tor_memneq or tor_memeq, I converted it. This wants close attention. [*] I'm erring on the side of caution here, and leaving some things as tor_memcmp that could in my opinion use the data-dependent fast_memcmp variant. Nick Mathewson2011-05-11
| * Automated conversion of memcmp to tor_memcmp/tor_mem[n]eq•••This commit is _exactly_ the result of perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch] perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch] perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch] git checkout src/common/di_ops.[ch] git checkout src/or/test.c git checkout src/common/test.h Nick Mathewson2011-05-11
| * Add a "di_ops.h" include to util.hNick Mathewson2011-05-11
| * Add a data-independent variant of memcmp and a d-i memeq function.•••The tor_memcmp code is by Robert Ransom, and the tor_memeq code is by me. Both incorporate some ideas from DJB's stuff. Nick Mathewson2011-05-11
* | Fix up some check-spaces issuesNick Mathewson2011-05-05
* | Correct the logic from f14754fbd for tor_gmtime_rJohn Brooks2011-04-28
* | Detect and handle NULL returns from (gm/local)time_r•••These functions can return NULL for otherwise-valid values of time_t. Notably, the glibc gmtime manpage says it can return NULL if the year if greater than INT_MAX, and the windows MSDN gmtime page says it can return NULL for negative time_t values. Also, our formatting code is not guaranteed to correctly handle years after 9999 CE. This patch tries to correct this by detecting NULL values from gmtime/localtime_r, and trying to clip them to a reasonable end of the scale. If they are in the middle of the scale, we call it a downright error. Arguably, it's a bug to get out-of-bounds dates like this to begin with. But we've had bugs of this kind in the past, and warning when we see a bug is much kinder than doing a NULL-pointer dereference. Boboper found this one too. Nick Mathewson2011-04-28
* | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2•••Conflicts: src/common/torint.h Nick Mathewson2011-04-27
|\|
| * Make SIZE_T_CEILING unsigned; add a signed SSIZE_T_CEILING•••None of the comparisons were _broken_ previously, but avoiding signed/unsigned comparisons makes everybody happier. Fixes bug2475. Nick Mathewson2011-04-26
| * Make the DH parameter we use for TLS match the one from Apache's mod_ssl•••Our regular DH parameters that we use for circuit and rendezvous crypto are unchanged. This is yet another small step on the path of protocol fingerprinting resistance. (Backport from 0.2.2's 5ed73e3807d90dd0a3) Nick Mathewson2011-02-10
* | Standardize our printf code on %d, not %i.Nick Mathewson2011-04-19
* | Free pending_cb_messages on exitNick Mathewson2011-04-07
* | Merge remote-tracking branch 'public/xxx_fixups' into maint-0.2.2•••Conflicts: src/or/or.h Nick Mathewson2011-04-07
|\ \
| * | Improve a few commentsSebastian Hahn2011-03-28
| * | Triage the XXX022 and XXX021 comments remaining in the code•••Remove some, postpone others, leave some alone. Now the only remaining XXX022s are ones that seem important to fix or investigate. Nick Mathewson2011-03-25
| * | Comment out ancient asserts for bug 930; resolve an xxx021Nick Mathewson2011-03-25
| * | Fixup tor_addr_to_sockaddr return conventionNick Mathewson2011-03-25
| * | Clean up a comment-conversation about bad libevent version/method combosNick Mathewson2011-03-25
generated by cgit v1.2.3 (git 2.48.1) at 2025-04-13 12:24:10 +0000