| Commit message (Collapse) | Author | Age |
|---|
| |\
| |
| |
| |
| |
| | |
Conflicts:
src/common/compat.c
src/or/main.c
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On win64, sockets are of type UINT_PTR; on win32 they're u_int;
elsewhere they're int. The correct windows way to check a socket for
being set is to compare it with INVALID_SOCKET; elsewhere you see if
it is negative.
On Libevent 2, all callbacks take sockets as evutil_socket_t; we've
been passing them int.
This patch should fix compilation and correctness when built for
64-bit windows. Fixes bug 3270.
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/common/Makefile.am
src/or/control.c
|
| | |\ \
| | |/
| |/|
| | |
| | | |
Conflicts:
src/common/Makefile.am
|
| | | | |
|
| |\| | |
|
| | | | |
|
| |\| | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
We'll need this for checking permissions on the directories that hold
control sockets: if somebody says "ControlSocket ~/foo", it would be
pretty rude to do a chmod 700 on their homedir.
|
| | | | |
|
| |\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts in various places, mainly node-related. Resolved them in
favor of HEAD, with copying of tor_mem* operations from bug3122_memcmp_022.
src/common/Makefile.am
src/or/circuitlist.c
src/or/connection_edge.c
src/or/directory.c
src/or/microdesc.c
src/or/networkstatus.c
src/or/router.c
src/or/routerlist.c
src/test/test_util.c
|
| | |\ \
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
bug3122_memcmp_022
Conflicts throughout. All resolved in favor of taking HEAD and
adding tor_mem* or fast_mem* ops as appropriate.
src/common/Makefile.am
src/or/circuitbuild.c
src/or/directory.c
src/or/dirserv.c
src/or/dirvote.c
src/or/networkstatus.c
src/or/rendclient.c
src/or/rendservice.c
src/or/router.c
src/or/routerlist.c
src/or/routerparse.c
src/or/test.c
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Here I looked at the results of the automated conversion and cleaned
them up as follows:
If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I
changed it to a fast_memcmp or fast_memeq.
Otherwise if there was a tor_memcmp that could turn into a
tor_memneq or tor_memeq, I converted it.
This wants close attention.
[*] I'm erring on the side of caution here, and leaving some things
as tor_memcmp that could in my opinion use the data-dependent
fast_memcmp variant.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit is _exactly_ the result of
perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch]
perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch]
git checkout src/common/di_ops.[ch]
git checkout src/or/test.c
git checkout src/common/test.h
|
| | | |
| | |
| | |
| | |
| | | |
It was the start of a neat idea, but it only got used in 3 places,
none of which really needed it.
|
| |\| | |
|
| | |\| |
|
| | | |
| | |
| | |
| | | |
Spotted by doors, fixes bug 2326.
|
| |\| | |
|
| | |\| |
|
| | | |
| | |
| | |
| | | |
Fixes bug 2324.
|
| |\| | |
|
| | |\|
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/common/test.h
src/or/test.c
|
| | | | |
|
| |\| | |
|
| | |\|
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/common/memarea.c
src/or/or.h
src/or/rendclient.c
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It's all too easy in C to convert an unsigned value to a signed one,
which will (on all modern computers) give you a huge signed value. If
you have a size_t value of size greater than SSIZE_T_MAX, that is way
likelier to be an underflow than it is to be an actual request for
more than 2gb of memory in one go. (There's nothing in Tor that
should be trying to allocate >2gb chunks.)
|
| | | |
| | |
| | |
| | |
| | | |
This wasn't working due to the parameters of dup2 being in the wrong order.
As a result, tor-fw-helper was inheriting the stdin of Tor.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Still to go: some pipes, all stdio files.
|
| | | | |
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Some of these functions only work for routerinfo-based nodes, and as
such are only usable for advisory purposes. Fortunately, our uses
of them are compatible with this limitation.
|
| |\ \ \ \ |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Test sucessfully starting a process
- Test failing to find the executable
|
| | | | | |
| | | | |
| | | | |
| | | | | |
- Include description of stdout_read, stderr_read, and argv
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Replace sscanf with tor_sscanf
- Replace use of strstr with equivalent call to strcmpstart
|
| | | | | |
| | | | |
| | | | |
| | | | | |
- Use log_warn rather than log_err for bad but survivable events
|
| | | | | |
| | | | |
| | | | |
| | | | | |
- To be dealt with as part of bug #2029
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Responsibility of clearing hex_errno is no longer with caller
- More conservative bounds checking
- Length requirement of hex_errno documented
- Output format documented
|
| |/ / / |
|
| | | | |
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Conflicts:
src/common/util.c
|
| | | | |
|
| | | | |
|
| | | | |
|