aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix (Open?)BSD fast-connect bug with optimistic data.Nick Mathewson2013-06-10
| | | | | | | | | | | | | | | There's an assertion failure that can occur if a connection has optimistic data waiting, and then the connect() call returns 0 on the first attempt (rather than -1 and EINPROGRESS). That latter behavior from connect() appears to be an (Open?)BSDism when dealing with remote addresses in some cases. (At least, I've only seen it reported with the BSDs under libevent, even when the address was 127.0.0.1. And we've only seen this problem in Tor with OpenBSD.) Fixes bug 9017; bugfix on 0.2.3.1-alpha, which first introduced optimistic data. (Although you could also argue that the commented-out connection_start_writing in 155c9b80 back in 2002 is the real source of the issue.)
* Merge branch 'bug8844_v2' into maint-0.2.3Nick Mathewson2013-05-09
|\
| * Don't run off the end of the array-of-freelistsNick Mathewson2013-05-09
|/ | | | | | | | | | | | | This is a fix for bug 8844, where eugenis correctly notes that there's a sentinel value at the end of the list-of-freelists that's never actually checked. It's a bug since the first version of the chunked buffer code back in 0.2.0.16-alpha. This would probably be a crash bug if it ever happens, but nobody's ever reported something like this, so I'm unsure whether it can occur. It would require write_to_buf, write_to_buf_zlib, read_to_buf, or read_to_buf_tls to get an input size of more than 32K. Still, it's a good idea to fix this kind of thing!
* Avoid busy-looping on WANTREAD within connection_handle_writeNick Mathewson2013-04-12
| | | | | Fix for bug 5650. Also, if we get a WANTREAD while reading while writing, make sure we're reading.
* Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-04-08
|\
| * Update to the April 2013 GeoIP database.Karsten Loesing2013-04-08
| |
* | Merge remote-tracking branch 'public/bug8377' into maint-0.2.3Nick Mathewson2013-03-18
|\ \
| * | Add unit test for tor_addr_is_loopbackNick Mathewson2013-03-01
| | |
| * | Make sure that [::1] is recognized as a private addressNick Mathewson2013-03-01
| | | | | | | | | | | | Fixes bug 8377; bugfix on 0.2.1.3-alpha.
* | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-03-11
|\ \ \ | |/ / |/| / | |/
| * Update to the March 2013 GeoIP database.Karsten Loesing2013-03-07
| |
* | oops; add a missing semicolonNick Mathewson2013-02-12
| | | | | | | | (Cherry-picked from fc35ee4910326dc1ae718482b30e57666a71df85)
* | Check whether ei is non-NULL before altering it.Nick Mathewson2013-02-11
| | | | | | | | | | | | | | This fixes a crash bug if we fail to generate an extrainfo descriptor. Fixes bug 8208; bugfix on 0.2.3.16-alpha.
* | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-02-08
|\|
| * Update to the February 2013 GeoIP database.Karsten Loesing2013-02-08
| |
* | Merge branch 'bug7889_023' into maint-0.2.3Nick Mathewson2013-01-15
|\ \
| * | Reject create/begin/etc cells with {circ,stream}ID 0.Nick Mathewson2013-01-14
| | | | | | | | | | | | | | | | | | | | | | | | Otherwise, it's possible to create streams or circuits with these bogus IDs, leading to orphaned circuits or streams, or to ones that can cause bandwidth DOS problems. Fixes bug 7889; bugfix on all released Tors.
* | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-01-14
|\ \ \ | |/ / |/| / | |/
| * Update to the January 2013 GeoIP database.Karsten Loesing2013-01-05
| |
* | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2012-12-13
|\|
| * Add link explaining how the geoip file was created.Karsten Loesing2012-12-13
| |
| * Update to the December 2012 GeoIP database.Karsten Loesing2012-12-13
| |
| * Update to the November 2012 GeoIP database.Karsten Loesing2012-12-13
| |
* | use a more logical operatorRoger Dingledine2012-11-12
| | | | | | | | | | | | | | Fix a harmless bug when opting against publishing a relay descriptor because DisableNetwork is set. Fixes bug 7464; bugfix on 0.2.3.9-alpha.
* | Turn a memwipe in tor_process_handle_destroy() back to memsetNick Mathewson2012-11-08
| | | | | | | | | | It broke linking on tor-resolve.c, and it's not actually sanitizing anything sensitive. Fix for bug 7420; bug not on ony released Tor.
* | Merge branch 'bug7352_023_rebased' into maint-0.2.3Nick Mathewson2012-11-08
|\ \
| * | Add and use and unlikely-to-be-eliminated memwipe()Nick Mathewson2012-11-08
|/ / | | | | | | | | | | | | | | | | | | Apparently some compilers like to eliminate memset() operations on data that's about to go out-of-scope. I've gone with the safest possible replacement, which might be a bit slow. I don't think this is critical path in any way that will affect performance, but if it is, we can work on that in 0.2.4. Fixes bug 7352.
* | Fix a remotely triggerable assertion failure (CVE-2012-2250)Nick Mathewson2012-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | If we completed the handshake for the v2 link protocol but wound up negotiating the wong protocol version, we'd become so confused about what part of the handshake we were in that we'd promptly die with an assertion. This is a fix for CVE-2012-2250; it's a bugfix on 0.2.3.6-alpha. All servers running that version or later should really upgrade. Bug and fix from "some guy from France." I tweaked his code slightly to make it log the IP of the offending node.
* | Make unit test for bug7191 work with new smartlist_new() nameNick Mathewson2012-10-23
| |
* | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2012-10-23
|\|
| * Add some unit tests for smartlist_bsearch_idx() on short listsAndrea Shepard2012-10-23
| | | | | | | | | | Conflicts: src/test/test_containers.c
| * Add a changes file for bug 7191.Nick Mathewson2012-10-23
| |
| * Fix binary search on lists of 0 or 1 element.Nick Mathewson2012-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation we added has a tendency to crash with lists of 0 or one element. That can happen if we get a consensus vote, v2 consensus, consensus, or geoip file with 0 or 1 element. There's a DOS opportunity there that authorities could exploit against one another, and which an evil v2 authority could exploit against anything downloading v2 directory information.. This fix is minimalistic: It just adds a special-case for 0- and 1-element lists. For 0.2.4 (the current alpha series) we'll want a better patch. This is bug 7191; it's a fix on 0.2.0.10-alpha.
* | Let 0.2.3 clients exit to internal addresses if they wantRoger Dingledine2012-10-23
| | | | | | | | | | | | | | Clients now consider the ClientRejectInternalAddresses config option when using a microdescriptor consensus stanza to decide whether an exit relay would allow exiting to an internal address. Fixes bug 7190; bugfix on 0.2.3.1-alpha.
* | Fix parse_short_policy (bug 7192.)Nick Mathewson2012-10-23
| | | | | | | | | | | | | | | | | | | | | | Our implementation of parse_short_policy was screwed up: it would ignore the last character of every short policy. Obviously, that's broken. This patch fixes the busted behavior, and adds a bunch of unit tests to make sure the rest of that function is okay. Fixes bug 7192; fix on 0.2.3.1-alpha.
* | add a unit test to expose bug 7192Roger Dingledine2012-10-22
| |
* | Merge branch 'block_renegotiate_023' into maint-0.2.3Nick Mathewson2012-10-19
|\ \
| * | Discard extraneous renegotiation attempts in the v3 link protocolNick Mathewson2012-10-17
| | | | | | | | | | | | | | | | | | Failure to do so left us open to a remotely triggerable assertion failure. Fixes CVE-2012-2249; bugfix on 0.2.3.6-alpha. Reported by "some guy from France".
* | | Merge branch 'bug7149' into maint-0.2.3Nick Mathewson2012-10-19
|\ \ \
| * | | Don't serve or accept v2 HS descs over a DirPortRobert Ransom2012-10-19
|/ / / | | | | | | | | | (changes file tweaked by nickm)
* | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2012-10-19
|\ \ \ | |/ / |/| / | |/
| * Disable TLS Session Tickets, which we were apparently getting for freeNick Mathewson2012-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OpenSSL 1.0.0 added an implementation of TLS session tickets, a "feature" that let session resumption occur without server-side state by giving clients an encrypted "ticket" that the client could present later to get the session going again with the same keys as before. OpenSSL was giving the keys to decrypt these tickets the lifetime of the SSL contexts, which would have been terrible for PFS if we had long-lived SSL contexts. Fortunately, we don't. Still, it's pretty bad. We should also drop these, since our use of the extension stands out with our non-use of session cacheing. Found by nextgens. Bugfix on all versions of Tor when built with openssl 1.0.0 or later. Fixes bug 7139.
* | Merge branch 'bug7014_023_squashed' into maint-0.2.3Nick Mathewson2012-10-09
|\ \
| * | Don't call fmt_addr() twice in a parameter list.George Kadianakis2012-10-09
|/ /
* | Merge remote-tracking branch 'arma/bug7037' into maint-0.2.3Nick Mathewson2012-10-04
|\ \
| * | Refuse extra create cells with reason "resource limit"Roger Dingledine2012-10-03
| | | | | | | | | | | | | | | In the past we had used reason "internal", which is more vague than it needs to be. Resolves bug 7037.
* | | properly free the return values of rate_limit_log()Roger Dingledine2012-10-03
|/ / | | | | | | resolves bug 7022.
* | add faravahar as our ninth v3 dir authRoger Dingledine2012-09-22
| |
* | Clarify that hidden services are TCP onlyNick Mathewson2012-09-19
| | | | | | | | | | | | Also remove some trailing whitespace. Patch from maker; fixes bug 6024.
* | Whitespace fixesNick Mathewson2012-09-18
| |