aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge remote-tracking branch 'public/bug8822' into maint-0.2.4Nick Mathewson2013-06-13
|\
| * Make all consumers of microdesc_t.body tolerate NULLNick Mathewson2013-06-12
| | | | | | | | This is another fix to try to mitigate recurrences of 8031/8822.
| * Unmap the microdescriptor cache before replacing it.Nick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reprise of the fix in bdff7e3299d78; 6905c1f6 reintroduced that bug. Briefly: windows doesn't seem to like deleting a mapped file. I tried adding the PROT_SHARED_DELETE flag to the createfile all, but that didn't actually fix this issue. Fortunately, the unit test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should prevent us from making this particular screw-up again. This patch also tries to limit the crash potential of a failure to write by a little bit, although it could do a better job of retaining microdescriptor bodies. Fix for bug 8822, bugfix on 0.2.4.12-alpha.
* | Fix the biggest errors in doc/HACKINGNick Mathewson2013-06-12
| | | | | | | | We can wait for 0.2.5 for a full rewrite. #8964
* | Remove various outdated documents.Nick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | doc/TODO and doc/spec/README were placeholders to tell people where to look for the real TODO and README stuff -- we replaced them years ago, though. authority-policy, v3-authority-howto, and torel-design.txt belong in torspec. I'm putting them in attic there since I think they may be in large part obsolete, but someone can rescue them if they're not. translations.txt is outdated, and refers to lots of programs other than Tor. We have much better translation resources on the website now. tor-win32-mingw-creation.txt is pending review of a revised version for 0.2.5 (see ticket #4520), but there's no reason to ship this one while we're waiting for an accurate version. the tor-rpm-creation.txt isn't obsolete AFAIK, but it belongs in doc/contrib if anywhere. Resolves bug #8965.
* | Merge remote-tracking branch 'andrea/bug8639_v3' into maint-0.2.4Nick Mathewson2013-06-12
|\ \ | |/ |/|
| * When launching a resolve request on behalf of an AF_UNIX control, omit the ↵Andrea Shepard2013-05-31
| | | | | | | | address field of the new entry connection. Fixes bug 8639.
* | Revert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping"Nick Mathewson2013-06-12
| | | | | | | | | | | | | | This reverts commit 884a0e269c382f9e927d8c8b1ef4ef9d2d48379d. I'm reverting this because it doesn't actually make the problem go away. It appears that instead we need to do unmap-then-replace.
* | Merge remote-tracking branch 'public/bug2077_share_delete' into maint-0.2.4Nick Mathewson2013-06-12
|\ \
| * | Use the FILE_SHARE_DELETE flag for CreateFile on a mappingNick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A comment by rransom on #8795 taken together with a comment by doorss recorded on #2077 suggest that *every* attempt to replace the md cache will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag passed to CreateFile, and if we try to replace the file ourselves before unmapping it. I'm adding the FILE_SHARE_DELETE, since that's this simplest fix. Broken indexers (the favored #2077 hypothesis) could still cause trouble here, but at least this patch should make us stop stepping on our own feet. Likely fix for #2077 and its numerous duplicates. Bugfix on 0.2.2.6-alpha, which first had a microdescriptor cache that would get replaced before remapping it.
* | | Expand microdesc cache testsNick Mathewson2013-06-12
| | | | | | | | | | | | | | | | | | | | | Is it possible that *every* attempt to replace the microdesc cache on windows 7 is going to fail because of our lack of FILE_SHARE_DELETE while opening the file? If so, this test will catch #2077 and let us know when it's fixed.
* | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-10
|\| |
| * | Merge branch 'bug9017' into maint-0.2.3Nick Mathewson2013-06-10
| |\ \
| | * | Fix (Open?)BSD fast-connect bug with optimistic data.Nick Mathewson2013-06-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's an assertion failure that can occur if a connection has optimistic data waiting, and then the connect() call returns 0 on the first attempt (rather than -1 and EINPROGRESS). That latter behavior from connect() appears to be an (Open?)BSDism when dealing with remote addresses in some cases. (At least, I've only seen it reported with the BSDs under libevent, even when the address was 127.0.0.1. And we've only seen this problem in Tor with OpenBSD.) Fixes bug 9017; bugfix on 0.2.3.1-alpha, which first introduced optimistic data. (Although you could also argue that the commented-out connection_start_writing in 155c9b80 back in 2002 is the real source of the issue.)
* | | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-06-05
|\| | |
| * | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-06-05
| |\ \ \
| | * | | Update to the June 2013 GeoIP database.Karsten Loesing2013-06-05
| | | | |
* | | | | Fix two cut'n'paste docu bugs.Linus Nordberg2013-06-05
| |_|_|/ |/| | |
* | | | Downgrade the unexpected sendme cell warnings for 0.2.4Nick Mathewson2013-05-21
| | | | | | | | | | | | | | | | See discussion on #8093
* | | | Copy-paste description of PathBias params from man page to or.h commentAndrea Shepard2013-05-20
| | | |
* | | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-05-20
|\| | |
| * | | Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3Nick Mathewson2013-05-20
| |\| | | | |/ | |/|
| | * Update to the May 2013 GeoIP database.Karsten Loesing2013-05-13
| | |
* | | Fix bug 8846: better log message on IP version confusionNick Mathewson2013-05-17
| | |
* | | Fix unit tests to pass after fix for #8879Nick Mathewson2013-05-15
| | |
* | | Fix socks5 handshake for username/password authRoger Dingledine2013-05-15
| | | | | | | | | | | | | | | The fix for bug 8117 exposed this bug, and it turns out real-world applications like Pidgin do care. Bugfix on 0.2.3.2-alpha; fixes bug 8879.
* | | Merge bug5595-v2-squashed into maint-0.2.4Andrea Shepard2013-05-10
|\ \ \
| * | | Add some unit tests for fp_pair_map_t to test/containers.c based on the ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | strmap tests
| * | | Rephrase comment in trusted_dirs_load_certs_from_string() to reflect 5595 fixAndrea Shepard2013-05-09
| | | |
| * | | Make warning in authority_cert_dl_failed() LD_BUG per NickM code reviewAndrea Shepard2013-05-09
| | | |
| * | | Use tor_asprintf() and clean up string handling in ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | authority_certs_fetch_missing()
| * | | Clean up ugly constants in connection_dir_download_cert_failed(), and fix a ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | broken one
| * | | Avoid duplicate downloads by (fp,sk) and by fp for authority certs when ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | bootstrapping
| * | | When downloading certificates, distinguish requesting by identity digest ↵Andrea Shepard2013-05-09
| | | | | | | | | | | | | | | | from requesting by ID digest, signing key pair; fixes bug 5595
| * | | Implement fp_pair_map_tAndrea Shepard2013-05-09
| |/ /
* | | Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4Nick Mathewson2013-05-09
|\| |
| * | Merge branch 'bug8844_v2' into maint-0.2.3Nick Mathewson2013-05-09
| |\ \
| | * | Don't run off the end of the array-of-freelistsNick Mathewson2013-05-09
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a fix for bug 8844, where eugenis correctly notes that there's a sentinel value at the end of the list-of-freelists that's never actually checked. It's a bug since the first version of the chunked buffer code back in 0.2.0.16-alpha. This would probably be a crash bug if it ever happens, but nobody's ever reported something like this, so I'm unsure whether it can occur. It would require write_to_buf, write_to_buf_zlib, read_to_buf, or read_to_buf_tls to get an input size of more than 32K. Still, it's a good idea to fix this kind of thing!
* | | Fix bug 8845: check the right length of memory in aes unit testsNick Mathewson2013-05-08
| | | | | | | | | | | | | | | This couldn't actually be a buffer overrun unless AES somehow turned into memcpy, but still it's good to fix it.
* | | Use a clearer idiom for node identity in router_counts_toward_thresholdsNick Mathewson2013-05-05
| | |
* | | Fix 8833: crash bug from using NULL node->ri in dirserv.cNick Mathewson2013-05-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | It appears that moria1 crashed because of one instance of this (the one in router_counts_toward_thresholds). The other instance I fixed won't actually have broken anything, but I think it's more clear this way. Fixes bug 8833; bugfix on 0.2.4.12-alpha.
* | | Merge remote-tracking branch 'public/bug6026' into maint-0.2.4Nick Mathewson2013-04-24
|\ \ \
| * | | Treat a changed IPv6 ORPort like an IPv4 one in retry_all_listeners()Nick Mathewson2013-03-11
| | | | | | | | | | | | | | | | Fix for bug 6026
* | | | Merge branch 'bug8235-fix-rebased' into maint-0.2.4Nick Mathewson2013-04-24
|\ \ \ \
| * | | | Increase the pathbias state file miscounting version check.Mike Perry2013-04-24
| | | | | | | | | | | | | | | | | | | | | | | | | We now know the bug is present in 0.2.4.12-alpha too. It should be fixed in 0.2.4.13-alpha, though.
| * | | | Changes file for 8235.Mike Perry2013-04-24
| | | | |
| * | | | Bug 8235: Fix scaling adjustments.Mike Perry2013-04-24
|/ / / / | | | | | | | | | | | | | | | | | | | | We need to subtract both the current built circuits *and* the attempted circuits from the attempt count during scaling, since *both* have already been counted there.
* | | | Add a boolean to flag-thresholds for "we have enough measured bandwidth"Nick Mathewson2013-04-18
| | | | | | | | | | | | | | | | Implements #8711.
* | | | Merge remote-tracking branch 'public/bug8716_023' into maint-0.2.4Nick Mathewson2013-04-18
|\ \ \ \
| * | | | Fix memory leak when sending configuration-changed eventNick Mathewson2013-04-17
| | | | | | | | | | | | | | | | | | | | Fix for bug #8718; bugfix on 0.2.3.3-alpha.