aboutsummaryrefslogtreecommitdiff
path: root/src/or
diff options
context:
space:
mode:
authorGeorge Kadianakis <desnacked@riseup.net>2012-05-18 15:04:48 +0300
committerGeorge Kadianakis <desnacked@riseup.net>2012-05-18 15:04:48 +0300
commita8a862c90989e8d81bcebab5bbe63d4984d00b96 (patch)
treef9f6ff1b4e94d5c35b05d29810fc15a040d93680 /src/or
parentf00a8b430709aff3045fe20e3f776858e0ec79ae (diff)
downloadtor-a8a862c90989e8d81bcebab5bbe63d4984d00b96.tar
tor-a8a862c90989e8d81bcebab5bbe63d4984d00b96.tar.gz
Ignore unknown lines from managed proxies.
Diffstat (limited to 'src/or')
-rw-r--r--src/or/transports.c13
1 files changed, 2 insertions, 11 deletions
diff --git a/src/or/transports.c b/src/or/transports.c
index 5f650d107..a20decfc0 100644
--- a/src/or/transports.c
+++ b/src/or/transports.c
@@ -119,10 +119,6 @@ static INLINE void free_execve_args(char **arg);
#define PROTO_CMETHODS_DONE "CMETHODS DONE"
#define PROTO_SMETHODS_DONE "SMETHODS DONE"
-/* The smallest valid managed proxy protocol line that can
- appear. It's the size of "VERSION 1" */
-#define SMALLEST_MANAGED_LINE_SIZE 9
-
/** Number of environment variables for managed proxy clients/servers. */
#define ENVIRON_SIZE_CLIENT 3
#define ENVIRON_SIZE_SERVER 7 /* XXX known to be too high, but that's ok */
@@ -633,12 +629,6 @@ handle_proxy_line(const char *line, managed_proxy_t *mp)
log_info(LD_GENERAL, "Got a line from managed proxy '%s': (%s)",
mp->argv[0], line);
- if (strlen(line) < SMALLEST_MANAGED_LINE_SIZE) {
- log_warn(LD_GENERAL, "Managed proxy configuration line is too small. "
- "Discarding");
- goto err;
- }
-
if (!strcmpstart(line, PROTO_ENV_ERROR)) {
if (mp->conf_state != PT_PROTO_LAUNCHED)
goto err;
@@ -712,7 +702,8 @@ handle_proxy_line(const char *line, managed_proxy_t *mp)
return;
}
- log_warn(LD_CONFIG, "Unknown line received by managed proxy. (%s)", line);
+ log_notice(LD_GENERAL, "Unknown line received by managed proxy (%s).", line);
+ return;
err:
mp->conf_state = PT_PROTO_BROKEN;