diff options
| author | Nick Mathewson <nickm@torproject.org> | 2010-07-18 17:05:58 +0200 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2010-07-18 17:05:58 +0200 |
| commit | 0b4b51314f5cb0242e7a8fd3b87bc800cd04eacc (patch) | |
| tree | a21f97794107eafb0f8e4192d88f8812b037ea62 /src/or/config.c | |
| parent | 9d5d0f040f9b0ddf6c10166200d115bfa30a31da (diff) | |
| download | tor-0b4b51314f5cb0242e7a8fd3b87bc800cd04eacc.tar tor-0b4b51314f5cb0242e7a8fd3b87bc800cd04eacc.tar.gz | |
Make the controller act more usefully when GETINFO fails
Right now it says "552 internal error" because there's no way for
getinfo_helper_*() countries to specify an error message. This
patch changes the getinfo_helper_*() interface, and makes most of the
getinfo helpers give useful error messages in response to failures.
This should prevent recurrences of bug 1699, where a missing GeoIPFile
line in the torrc made GETINFO ip-to-county/* fail in a "not obvious
how to fix" way.
Diffstat (limited to 'src/or/config.c')
| -rw-r--r-- | src/or/config.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/or/config.c b/src/or/config.c index 7dee8ffab..70a3ee621 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -5060,9 +5060,11 @@ remove_file_if_very_old(const char *fname, time_t now) * types. */ int getinfo_helper_config(control_connection_t *conn, - const char *question, char **answer) + const char *question, char **answer, + const char **errmsg) { (void) conn; + (void) errmsg; if (!strcmp(question, "config/names")) { smartlist_t *sl = smartlist_create(); int i; |