diff options
| author | David Fifield <david@bamsoftware.com> | 2013-12-05 04:56:28 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2013-12-05 12:30:11 -0500 |
| commit | b60049544143e8569e491dd30541d28127bfdb22 (patch) | |
| tree | 643b4279e109cd2fa880e2874da6048a81cfaa86 /src/common | |
| parent | c64d5227401a44e8a1fcd85a67356a53b83cff82 (diff) | |
| download | tor-b60049544143e8569e491dd30541d28127bfdb22.tar tor-b60049544143e8569e491dd30541d28127bfdb22.tar.gz | |
Set CREATE_NO_WINDOW in tor_spawn_background.
This flag prevents the creation of a console window popup on Windows. We
need it for pluggable transport executables--otherwise you get blank
console windows when you launch the 3.x browser bundle with transports
enabled.
http://msdn.microsoft.com/en-us/library/ms684863.aspx#CREATE_NO_WINDOW
The browser bundles that used Vidalia used to set this flag when
launching tor itself; it was apparently inherited by the pluggable
transports launched by tor. In the 3.x bundles, tor is launched by some
JavaScript code, which doesn't have the ability to set CREATE_NO_WINDOW.
tor itself is now being compiled with the -mwindows option, so that it
is a GUI application, not a console application, and doesn't show a
console window in any case. This workaround doesn't work for pluggable
transports, because they need to be able to write control messages to
stdout.
https://trac.torproject.org/projects/tor/ticket/9444#comment:30
Diffstat (limited to 'src/common')
| -rw-r--r-- | src/common/util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/util.c b/src/common/util.c index ae3f69b5e..054de3dbe 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -3803,7 +3803,7 @@ tor_spawn_background(const char *const filename, const char **argv, TRUE, // handles are inherited /*(TODO: set CREATE_NEW CONSOLE/PROCESS_GROUP to make GetExitCodeProcess() * work?) */ - 0, // creation flags + CREATE_NO_WINDOW, // creation flags (env==NULL) ? NULL : env->windows_environment_block, NULL, // use parent's current directory &siStartInfo, // STARTUPINFO pointer |