diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-07-01 12:06:54 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-07-01 12:54:24 -0400 |
| commit | 959da6b7f2b5ed63426fd12a9046ac06033f6db1 (patch) | |
| tree | 511cbbf99e04527081166fbb53a319b997f1bcc1 /changes/cid_428 | |
| parent | 46297bc7bd86826fa79195f36059ce408ef45b6c (diff) | |
| download | tor-959da6b7f2b5ed63426fd12a9046ac06033f6db1.tar tor-959da6b7f2b5ed63426fd12a9046ac06033f6db1.tar.gz | |
Use strlcpy in create_unix_sockaddr()
Using strncpy meant that if listenaddress were ever >=
sizeof(sockaddr_un.sun_path), we would fail to nul-terminate
sun_path. This isn't a big deal: we never read sun_path, and the
kernel is smart enough to reject the sockaddr_un if it isn't
nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we
should reject addresses that don't fit in sockaddr_un.sun_path.
Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha.
Diffstat (limited to 'changes/cid_428')
| -rw-r--r-- | changes/cid_428 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/cid_428 b/changes/cid_428 new file mode 100644 index 000000000..cb0fc8c2b --- /dev/null +++ b/changes/cid_428 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Always NUL-terminate the sun_path field of a sockaddr_un before + passing it to the kernel. (Not a security issue: kernels are + smart enough to reject bad sockaddr_uns.) Found by Coverity; CID + # 428. Bugfix on Tor 0.2.0.3-alpha. |