diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-11-27 09:24:41 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-11-27 09:24:41 -0500 |
| commit | 40a87c4c08be0cdd87a3df283f285b3c2a0c8445 (patch) | |
| tree | 1d9d693446f6e838dae523ffb9473a91ed5fed86 | |
| parent | e665ec6409c253ebbbf7ae0ef2601fe7c8afba7b (diff) | |
| download | tor-40a87c4c08be0cdd87a3df283f285b3c2a0c8445.tar tor-40a87c4c08be0cdd87a3df283f285b3c2a0c8445.tar.gz | |
indent; add comment
| -rw-r--r-- | src/common/tortls.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/common/tortls.c b/src/common/tortls.c index 9ac5c34f2..b4d81de2f 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -585,6 +585,8 @@ tor_tls_create_certificate(crypto_pk_env_t *rsa, const char *cname_sign, unsigned int cert_lifetime) { + /* OpenSSL generates self-signed certificates with random 64-bit serial + * numbers, so let's do that too. */ #define SERIAL_NUMBER_SIZE 8 time_t start_time, end_time; @@ -612,12 +614,12 @@ tor_tls_create_certificate(crypto_pk_env_t *rsa, goto error; { /* our serial number is 8 random bytes. */ - if (crypto_rand((char *)serial_tmp, sizeof(serial_tmp)) < 0) - goto error; - if (!(serial_number = BN_bin2bn(serial_tmp, sizeof(serial_tmp), NULL))) - goto error; - if (!(BN_to_ASN1_INTEGER(serial_number, X509_get_serialNumber(x509)))) - goto error; + if (crypto_rand((char *)serial_tmp, sizeof(serial_tmp)) < 0) + goto error; + if (!(serial_number = BN_bin2bn(serial_tmp, sizeof(serial_tmp), NULL))) + goto error; + if (!(BN_to_ASN1_INTEGER(serial_number, X509_get_serialNumber(x509)))) + goto error; } if (!(name = tor_x509_name_new(cname))) |