aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2007-10-19 18:56:21 +0000
committerNick Mathewson <nickm@torproject.org>2007-10-19 18:56:21 +0000
commitee2b770deebba5b4cd80416ad8e757e478723987 (patch)
tree24e2d237b1f0b2f70137349b6955e8debacf4db9
parent24317c75a9e6bfab78bda01faeac94debeb4e9d1 (diff)
downloadtor-ee2b770deebba5b4cd80416ad8e757e478723987.tar
tor-ee2b770deebba5b4cd80416ad8e757e478723987.tar.gz
r15964@catbus: nickm | 2007-10-19 12:43:49 -0400
Sort out that need_to_mirror is for routerstatuses in v2 networkstatuses only. svn:r12050
-rw-r--r--doc/TODO8
-rw-r--r--src/or/networkstatus.c1
-rw-r--r--src/or/or.h2
3 files changed, 5 insertions, 6 deletions
diff --git a/doc/TODO b/doc/TODO
index b9e3a35e9..4102edec4 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -58,7 +58,7 @@ Things we'd like to do in 0.2.0.x:
out and download the ancient history of the universe.
o List IP addresses in certificates?
o Make the address in votes be an actual IP address.
- - Change 'mismatched digest' message to first check timestamps instead.
+ o Change 'mismatched digest' message to first check timestamps instead.
- Proposals:
. 101: Voting on the Tor Directory System (plus 103)
@@ -78,12 +78,12 @@ Things we'd like to do in 0.2.0.x:
- Code to retry consensus download if we got one we already have.
- Use if-modified-since on consensus download
- Use if-modified-since on certificate download
- - Enable for non-caches
+ o Enable for non-caches
- Code to use v3 networkstatus documents once clients are
fetching them
- - Implement.
+ o Implement.
- Fix all XXXX020s.
- - Sort out need_to_mirror
+ o Sort out need_to_mirror
- Work hard to make sure clients never look at v2 networkstatus docs.
- Check in old_routers before fetching a router status. You never
know if we'll flap...
diff --git a/src/or/networkstatus.c b/src/or/networkstatus.c
index b1afddfb8..154d82676 100644
--- a/src/or/networkstatus.c
+++ b/src/or/networkstatus.c
@@ -896,7 +896,6 @@ networkstatus_copy_old_consensus_info(networkstatus_vote_t *new_c,
if (!memcmp(rs_old->descriptor_digest, rs_new->descriptor_digest,
DIGEST_LEN)) {
/* And the same descriptor too! */
- rs_new->need_to_mirror = rs_old->need_to_mirror; /*XXXX020 NM ????? */
memcpy(&rs_new->dl_status, &rs_old->dl_status,sizeof(download_status_t));
}
});
diff --git a/src/or/or.h b/src/or/or.h
index 91c64ea89..bbf18bdb5 100644
--- a/src/or/or.h
+++ b/src/or/or.h
@@ -1250,7 +1250,7 @@ typedef struct routerstatus_t {
/** True if we, as a directory mirror, want to download the corresponding
* routerinfo from the authority who gave us this routerstatus. (That is,
* if we don't have the routerinfo, and if we haven't already tried to get it
- * from this authority.)
+ * from this authority.) Applies in v2 networkstatus document only.
*/
unsigned int need_to_mirror:1;
unsigned int name_lookup_warned:1; /**< Have we warned the user for referring