From d37e941778af77694f63306d4cae3250885abd87 Mon Sep 17 00:00:00 2001 From: Jonathan Ballet Date: Sat, 24 Feb 2018 18:24:05 +0100 Subject: Fix broken tests due to incorrect usage of t.Skip() Current tests were broken with the following error: # github.com/dmacvicar/terraform-provider-libvirt/libvirt libvirt/resource_libvirt_domain_test.go:874: Skip call has possible formatting directive %s libvirt/resource_libvirt_domain_test.go:882: Skip call has possible formatting directive %s FAIL github.com/dmacvicar/terraform-provider-libvirt/libvirt [build failed] t.Skip with formatting should be t.Skipf() --- libvirt/resource_libvirt_domain_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt/resource_libvirt_domain_test.go b/libvirt/resource_libvirt_domain_test.go index 78677617..f4332a15 100644 --- a/libvirt/resource_libvirt_domain_test.go +++ b/libvirt/resource_libvirt_domain_test.go @@ -871,7 +871,7 @@ func TestAccLibvirtDomainFirmware(t *testing.T) { if _, err := os.Stat(firmware); os.IsNotExist(err) { firmware = "/usr/share/ovmf/OVMF.fd" if _, err := os.Stat(firmware); os.IsNotExist(err) { - t.Skip("Can't test domain custom firmware: OVMF firmware not found: %s") + t.Skipf("Can't test domain custom firmware: OVMF firmware not found: %s", err) } } @@ -879,7 +879,7 @@ func TestAccLibvirtDomainFirmware(t *testing.T) { if _, err := os.Stat(template); os.IsNotExist(err) { template = "/usr/share/qemu/OVMF.fd" if _, err := os.Stat(template); os.IsNotExist(err) { - t.Skip("Can't test domain custom firmware template: OVMF template not found: %s") + t.Skipf("Can't test domain custom firmware template: OVMF template not found: %s", err) } } -- cgit v1.2.3