diff options
author | Dario Maiocchi <dmaiocchi@suse.com> | 2017-11-10 20:21:38 +0100 |
---|---|---|
committer | Dario Maiocchi <dmaiocchi@suse.com> | 2017-11-16 11:26:28 +0100 |
commit | 4271bcd7af38442f2836f42607f02561b0af4fc7 (patch) | |
tree | 31e7c1508b9dcb15f8be0f8f9d51224c046ed93d /libvirt/resource_cloud_init.go | |
parent | 5c914a032d864314c5b81373c940d354120bffdb (diff) | |
download | terraform-provider-libvirt-4271bcd7af38442f2836f42607f02561b0af4fc7.tar terraform-provider-libvirt-4271bcd7af38442f2836f42607f02561b0af4fc7.tar.gz |
golinting on various files
Diffstat (limited to 'libvirt/resource_cloud_init.go')
-rw-r--r-- | libvirt/resource_cloud_init.go | 354 |
1 files changed, 66 insertions, 288 deletions
diff --git a/libvirt/resource_cloud_init.go b/libvirt/resource_cloud_init.go index 86c72ac7..da3e9832 100644 --- a/libvirt/resource_cloud_init.go +++ b/libvirt/resource_cloud_init.go @@ -1,341 +1,119 @@ package libvirt import ( - "encoding/xml" "fmt" "log" - "net/http" - "strconv" "github.com/hashicorp/terraform/helper/schema" - libvirt "github.com/libvirt/libvirt-go" ) -func volumeCommonSchema() map[string]*schema.Schema { - return map[string]*schema.Schema{ - "name": &schema.Schema{ - Type: schema.TypeString, - Required: true, - ForceNew: true, - }, - "pool": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - Default: "default", - ForceNew: true, - }, - "source": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - ForceNew: true, - }, - "size": &schema.Schema{ - Type: schema.TypeInt, - Optional: true, - Computed: true, - ForceNew: true, - }, - "format": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - ForceNew: true, - }, - "base_volume_id": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - ForceNew: true, - }, - "base_volume_pool": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - ForceNew: true, - }, - "base_volume_name": &schema.Schema{ - Type: schema.TypeString, - Optional: true, - ForceNew: true, - }, - } -} - -func resourceLibvirtVolume() *schema.Resource { +func resourceCloudInit() *schema.Resource { return &schema.Resource{ - Create: resourceLibvirtVolumeCreate, - Read: resourceLibvirtVolumeRead, - Delete: resourceLibvirtVolumeDelete, - Schema: volumeCommonSchema(), - } -} - -func remoteImageSize(url string) (int, error) { - response, err := http.Head(url) - if err != nil { - return 0, err - } - length, err := strconv.Atoi(response.Header.Get("Content-Length")) - if err != nil { - return 0, err + Create: resourceCloudInitCreate, + Read: resourceCloudInitRead, + Delete: resourceCloudInitDelete, + Schema: map[string]*schema.Schema{ + "name": &schema.Schema{ + Type: schema.TypeString, + Required: true, + ForceNew: true, + }, + "pool": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + Default: "default", + ForceNew: true, + }, + "local_hostname": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + ForceNew: true, + }, + "user_data": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + ForceNew: true, + }, + "ssh_authorized_key": &schema.Schema{ + Type: schema.TypeString, + Optional: true, + ForceNew: true, + }, + }, } - return length, nil } -func resourceLibvirtVolumeCreate(d *schema.ResourceData, meta interface{}) error { +func resourceCloudInitCreate(d *schema.ResourceData, meta interface{}) error { + log.Printf("[DEBUG] creating cloudinit") virConn := meta.(*Client).libvirt if virConn == nil { return fmt.Errorf("the libvirt connection was nil") } - poolName := "default" - if _, ok := d.GetOk("pool"); ok { - poolName = d.Get("pool").(string) - } - - PoolSync.AcquireLock(poolName) - defer PoolSync.ReleaseLock(poolName) - - pool, err := virConn.LookupStoragePoolByName(poolName) - if err != nil { - return fmt.Errorf("can't find storage pool '%s'", poolName) - } - defer pool.Free() - - // Refresh the pool of the volume so that libvirt knows it is - // not longer in use. - WaitForSuccess("Error refreshing pool for volume", func() error { - return pool.Refresh(0) - }) - - volumeDef := newDefVolume() + cloudInit := newCloudInitDef() + cloudInit.Metadata.LocalHostname = d.Get("local_hostname").(string) + cloudInit.UserDataRaw = d.Get("user_data").(string) - if name, ok := d.GetOk("name"); ok { - volumeDef.Name = name.(string) + if _, ok := d.GetOk("ssh_authorized_key"); ok { + sshKey := d.Get("ssh_authorized_key").(string) + cloudInit.UserData.SSHAuthorizedKeys = append( + cloudInit.UserData.SSHAuthorizedKeys, + sshKey) } - volumeFormat := "qcow2" - if _, ok := d.GetOk("format"); ok { - volumeFormat = d.Get("format").(string) - } - volumeDef.Target.Format.Type = volumeFormat - - var ( - img image - volume *libvirt.StorageVol = nil - ) - - // an source image was given, this mean we can't choose size - if source, ok := d.GetOk("source"); ok { - // source and size conflict - if _, ok := d.GetOk("size"); ok { - return fmt.Errorf("'size' can't be specified when also 'source' is given (the size will be set to the size of the source image") - } - if _, ok := d.GetOk("base_volume_id"); ok { - return fmt.Errorf("'base_volume_id' can't be specified when also 'source' is given") - } - - if _, ok := d.GetOk("base_volume_name"); ok { - return fmt.Errorf("'base_volume_name' can't be specified when also 'source' is given") - } + cloudInit.Name = d.Get("name").(string) + cloudInit.PoolName = d.Get("pool").(string) - // Check if we already have this image in the pool - if len(volumeDef.Name) > 0 { - if v, err := pool.LookupStorageVolByName(volumeDef.Name); err != nil { - log.Printf("Could not find image %s in pool %s", volumeDef.Name, poolName) - } else { - volume = v - volumeDef, err = newDefVolumeFromLibvirt(volume) - if err != nil { - return fmt.Errorf("could not get a volume definition from XML for %s: %s", volumeDef.Name, err) - } - } - } - - if img, err = newImage(source.(string)); err != nil { - return err - } - - // update the image in the description, even if the file has not changed - if size, err := img.Size(); err != nil { - return err - } else { - log.Printf("Image %s image is: %d bytes", img, size) - volumeDef.Capacity.Unit = "B" - volumeDef.Capacity.Value = size - } - } else { - _, noSize := d.GetOk("size") - _, noBaseVol := d.GetOk("base_volume_id") - - if noSize && noBaseVol { - return fmt.Errorf("'size' needs to be specified if no 'source' or 'base_volume_id' is given") - } - volumeDef.Capacity.Value = uint64(d.Get("size").(int)) - } + log.Printf("[INFO] cloudInit: %+v", cloudInit) - if baseVolumeId, ok := d.GetOk("base_volume_id"); ok { - if _, ok := d.GetOk("size"); ok { - return fmt.Errorf("'size' can't be specified when also 'base_volume_id' is given (the size will be set to the size of the backing image") - } - - if _, ok := d.GetOk("base_volume_name"); ok { - return fmt.Errorf("'base_volume_name' can't be specified when also 'base_volume_id' is given") - } - - volume = nil - baseVolume, err := virConn.LookupStorageVolByKey(baseVolumeId.(string)) - if err != nil { - return fmt.Errorf("Can't retrieve volume %s", baseVolumeId.(string)) - } - backingStoreDef, err := newDefBackingStoreFromLibvirt(baseVolume) - if err != nil { - return fmt.Errorf("Could not retrieve backing store %s", baseVolumeId.(string)) - } - volumeDef.BackingStore = &backingStoreDef - } - - if baseVolumeName, ok := d.GetOk("base_volume_name"); ok { - if _, ok := d.GetOk("size"); ok { - return fmt.Errorf("'size' can't be specified when also 'base_volume_name' is given (the size will be set to the size of the backing image") - } - - volume = nil - baseVolumePool := pool - if _, ok := d.GetOk("base_volume_pool"); ok { - baseVolumePoolName := d.Get("base_volume_pool").(string) - baseVolumePool, err = virConn.LookupStoragePoolByName(baseVolumePoolName) - if err != nil { - return fmt.Errorf("can't find storage pool '%s'", baseVolumePoolName) - } - defer baseVolumePool.Free() - } - baseVolume, err := baseVolumePool.LookupStorageVolByName(baseVolumeName.(string)) - if err != nil { - return fmt.Errorf("Can't retrieve volume %s", baseVolumeName.(string)) - } - backingStoreDef, err := newDefBackingStoreFromLibvirt(baseVolume) - if err != nil { - return fmt.Errorf("Could not retrieve backing store %s", baseVolumeName.(string)) - } - volumeDef.BackingStore = &backingStoreDef - } - - if volume == nil { - volumeDefXml, err := xml.Marshal(volumeDef) - if err != nil { - return fmt.Errorf("Error serializing libvirt volume: %s", err) - } - - // create the volume - v, err := pool.StorageVolCreateXML(string(volumeDefXml), 0) - if err != nil { - return fmt.Errorf("Error creating libvirt volume: %s", err) - } - volume = v - defer volume.Free() - } - - // we use the key as the id - key, err := volume.GetKey() + key, err := cloudInit.CreateAndUpload(virConn) if err != nil { - return fmt.Errorf("Error retrieving volume key: %s", err) + return err } d.SetId(key) // make sure we record the id even if the rest of this gets interrupted - d.Partial(true) + d.Partial(true) // make sure we record the id even if the rest of this gets interrupted d.Set("id", key) d.SetPartial("id") + // TODO: at this point we have collected more things than the ID, so let's save as many things as we can d.Partial(false) - log.Printf("[INFO] Volume ID: %s", d.Id()) - - // upload source if present - if _, ok := d.GetOk("source"); ok { - err = img.Import(newCopier(virConn, volume, volumeDef.Capacity.Value), volumeDef) - if err != nil { - return fmt.Errorf("Error while uploading source %s: %s", img.String(), err) - } - } - - return resourceLibvirtVolumeRead(d, meta) + return resourceCloudInitRead(d, meta) } -func resourceLibvirtVolumeRead(d *schema.ResourceData, meta interface{}) error { +func resourceCloudInitRead(d *schema.ResourceData, meta interface{}) error { virConn := meta.(*Client).libvirt if virConn == nil { return fmt.Errorf("the libvirt connection was nil") } - volume, err := virConn.LookupStorageVolByKey(d.Id()) - if err != nil { - virErr := err.(libvirt.Error) - if virErr.Code != libvirt.ERR_NO_STORAGE_VOL { - return fmt.Errorf("Can't retrieve volume %s", d.Id()) - } - - log.Printf("[INFO] Volume %s not found, attempting to start its pool") - - volId := d.Id() - volPoolName := d.Get("pool").(string) - volPool, err := virConn.LookupStoragePoolByName(volPoolName) - if err != nil { - return fmt.Errorf("Error retrieving pool %s for volume %s: %s", volPoolName, volId, err) - } - defer volPool.Free() - - active, err := volPool.IsActive() - if err != nil { - return fmt.Errorf("error retrieving status of pool %s for volume %s: %s", volPoolName, volId, err) - } - if active { - return fmt.Errorf("can't retrieve volume %s", d.Id()) - } - - err = volPool.Create(0) - if err != nil { - return fmt.Errorf("error starting pool %s: %s", volPoolName, err) - } - - // attempt a new lookup - volume, err = virConn.LookupStorageVolByKey(d.Id()) - if err != nil { - return fmt.Errorf("second attempt: Can't retrieve volume %s", d.Id()) - } - } - defer volume.Free() - - volName, err := volume.GetName() - if err != nil { - return fmt.Errorf("error retrieving volume name: %s", err) - } - - volPool, err := volume.LookupPoolByVolume() + ci, err := newCloudInitDefFromRemoteISO(virConn, d.Id()) if err != nil { - return fmt.Errorf("error retrieving pool for volume: %s", err) + return fmt.Errorf("error while retrieving remote ISO: %s", err) } - defer volPool.Free() + d.Set("pool", ci.PoolName) + d.Set("name", ci.Name) + d.Set("local_hostname", ci.Metadata.LocalHostname) + d.Set("user_data", ci.UserDataRaw) - volPoolName, err := volPool.GetName() - if err != nil { - return fmt.Errorf("error retrieving pool name: %s", err) - } - - d.Set("pool", volPoolName) - d.Set("name", volName) - - info, err := volume.GetInfo() - if err != nil { - return fmt.Errorf("error retrieving volume name: %s", err) + if len(ci.UserData.SSHAuthorizedKeys) == 1 { + d.Set("ssh_authorized_key", ci.UserData.SSHAuthorizedKeys[0]) } - d.Set("size", info.Capacity) return nil } -func resourceLibvirtVolumeDelete(d *schema.ResourceData, meta interface{}) error { +func resourceCloudInitDelete(d *schema.ResourceData, meta interface{}) error { virConn := meta.(*Client).libvirt if virConn == nil { return fmt.Errorf("the libvirt connection was nil") } - return RemoveVolume(virConn, d.Id()) + key, err := getCloudInitVolumeKeyFromTerraformID(d.Id()) + if err != nil { + return err + } + + return RemoveVolume(virConn, key) } |