Fix a bug with nodes outside bbox

If there are nodes with locations outside the bounding box we are interested in
in the input osm file and we are generating the geodistribution for ways images,
tagstats could segfault. In this case the node location wasn't stored in the
m_storage, so when reading the it back, either you get an unintialized value
or a segfault. (This also depends on the type of storage used.)
Thanks to @lonvia for help debugging this.

The solution is to store "MAXINT" as a marker and make sure it doesn't end up
in the GeoDistribution.

1 files changed, 2 insertions, 10 deletions

diff --git a/tagstats/tagstats_handler.hpp b/tagstats/tagstats_handler.hpp
index 4049083..d3ea136 100644
--- a/tagstats/tagstats_handler.hpp
+++ b/tagstats/tagstats_handler.hpp
@@ -412,11 +412,7 @@ class TagStatsHandler : public Osmium::Handler::Base {
             stat->update(it->value(), object, m_string_store);
 
             if (object.type() == NODE) {
-                try {
-                    stat->distribution.add_coordinate(m_map_to_int(static_cast<const Osmium::OSM::Node&>(object).position()));
-                } catch (std::range_error) {
-                    // ignore
-                }
+                stat->distribution.add_coordinate(m_map_to_int(static_cast<const Osmium::OSM::Node&>(object).position()));
             }
 #ifdef TAGSTATS_GEODISTRIBUTION_FOR_WAYS
             else if (object.type() == WAY) {
@@ -479,11 +475,7 @@ public:
         statistics_handler.node(node);
         collect_tag_stats(*node);
 #ifdef TAGSTATS_GEODISTRIBUTION_FOR_WAYS
-        try {
-            m_storage.set(node->id(), m_map_to_int(node->position()));
-        } catch (std::range_error) {
-            // ignore
-        }
+        m_storage.set(node->id(), m_map_to_int(node->position()));
 #endif
     }