From e990894f68de3c31ef8371fcf4baa301cfe7144a Mon Sep 17 00:00:00 2001 From: Junichi Uekawa Date: Tue, 13 Mar 2012 17:17:47 +0900 Subject: fix logging message and conditionality to make it less lines. I think we don't need the if. I'm not quite convinced ||true to kill the error message is a good idea --- pbuilder-buildpackage | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'pbuilder-buildpackage') diff --git a/pbuilder-buildpackage b/pbuilder-buildpackage index f8cb5ae..45b1177 100755 --- a/pbuilder-buildpackage +++ b/pbuilder-buildpackage @@ -171,12 +171,10 @@ if [ -d "${BUILDRESULT}" ]; then cp -p ${FILE} "${BUILDRESULT}" || true fi done - if [ -n "${ADDITIONAL_BUILDRESULTS}" ]; then - echo "Saving additional results ${ADDITIONAL_BUILDRESULTS[*]}" - for FILE in "${ADDITIONAL_BUILDRESULTS[@]}"; do - cp -a "${BUILDPLACE}/tmp/buildd/"*"/${FILE}" "${BUILDRESULT}" || true - done - fi + for FILE in "${ADDITIONAL_BUILDRESULTS[@]}"; do + log "I: Trying to save additional result ${FILE}" + cp -a "${BUILDPLACE}/tmp/buildd/"*"/${FILE}" "${BUILDRESULT}" || true + done else log "E: BUILDRESULT=[$BUILDRESULT] is not a directory." fi -- cgit v1.2.3