1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
# Patchwork - automated patch tracking system
# Copyright (C) 2010 Jeremy Kerr <jk@ozlabs.org>
#
# SPDX-License-Identifier: GPL-2.0-or-later
from django.contrib.auth.models import User
from django.core import mail
from django.test.client import Client
from django.test import TestCase
from django.urls import reverse
from patchwork.models import EmailConfirmation
from patchwork.models import Person
from patchwork.tests.utils import create_user
def _confirmation_url(conf):
return reverse('confirm', kwargs={'key': conf.key})
class TestUser(object):
firstname = 'Test'
lastname = 'User'
fullname = ' '.join([firstname, lastname])
username = 'testuser'
email = 'test@example.com'
password = 'foobar'
class RegistrationTest(TestCase):
def setUp(self):
self.user = TestUser()
self.client = Client()
self.default_data = {
'username': self.user.username,
'first_name': self.user.firstname,
'last_name': self.user.lastname,
'email': self.user.email,
'password': self.user.password,
}
self.required_error = 'This field is required.'
self.invalid_error = 'Enter a valid value.'
def test_registration_form(self):
response = self.client.get('/register/')
self.assertEqual(response.status_code, 200)
self.assertTemplateUsed(response, 'patchwork/registration.html')
def test_blank_fields(self):
for field in ['username', 'email', 'password']:
data = self.default_data.copy()
del data[field]
response = self.client.post('/register/', data)
self.assertEqual(response.status_code, 200)
self.assertFormError(response, 'form', field, self.required_error)
def test_invalid_username(self):
data = self.default_data.copy()
data['username'] = 'invalid user'
response = self.client.post('/register/', data)
self.assertEqual(response.status_code, 200)
self.assertFormError(response, 'form', 'username', self.invalid_error)
def test_existing_username(self):
user = create_user()
data = self.default_data.copy()
data['username'] = user.username
response = self.client.post('/register/', data)
self.assertEqual(response.status_code, 200)
self.assertFormError(
response, 'form', 'username',
'This username is already taken. Please choose another.')
def test_existing_email(self):
user = create_user()
data = self.default_data.copy()
data['email'] = user.email
response = self.client.post('/register/', data)
self.assertEqual(response.status_code, 200)
self.assertFormError(
response, 'form', 'email',
'This email address is already in use for the account '
'"%s".\n' % user.username)
def test_valid_registration(self):
response = self.client.post('/register/', self.default_data)
self.assertEqual(response.status_code, 200)
self.assertContains(response, 'confirmation email has been sent')
# check for presence of an inactive user object
users = User.objects.filter(username=self.user.username)
self.assertEqual(users.count(), 1)
user = users[0]
self.assertEqual(user.username, self.user.username)
self.assertEqual(user.email, self.user.email)
self.assertEqual(user.is_active, False)
# check for confirmation object
confs = EmailConfirmation.objects.filter(
user=user, type='registration')
self.assertEqual(len(confs), 1)
conf = confs[0]
self.assertEqual(conf.email, self.user.email)
# check for a sent mail
self.assertEqual(len(mail.outbox), 1)
msg = mail.outbox[0]
self.assertEqual(msg.subject, 'Patchwork account confirmation')
self.assertIn(self.user.email, msg.to)
self.assertIn(_confirmation_url(conf), msg.body)
# ...and that the URL is valid
response = self.client.get(_confirmation_url(conf))
self.assertEqual(response.status_code, 200)
class RegistrationConfirmationTest(TestCase):
def setUp(self):
self.user = TestUser()
self.default_data = {
'username': self.user.username,
'first_name': self.user.firstname,
'last_name': self.user.lastname,
'email': self.user.email,
'password': self.user.password
}
def test_valid(self):
"""Test the success path."""
self.assertEqual(EmailConfirmation.objects.count(), 0)
response = self.client.post('/register/', self.default_data)
self.assertEqual(response.status_code, 200)
self.assertContains(response, 'confirmation email has been sent')
self.assertEqual(EmailConfirmation.objects.count(), 1)
conf = EmailConfirmation.objects.filter()[0]
self.assertFalse(conf.user.is_active)
self.assertTrue(conf.active)
response = self.client.get(_confirmation_url(conf))
self.assertEqual(response.status_code, 200)
self.assertTemplateUsed(
response, 'patchwork/registration-confirm.html')
conf = EmailConfirmation.objects.get(pk=conf.pk)
self.assertTrue(conf.user.is_active)
self.assertFalse(conf.active)
def test_new_person_setup(self):
"""Ensure a new Person is created after account setup.
Create an account for a never before seen email. Check that a Person
object is created after registration and has the correct details.
"""
# register
self.assertEqual(EmailConfirmation.objects.count(), 0)
response = self.client.post('/register/', self.default_data)
self.assertEqual(response.status_code, 200)
self.assertFalse(Person.objects.exists())
# confirm
conf = EmailConfirmation.objects.filter()[0]
response = self.client.get(_confirmation_url(conf))
self.assertEqual(response.status_code, 200)
qs = Person.objects.filter(email=self.user.email)
self.assertTrue(qs.exists())
person = Person.objects.get(email=self.user.email)
self.assertEqual(person.name, self.user.fullname)
def test_existing_person_setup(self):
"""Ensure an existing person is linked after account setup.
Create an account for a user using an email we've previously seen.
Check that the person object is updated after registration with the
correct details.
"""
person = Person(name=self.user.fullname, email=self.user.email)
person.save()
# register
self.assertEqual(EmailConfirmation.objects.count(), 0)
response = self.client.post('/register/', self.default_data)
self.assertEqual(response.status_code, 200)
# confirm
conf = EmailConfirmation.objects.filter()[0]
response = self.client.get(_confirmation_url(conf))
self.assertEqual(response.status_code, 200)
person = Person.objects.get(email=self.user.email)
self.assertEqual(person.name, self.user.fullname)
def test_existing_person_unmodified(self):
"""Ensure an existing person is not linked until registration is done.
Create an account for a user using an email we've previously seen but
don't confirm it. Check that the person object is not updated yet.
"""
person = Person(name=self.user.fullname, email=self.user.email)
person.save()
# register
data = self.default_data.copy()
data['first_name'] = 'invalid'
data['last_name'] = 'invalid'
self.assertEqual(data['email'], person.email)
response = self.client.post('/register/', data)
self.assertEqual(response.status_code, 200)
self.assertEqual(
Person.objects.get(pk=person.pk).name, self.user.fullname)
|