1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
|
# Patchwork - automated patch tracking system
# Copyright (C) 2015 Stephen Finucane <stephen@that.guru>
#
# SPDX-License-Identifier: GPL-2.0-or-later
from django.test import TestCase
from patchwork.models import Event
from patchwork.tests import utils
BASE_FIELDS = ['previous_state', 'current_state', 'previous_delegate',
'current_delegate']
def _get_events(**filters):
# These are sorted by reverse normally, so reverse it once again
return Event.objects.filter(**filters).order_by('date')
class _BaseTestCase(TestCase):
def assertEventFields(self, event, parent_type='patch', **fields):
for field_name in [x for x in BASE_FIELDS]:
field = getattr(event, field_name)
if field_name in fields:
self.assertEqual(field, fields[field_name])
else:
self.assertIsNone(field)
class PatchCreatedTest(_BaseTestCase):
def test_patch_created(self):
"""No series, so patch dependencies implicitly exist."""
patch = utils.create_patch(series=None)
# This should raise the CATEGORY_PATCH_CREATED event only as there is
# no series
events = _get_events(patch=patch)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_PATCH_CREATED)
self.assertEqual(events[0].project, patch.project)
self.assertEventFields(events[0])
def test_patch_dependencies_present_series(self):
"""Patch dependencies already exist."""
series = utils.create_series()
patch = utils.create_patch(series=series)
# This should raise both the CATEGORY_PATCH_CREATED and
# CATEGORY_PATCH_COMPLETED events
events = _get_events(patch=patch)
self.assertEqual(events.count(), 2)
self.assertEqual(events[0].category, Event.CATEGORY_PATCH_CREATED)
self.assertEqual(events[0].project, patch.project)
self.assertEqual(events[1].category, Event.CATEGORY_PATCH_COMPLETED)
self.assertEqual(events[1].project, patch.project)
self.assertEventFields(events[0])
self.assertEventFields(events[1])
# This shouldn't be affected by another update to the patch
patch.commit_ref = 'aac76f0b0f8dd657ff07bb32df369705696d4831'
patch.save()
events = _get_events(patch=patch)
self.assertEqual(events.count(), 2)
def test_patch_dependencies_out_of_order(self):
series = utils.create_series()
patch_3 = utils.create_patch(series=series, number=3)
patch_2 = utils.create_patch(series=series, number=2)
# This should only raise the CATEGORY_PATCH_CREATED event for
# both patches as they are both missing dependencies
for patch in [patch_2, patch_3]:
events = _get_events(patch=patch)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_PATCH_CREATED)
self.assertEventFields(events[0])
patch_1 = utils.create_patch(series=series, number=1)
# We should now see the CATEGORY_PATCH_COMPLETED event for all patches
# as the dependencies for all have been met
for patch in [patch_1, patch_2, patch_3]:
events = _get_events(patch=patch)
self.assertEqual(events.count(), 2)
self.assertEqual(events[0].category, Event.CATEGORY_PATCH_CREATED)
self.assertEqual(events[1].category,
Event.CATEGORY_PATCH_COMPLETED)
self.assertEventFields(events[0])
self.assertEventFields(events[1])
def test_patch_dependencies_missing(self):
series = utils.create_series()
patch = utils.create_patch(series=series, number=2)
# This should only raise the CATEGORY_PATCH_CREATED event as
# there is a missing dependency (patch 1)
events = _get_events(patch=patch)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_PATCH_CREATED)
self.assertEventFields(events[0])
class PatchChangedTest(_BaseTestCase):
def test_patch_state_changed(self):
# purposefully setting series to None to minimize additional events
patch = utils.create_patch(series=None)
old_state = patch.state
new_state = utils.create_state()
actor = utils.create_maintainer(project=patch.project)
patch.state = new_state
self.assertTrue(patch.is_editable(actor))
patch.save()
events = _get_events(patch=patch)
self.assertEqual(events.count(), 2)
# we don't care about the CATEGORY_PATCH_CREATED event here
self.assertEqual(events[1].category,
Event.CATEGORY_PATCH_STATE_CHANGED)
self.assertEqual(events[1].project, patch.project)
self.assertEqual(events[1].actor, actor)
self.assertEventFields(events[1], previous_state=old_state,
current_state=new_state)
def test_patch_delegated(self):
# purposefully setting series to None to minimize additional events
patch = utils.create_patch(series=None)
delegate_a = utils.create_user()
actor = utils.create_maintainer(project=patch.project)
# None -> Delegate A
patch.delegate = delegate_a
self.assertTrue(patch.is_editable(actor))
patch.save()
events = _get_events(patch=patch)
self.assertEqual(events.count(), 2)
# we don't care about the CATEGORY_PATCH_CREATED event here
self.assertEqual(events[1].category,
Event.CATEGORY_PATCH_DELEGATED)
self.assertEqual(events[1].project, patch.project)
self.assertEqual(events[1].actor, actor)
self.assertEventFields(events[1], current_delegate=delegate_a)
delegate_b = utils.create_user()
# Delegate A -> Delegate B
patch.delegate = delegate_b
patch.save()
events = _get_events(patch=patch)
self.assertEqual(events.count(), 3)
self.assertEqual(events[2].category,
Event.CATEGORY_PATCH_DELEGATED)
self.assertEventFields(events[2], previous_delegate=delegate_a,
current_delegate=delegate_b)
# Delegate B -> None
patch.delegate = None
patch.save()
events = _get_events(patch=patch)
self.assertEqual(events.count(), 4)
self.assertEqual(events[3].category,
Event.CATEGORY_PATCH_DELEGATED)
self.assertEventFields(events[3], previous_delegate=delegate_b)
def test_patch_relations_changed(self):
# purposefully setting series to None to minimize additional events
relation = utils.create_relation()
patches = utils.create_patches(3, series=None)
# mark the first two patches as related; the second patch should be the
# one that the event is raised for
patches[0].related = relation
patches[0].save()
patches[1].related = relation
patches[1].save()
events = _get_events(patch=patches[1])
self.assertEqual(events.count(), 2)
self.assertEqual(
events[1].category, Event.CATEGORY_PATCH_RELATION_CHANGED)
self.assertEqual(events[1].project, patches[1].project)
self.assertIsNone(events[1].previous_relation)
self.assertIsNone(events[1].current_relation)
# add the third patch
patches[2].related = relation
patches[2].save()
events = _get_events(patch=patches[2])
self.assertEqual(events.count(), 2)
self.assertEqual(
events[1].category, Event.CATEGORY_PATCH_RELATION_CHANGED)
self.assertEqual(events[1].project, patches[1].project)
self.assertIsNone(events[1].previous_relation)
self.assertIsNone(events[1].current_relation)
# drop the third patch
patches[2].related = None
patches[2].save()
events = _get_events(patch=patches[2])
self.assertEqual(events.count(), 3)
self.assertEqual(
events[2].category, Event.CATEGORY_PATCH_RELATION_CHANGED)
self.assertEqual(events[2].project, patches[1].project)
self.assertIsNone(events[2].previous_relation)
self.assertIsNone(events[2].current_relation)
class CheckCreatedTest(_BaseTestCase):
def test_check_created(self):
check = utils.create_check()
events = _get_events(created_check=check)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_CHECK_CREATED)
self.assertEqual(events[0].project, check.patch.project)
self.assertEqual(events[0].actor, check.user)
self.assertEventFields(events[0])
class CoverCreatedTest(_BaseTestCase):
def test_cover_created(self):
cover = utils.create_cover()
events = _get_events(cover=cover)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_COVER_CREATED)
self.assertEqual(events[0].project, cover.project)
self.assertEventFields(events[0])
class SeriesCreatedTest(_BaseTestCase):
def test_series_created(self):
series = utils.create_series()
events = _get_events(series=series)
self.assertEqual(events.count(), 1)
self.assertEqual(events[0].category, Event.CATEGORY_SERIES_CREATED)
self.assertEqual(events[0].project, series.project)
self.assertEventFields(events[0])
class SeriesChangedTest(_BaseTestCase):
def test_series_completed(self):
"""Validate 'series-completed' events."""
series = utils.create_series(total=2)
# the series has no patches associated with it so it's not yet complete
events = _get_events(series=series)
self.assertNotIn(Event.CATEGORY_SERIES_COMPLETED,
[x.category for x in events])
# create the second of two patches in the series; series is still not
# complete
utils.create_patch(series=series, number=2)
events = _get_events(series=series)
self.assertNotIn(Event.CATEGORY_SERIES_COMPLETED,
[x.category for x in events])
# now create the first patch, which will "complete" the series
utils.create_patch(series=series, number=1)
events = _get_events(series=series)
self.assertIn(Event.CATEGORY_SERIES_COMPLETED,
[x.category for x in events])
|