diff options
| author | Stephen Finucane <stephen@that.guru> | 2016-12-02 10:27:10 +0000 |
|---|---|---|
| committer | Stephen Finucane <stephen@that.guru> | 2017-02-06 18:57:46 +0000 |
| commit | eef55d674a808e4d6da3f40081c8b4f1a1858356 (patch) | |
| tree | 8b8e46a370446f8c47bfbcfec5659478006cffaf /tools/patchwork-update-commits | |
| parent | 6165c255ecabed2d8d74a8817279561fc9986dbe (diff) | |
| download | patchwork-eef55d674a808e4d6da3f40081c8b4f1a1858356.tar patchwork-eef55d674a808e4d6da3f40081c8b4f1a1858356.tar.gz | |
tools: Run scripts through shellcheck
This mostly results in the addition of quotes to prevent globbing.
Signed-off-by: Stephen Finucane <stephen@that.guru>
Reviewed-by: Daniel Axtens <dja@axtens.net>
Diffstat (limited to 'tools/patchwork-update-commits')
| -rwxr-xr-x | tools/patchwork-update-commits | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/patchwork-update-commits b/tools/patchwork-update-commits index 61952c0..257819e 100755 --- a/tools/patchwork-update-commits +++ b/tools/patchwork-update-commits @@ -20,7 +20,7 @@ # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA toolsdir="$(dirname "$0")" -pwpath="${toolsdir}"/../patchwork +pwpath="${toolsdir}/../patchwork" if [ "$#" -lt 1 ]; then echo "usage: $0 <revspec>" >&2 @@ -28,7 +28,7 @@ if [ "$#" -lt 1 ]; then fi git rev-list --reverse "$@" | -while read commit; do - hash=$(git diff "$commit~..$commit" | python $pwpath/hasher.py) - $pwpath/bin/pwclient update -s Accepted -c "$commit" -h "$hash" +while read -r commit; do + hash=$(git diff "$commit~..$commit" | python "$pwpath/hasher.py") + "$pwpath/bin/pwclient" update -s Accepted -c "$commit" -h "$hash" done |