diff options
| author | Daniel Axtens <dja@axtens.net> | 2017-09-29 00:12:24 +1000 |
|---|---|---|
| committer | Daniel Axtens <dja@axtens.net> | 2017-10-22 18:10:39 +1100 |
| commit | 76c3dae262590b8fcddc3d24a89b9b3717e3a9dc (patch) | |
| tree | 5541d90a5513a9546a006e1c30948c531ae6451a /tools/patchwork-update-commits | |
| parent | 10a132f134cef46aabb01ca88a32d06bdc8cf320 (diff) | |
| download | patchwork-76c3dae262590b8fcddc3d24a89b9b3717e3a9dc.tar patchwork-76c3dae262590b8fcddc3d24a89b9b3717e3a9dc.tar.gz | |
xmlrpc/patch_list: only fetch required fields
OzLabs noticed *massive* slowdowns in queries like this one:
SELECT "patchwork_submission"."id", "patchwork_submission"."msgid",
"patchwork_submission"."date", "patchwork_submission"."headers",
"patchwork_submission"."submitter_id",
"patchwork_submission"."content", "patchwork_submission"."project_id",
"patchwork_submission"."name", "patchwork_patch"."submission_ptr_id",
"patchwork_patch"."diff", "patchwork_patch"."commit_ref",
"patchwork_patch"."pull_url", "patchwork_patch"."delegate_id",
"patchwork_patch"."state_id", "patchwork_patch"."archived",
"patchwork_patch"."hash" FROM "patchwork_patch" INNER JOIN
"patchwork_submission" ON ("patchwork_patch"."submission_ptr_id" =
"patchwork_submission"."id") WHERE
("patchwork_submission"."project_id" = 2 AND
"patchwork_patch"."state_id" = 1) ORDER BY
"patchwork_submission"."date" ASC
These appear to be a result of pwclient list operations. We *do not*
need content/headers/diff in this case - so do not fetch them as it
is incredibly expensive - queries in excess of 50s have been observed.
This should go to stable/2.0.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Stephen Finucane <stephen@that.guru>
Diffstat (limited to 'tools/patchwork-update-commits')
0 files changed, 0 insertions, 0 deletions