diff options
| author | Stephen Finucane <stephen.finucane@intel.com> | 2015-10-12 11:34:50 -0500 |
|---|---|---|
| committer | Stephen Finucane <stephen.finucane@intel.com> | 2015-10-26 21:03:25 +0000 |
| commit | f1a63b8b7ef3300677a402eaf2a21421646ff543 (patch) | |
| tree | 50c3ca553e92e7faf8a5c8ae15df2d513b5d6a86 | |
| parent | 526fc9343e31a0ad3d11838a14ef5758db9cb68e (diff) | |
| download | patchwork-f1a63b8b7ef3300677a402eaf2a21421646ff543.tar patchwork-f1a63b8b7ef3300677a402eaf2a21421646ff543.tar.gz | |
views/xmlrpc: Remove unneeded '""' parameters
These don't make semantic sense: if a user didn't provide a parameter
then we should check for None.
Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
| -rw-r--r-- | patchwork/views/xmlrpc.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/patchwork/views/xmlrpc.py b/patchwork/views/xmlrpc.py index 31b7384..8836aff 100644 --- a/patchwork/views/xmlrpc.py +++ b/patchwork/views/xmlrpc.py @@ -347,7 +347,7 @@ def pw_rpc_version(): @xmlrpc_method() -def project_list(search_str='', max_count=0): +def project_list(search_str=None, max_count=0): """List projects matching a given linkname filter. Filter projects by linkname. Projects are compared to the search @@ -364,7 +364,7 @@ def project_list(search_str='', max_count=0): of all projects if no filter given. """ try: - if len(search_str) > 0: + if search_str: projects = Project.objects.filter(linkname__icontains=search_str) else: projects = Project.objects.all() @@ -398,7 +398,7 @@ def project_get(project_id): @xmlrpc_method() -def person_list(search_str="", max_count=0): +def person_list(search_str=None, max_count=0): """List persons matching a given name or email filter. Filter persons by name and email. Persons are compared to the @@ -415,7 +415,7 @@ def person_list(search_str="", max_count=0): of all persons if no filter given. """ try: - if len(search_str) > 0: + if search_str: people = (Person.objects.filter(name__icontains=search_str) | Person.objects.filter(email__icontains=search_str)) else: @@ -736,7 +736,7 @@ def patch_set(user, patch_id, params): @xmlrpc_method() -def state_list(search_str='', max_count=0): +def state_list(search_str=None, max_count=0): """List states matching a given name filter. Filter states by name. States are compared to the search string @@ -752,7 +752,7 @@ def state_list(search_str='', max_count=0): of all states if no filter given. """ try: - if len(search_str) > 0: + if search_str: states = State.objects.filter(name__icontains=search_str) else: states = State.objects.all() |