aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Finucane <stephen.finucane@intel.com>2015-08-21 15:32:17 +0100
committerDamien Lespiau <damien.lespiau@intel.com>2015-09-17 17:58:10 +0100
commit544b8bbcc7ec80d94c96f181886c51b177530a95 (patch)
tree72f3e760511edd25a2b527dee1049c7b37f7d3ff
parentac63b6b3564186191928044528e2afda862b7bc0 (diff)
downloadpatchwork-544b8bbcc7ec80d94c96f181886c51b177530a95.tar
patchwork-544b8bbcc7ec80d94c96f181886c51b177530a95.tar.gz
trivial: Resolve PEP8 issues with 'management'
(Added by Damien) This also moves from sys.stdout/sys.stderr to self.stdout/self.stderr as adviced by the Django documentation. Reviewed-by: Damien Lespiau <damien.lespiau@intel.com> Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
-rwxr-xr-xpatchwork/management/commands/cron.py7
-rw-r--r--patchwork/management/commands/retag.py24
2 files changed, 14 insertions, 17 deletions
diff --git a/patchwork/management/commands/cron.py b/patchwork/management/commands/cron.py
index 308b4b2..7c00ea3 100755
--- a/patchwork/management/commands/cron.py
+++ b/patchwork/management/commands/cron.py
@@ -1,14 +1,15 @@
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import BaseCommand
from patchwork.utils import send_notifications, do_expiry
+
class Command(BaseCommand):
- help = ('Run periodic patchwork functions: send notifications and '
+ help = ('Run periodic patchwork functions: send notifications and '
'expire unused users')
def handle(self, *args, **kwargs):
errors = send_notifications()
for (recipient, error) in errors:
self.stderr.write("Failed sending to %s: %s" %
- (recipient.email, error))
+ (recipient.email, error))
do_expiry()
diff --git a/patchwork/management/commands/retag.py b/patchwork/management/commands/retag.py
index 677d1d6..96b1620 100644
--- a/patchwork/management/commands/retag.py
+++ b/patchwork/management/commands/retag.py
@@ -1,28 +1,24 @@
-
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import BaseCommand
from patchwork.models import Patch
-import sys
+
class Command(BaseCommand):
help = 'Update the tag (Ack/Review/Test) counts on existing patches'
args = '[<patch_id>...]'
def handle(self, *args, **options):
-
- qs = Patch.objects
+ query = Patch.objects
if args:
- qs = qs.filter(id__in=args)
+ query = query.filter(id__in=args)
else:
- qs = qs.all()
+ query = query.all()
- count = qs.count()
- i = 0
+ count = query.count()
- for patch in qs.iterator():
+ for i, patch in enumerate(query.iterator()):
patch.refresh_tag_counts()
- i += 1
if (i % 10) == 0 or i == count:
- sys.stdout.write('%06d/%06d\r' % (i, count))
- sys.stdout.flush()
- sys.stderr.write('\ndone\n')
+ self.stdout.write('%06d/%06d\r' % (i, count))
+ self.stdout.flush()
+ self.stderr.write('\ndone\n')