From 72b5ef2c5fb01751992c9400afe2690da5df611f Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 10 Apr 2008 16:35:30 -0400 Subject: Fix CSRF attacks against the preferences and edit forms. Closes: #475445 The fix involved embedding the session id in the forms, and not allowing the forms to be submitted if the embedded id does not match the session id. In the case of the preferences form, if the session id is not embedded, then the CGI parameters are cleared. This avoids a secondary attack where the link to the preferences form prefills password or other fields, and the user hits "submit" without noticing these prefilled values. In the case of the editpage form, the anonok plugin can allow anyone to edit, and so I chose not to guard against CSRF attacks against users who are not logged in. Otherwise, it also embeds the session id and checks it. For page editing, I assume that the user will notice if content or commit message is changed because of CGI parameters, and won't blndly hit save page. So I didn't block those CGI paramters. (It's even possible to use those CGI parameters, for good, not for evil, I guess..) The only other CSRF attack I can think of in ikiwiki involves the poll plugin. It's certianly possible to set up a link that causes the user to unknowingly vote in a poll. However, the poll plugin is not intended to be used for things that people would want to attack, since anyone can after all edit the poll page and fill in any values they like. So this "attack" is ignorable. --- templates/editpage.tmpl | 1 + 1 file changed, 1 insertion(+) (limited to 'templates/editpage.tmpl') diff --git a/templates/editpage.tmpl b/templates/editpage.tmpl index cf4950ead..b0bb0ecb9 100644 --- a/templates/editpage.tmpl +++ b/templates/editpage.tmpl @@ -41,6 +41,7 @@ together before saving. + -- cgit v1.2.3