From 3d769344a81e93717dd07ecba1197ff1c3aa125a Mon Sep 17 00:00:00 2001 From: "giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1" Date: Fri, 30 Aug 2019 01:32:55 -0400 Subject: rename bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn to bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn --- ...arkdown_footnot_support_seems_to_be_broken.mdwn | 38 ---------------------- ...rkdown_footnote_support_seems_to_be_broken.mdwn | 38 ++++++++++++++++++++++ 2 files changed, 38 insertions(+), 38 deletions(-) delete mode 100644 doc/bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn create mode 100644 doc/bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn (limited to 'doc') diff --git a/doc/bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn b/doc/bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn deleted file mode 100644 index 2baba7137..000000000 --- a/doc/bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn +++ /dev/null @@ -1,38 +0,0 @@ -Hello, - -I have just updated an ikiwiki installation of mine from the `master` branch in 2014 -to the current `master` (430f69034f7c9f64325ef48da3b3eaf0d685dcc5), and found out that the -the footnote support with MultiMarkdown is broken. After some investigation, I believe that -the breakage was introduced in 4db4e589e4c73f076b666a77b86743695454a3ce, with Discount support -for footnotes. The conditional for the footnote support in MultiMarkdown is inverted. - -I've been running with this patch to fix it: - - From 8c624b3cc67bf41b3987a27b15a8dee5fe1087f7 Mon Sep 17 00:00:00 2001 - From: Giuseppe Bilotta - Date: Thu, 29 Aug 2019 16:51:45 +0200 - Subject: [PATCH] Fix inverted conditional for multimarkdown footnote support - - --- - IkiWiki/Plugin/mdwn.pm | 4 +--- - 1 file changed, 1 insertion(+), 3 deletions(-) - - diff --git a/IkiWiki/Plugin/mdwn.pm b/IkiWiki/Plugin/mdwn.pm - index eefa29a97..cff4204ef 100644 - --- a/IkiWiki/Plugin/mdwn.pm - +++ b/IkiWiki/Plugin/mdwn.pm - @@ -77,9 +77,7 @@ sub htmlize (@) { - $markdown_sub=sub { - my %flags=( use_metadata => 0 ); - - - if ($config{mdwn_footnotes}) { - - $flags{disable_footnotes}=1; - - } - + $flags{disable_footnotes}= not $config{mdwn_footnotes}; - - Text::MultiMarkdown::markdown(shift, \%flags); - } - -- - 2.21.0.595.g6364b05174 - -[[!tag patch]] diff --git a/doc/bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn b/doc/bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn new file mode 100644 index 000000000..2baba7137 --- /dev/null +++ b/doc/bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn @@ -0,0 +1,38 @@ +Hello, + +I have just updated an ikiwiki installation of mine from the `master` branch in 2014 +to the current `master` (430f69034f7c9f64325ef48da3b3eaf0d685dcc5), and found out that the +the footnote support with MultiMarkdown is broken. After some investigation, I believe that +the breakage was introduced in 4db4e589e4c73f076b666a77b86743695454a3ce, with Discount support +for footnotes. The conditional for the footnote support in MultiMarkdown is inverted. + +I've been running with this patch to fix it: + + From 8c624b3cc67bf41b3987a27b15a8dee5fe1087f7 Mon Sep 17 00:00:00 2001 + From: Giuseppe Bilotta + Date: Thu, 29 Aug 2019 16:51:45 +0200 + Subject: [PATCH] Fix inverted conditional for multimarkdown footnote support + + --- + IkiWiki/Plugin/mdwn.pm | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + + diff --git a/IkiWiki/Plugin/mdwn.pm b/IkiWiki/Plugin/mdwn.pm + index eefa29a97..cff4204ef 100644 + --- a/IkiWiki/Plugin/mdwn.pm + +++ b/IkiWiki/Plugin/mdwn.pm + @@ -77,9 +77,7 @@ sub htmlize (@) { + $markdown_sub=sub { + my %flags=( use_metadata => 0 ); + + - if ($config{mdwn_footnotes}) { + - $flags{disable_footnotes}=1; + - } + + $flags{disable_footnotes}= not $config{mdwn_footnotes}; + + Text::MultiMarkdown::markdown(shift, \%flags); + } + -- + 2.21.0.595.g6364b05174 + +[[!tag patch]] -- cgit v1.2.3