From d4ca3b3f50027d0dfd052f77ddcc4290ab0e6a81 Mon Sep 17 00:00:00 2001 From: joey Date: Wed, 23 Aug 2006 20:23:57 +0000 Subject: * Change order of linkify and preprocess; first preprocess and then linkify. This allows passing a wikilink inside a parameter to a preprocessor directive without it being expanded to html, and leaking out of the parameter, which had required some non-obvious use of triple-quoting to avoid. Note that any preprocessor plugins that output something that looks like a wikilink will now have it treated as such; AFAIK this doesn't change any behavior though except for the template plugin. * Enable preprocessor directives when previewing an edit. --- doc/todo/linkify_and_preprocessor_ordering.mdwn | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 doc/todo/linkify_and_preprocessor_ordering.mdwn (limited to 'doc/todo') diff --git a/doc/todo/linkify_and_preprocessor_ordering.mdwn b/doc/todo/linkify_and_preprocessor_ordering.mdwn new file mode 100644 index 000000000..2936d74f0 --- /dev/null +++ b/doc/todo/linkify_and_preprocessor_ordering.mdwn @@ -0,0 +1,24 @@ +Currently ikiwiki linkifies text, then runs preprocessor directives. This +allows a directive to contain a wikilink inside a parameter, but since the +wikilink expands to some arbitrary html, the parameter needs to be +triple-quoted to avoid quotes in the expanded text from leaking out. This +is rather non-obvious. + +One fix would be to switch the order, since linkification and preprocessing +are relatively independant. Some directives, like inline, would need to keep +on linkifiying the inlined pages, to make the links be resolved correctly, +but that's ok. Any directives that outputed stuff that looked like a +wikilink, but wasn't, would need to be changed. + +> This solution has been implemented and _seems_ ok. + +An alternative would be to change the wikilink regexp so it doesn't apply +to wikilinks that are embedded inside preprocessor directives. I haven't +found a way to do that yet, since perl doesn't allow variable-width +negative lookbehind. + +Maybe processing wikilinks and preprocessor directives +as part of the same loop would work, but that probably has its own +issues. + +[[todo/done]] -- cgit v1.2.3