From 79131ddb1a6e6e524a6bd987f18161152d5f408b Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sun, 3 Feb 2019 18:53:23 +0000 Subject: comment --- doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn b/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn index e3a57e184..690f89d5d 100644 --- a/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn +++ b/doc/todo/_Add_ikiwiki_PO-Plugin_to_ignore_languages.mdwn @@ -7,3 +7,16 @@ normally, however, HTML creation will be disabled and no reference to these translations will be visible on the website. See also downstream bug report in tails: + +> From the downstream bug report it appears this branch is not yet +> considered ready (as of February 2019), so I haven't attempted to +> review it. +> +> As with everything else in the `po` plugin: I would really want to see +> some regression test coverage before merging this, because as far as I'm +> aware none of the ikiwiki maintainers use the `po` plugin, so we are +> not able to detect regressions other than via the automated tests. That +> isn't a good situation to be in for a plugin that uses `IkiWiki::inject` +> to monkey-patch ikiwiki internals. If this plugin is important to you, +> more test coverage would be very much appreciated. +> --[[smcv]] -- cgit v1.2.3