From fb4cf0790ad93791040a99d6e183cfae274dd7f2 Mon Sep 17 00:00:00 2001 From: smcv Date: Thu, 3 Jul 2014 15:03:01 -0400 Subject: comment (not a review yet) --- doc/bugs/linkmap_displays_underscore_escapes.mdwn | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/linkmap_displays_underscore_escapes.mdwn b/doc/bugs/linkmap_displays_underscore_escapes.mdwn index 62cfb3471..abcbfb9ed 100644 --- a/doc/bugs/linkmap_displays_underscore_escapes.mdwn +++ b/doc/bugs/linkmap_displays_underscore_escapes.mdwn @@ -17,6 +17,17 @@ the attached [[!taglink patch]] fixes this; from its commit message: the output will look much better (at least in my wikis) with the "[[bugs/pagetitle function does not respect meta titles]]" issue fixed. +> I agree that it's (likely to be) a bug to not use `pagetitle()`. I +> haven't reviewed this particular implementation yet but I'll try to +> do that soon. +> +> I don't think it's correct for `pagetitle()` to output `\[[!meta title]]` +> though, as discussed on the linked bug: it appears in an assortment of +> contexts where the full formal title of the page seems inappropriate. +> If you want linkmap to use `\[[!meta title]]`, I think it would be +> better to give it a `show` parameter, like `\[[!map]]` has? +> --[[smcv]] + the patch is stored in [[the patch.pl]] as created by git-format-patch, and can be pulled from the abovementioned branch. -- cgit v1.2.3