From bbb0b3e72f6a3ffaac8343fc847800d7faaa7573 Mon Sep 17 00:00:00 2001 From: joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> Date: Sat, 24 Mar 2007 15:10:58 +0000 Subject: * Finally fixed the longstanding inline removal bug. * Renamed %oldpagemtime to a more accurately named %pagemtime and fix it to actually store pages' mtimes. * Add "mtime" sort parameter to inline plugin. --- doc/bugs/done.mdwn | 2 +- doc/bugs/inline_page_not_updated_on_removal.mdwn | 25 +----------------------- 2 files changed, 2 insertions(+), 25 deletions(-) (limited to 'doc/bugs') diff --git a/doc/bugs/done.mdwn b/doc/bugs/done.mdwn index a92862bd4..282122001 100644 --- a/doc/bugs/done.mdwn +++ b/doc/bugs/done.mdwn @@ -1,3 +1,3 @@ recently fixed [[bugs]] -[[inline pages="link(bugs/done) and !bugs and !*/Discussion" show="10"]] +[[inline pages="link(bugs/done) and !bugs and !*/Discussion" sort=mtime show=10]] diff --git a/doc/bugs/inline_page_not_updated_on_removal.mdwn b/doc/bugs/inline_page_not_updated_on_removal.mdwn index 7f5e49871..fc626cab1 100644 --- a/doc/bugs/inline_page_not_updated_on_removal.mdwn +++ b/doc/bugs/inline_page_not_updated_on_removal.mdwn @@ -6,27 +6,4 @@ This only happens if the page is removed from the inlined pagespec due to a tag changing; the problem is that once the tag is changed, ikiwiki does not know that the page used to match before. -Another example would be a pagespec that allowed only matching new pages: - - newer(1 day) - -Obviously, the pages that matches are going to change, and again once they -do, ikiwiki will no longer know that they matched before, so it won't know -to remove them from a page that used that to inline them. - -To fix, seems I would need to record the actual list of pages that are -currently included on an inline page, and do a comparison to see if any -have changed. - -At first I thought, why not just add them to the dependencies -explicitly, but that failed because the dependencies GlobList failed to match -when a negated expression like "!tag(bugs/done)" is matched. It is, -however, doable with PageSpecs: - - (real deps here) or (list of all currently inlined pages here) - -However, it's not really clear to me how to _remove_ inlined pages from the -deps when they stop being inlined for whatever reason. So a separate list -would be better. - -So this is blocked by [[todo/plugin_data_storage]] I suppose. +[[done]] -- cgit v1.2.3