From 4cb6f48aff6645227dae5c7852d3122e4046142b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 21 Jan 2019 11:44:29 -0400 Subject: bug report --- doc/bugs/permalink_not_set_for_comments.mdwn | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 doc/bugs/permalink_not_set_for_comments.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/permalink_not_set_for_comments.mdwn b/doc/bugs/permalink_not_set_for_comments.mdwn new file mode 100644 index 000000000..9ca8200b5 --- /dev/null +++ b/doc/bugs/permalink_not_set_for_comments.mdwn @@ -0,0 +1,16 @@ +Changes to comments result in notifyemail sending emails with broken urls like +"http://whatever/foo/comment_1_10a49d69282155c5c3e66dc58f64f956/" + +notifyemail uses meta permalink if set, so it must not be set for comment +pages. + +In the comments plugin, there's this code, which is supposed to set +permalink: + + if ($params{page} =~ m/\/\Q$config{comments_pagename}\E\d+_/) { + $pagestate{$page}{meta}{permalink} = urlto(IkiWiki::dirname($params{page})). + "#".page_to_id($params{page}); + } + +`comments_pagename` is `comment_` so the above code needs a comment page to contain +two underscores. I think that is the root of the bug. --[[Joey]] -- cgit v1.2.3