From f871c084f637adc2c2ec8846c86fac9e802183e6 Mon Sep 17 00:00:00 2001 From: joey Date: Thu, 7 Jun 2007 14:03:00 +0000 Subject: web commit by HenrikBrixAndersen: Add patch for graphviz.pm --- doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn (limited to 'doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn') diff --git a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn new file mode 100644 index 000000000..395427b86 --- /dev/null +++ b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn @@ -0,0 +1,28 @@ +The graphviz.pm plug-in currently attempts to read PNG data in UTF-8 mode, which sometimes fail with a message similar to the following (depending on the input): + + utf8 "\x89" does not map to Unicode at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 53, chunk 1. + Wide character in subroutine entry at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 68. + +It also generates image URLs relative to the page being rendered, which means the URLs wont work when previewing a graph from the CGI script. + +The patch below fixes these two issues. + + --- graphviz.pm.orig Thu Jun 7 15:45:16 2007 + +++ graphviz.pm Thu Jun 7 15:52:27 2007 + @@ -41,7 +41,6 @@ sub render_graph (\%) { #{{{ + $pid=open2(*IN, *OUT, "$params{prog} -Tpng"); + + # open2 doesn't respect "use open ':utf8'" + - binmode (IN, ':utf8'); + binmode (OUT, ':utf8'); + + print OUT $src; + @@ -70,7 +69,7 @@ sub render_graph (\%) { #{{{ + } + } + + - return "\n"; + + return "\n"; + } #}}} + + sub graph (@) { #{{{ \ No newline at end of file -- cgit v1.2.3