From 5f6f9a1beab327be2728d44c1996408176f6800e Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 11 May 2016 09:18:14 +0100 Subject: Wrapper: allocate new environment dynamically Otherwise, if third-party plugins extend newenviron by more than 3 entries, we could overflow the array. It seems unlikely that any third-party plugin manipulates newenviron in practice, so this is mostly theoretical. Just in case, I have deliberately avoided using "i" as the variable name, so that any third-party plugin that was manipulating newenviron directly will now result in the wrapper failing to compile. I have not assumed that realloc(NULL, ...) works as an equivalent of malloc(...), in case there are still operating systems where that doesn't work. --- debian/changelog | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'debian/changelog') diff --git a/debian/changelog b/debian/changelog index 81a679282..e721f167f 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +ikiwiki (3.20160510) UNRELEASED; urgency=medium + + * wrappers: allocate new environment dynamically, so we won't overrun + the array if third-party plugins add multiple environment variables. + + -- Simon McVittie Wed, 11 May 2016 09:15:51 +0100 + ikiwiki (3.20160509) unstable; urgency=high [ Amitai Schlair ] -- cgit v1.2.3