aboutsummaryrefslogtreecommitdiff
path: root/pm_filter
diff options
context:
space:
mode:
authorSimon McVittie <smcv@debian.org>2016-09-03 23:46:33 +0100
committerSimon McVittie <smcv@debian.org>2016-09-03 23:47:52 +0100
commit06fce2b23888621fe87759ffa014c3920f937b7e (patch)
tree291c096e6f1963af6b0ea3c45e68c6a65aa0a4bf /pm_filter
parent276f0cf57861418fae5b4db8446d3d1098130cdf (diff)
downloadikiwiki-06fce2b23888621fe87759ffa014c3920f937b7e.tar
ikiwiki-06fce2b23888621fe87759ffa014c3920f937b7e.tar.gz
pm_filter: use \Q...\E to escape all possible strings pedantically
The current implementation would misbehave for prefixes containing a single quote.
Diffstat (limited to 'pm_filter')
-rwxr-xr-xpm_filter8
1 files changed, 4 insertions, 4 deletions
diff --git a/pm_filter b/pm_filter
index 351e0b4d9..7b03418ab 100755
--- a/pm_filter
+++ b/pm_filter
@@ -7,10 +7,10 @@ BEGIN {
}
if (/INSTALLDIR_AUTOREPLACE/) {
- $_=qq{our \$installdir='$prefix';};
+ $_=qq{our \$installdir="\Q$prefix\E";};
}
elsif (/VERSION_AUTOREPLACE/) {
- $_=qq{our \$version="$ver";};
+ $_=qq{our \$version="\Q$ver\E";};
}
elsif (/^(?:use FindBin; *)?use lib/) {
# The idea here is to figure out if the libdir the Makefile.PL
@@ -22,12 +22,12 @@ elsif (/^(?:use FindBin; *)?use lib/) {
$_="";
}
else {
- $_="use lib '$libdir';\n";
+ $_="use lib \"\Q$libdir\E\";\n";
}
}
elsif ($. == 1 && ($ENV{NOTAINT}=0) && m{^(#!.*perl.*?)$}) {
$_=qq{$1 -T\n};
}
elsif (/^\$ENV\{PATH}="(.*)";/) {
- $_="\$ENV{PATH}=\"$1:$prefix/bin\";\n";
+ $_="\$ENV{PATH}=\"\Q$1\E:\Q$prefix\E/bin\";\n";
}