diff options
| author | Joey Hess <joey@kitenet.net> | 2010-10-08 18:46:30 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2010-10-08 18:46:30 -0400 |
| commit | e7d6dcfed618c57c775478c95b77a15097142e6e (patch) | |
| tree | cb46906981365e7de30d5edb99a2944f67772248 /IkiWiki | |
| parent | f5c270b11dbfb2589df21388a07f55002e076d3c (diff) | |
| download | ikiwiki-e7d6dcfed618c57c775478c95b77a15097142e6e.tar ikiwiki-e7d6dcfed618c57c775478c95b77a15097142e6e.tar.gz | |
remove todo item
I understand the need to avoid chdir when running git_parse_changes
for receive now. At that point, the changes have not been pushed to
the srcdir's repo yet. When running the same code for preprevert,
chdir to the srcdir is ok, and necessary.
Diffstat (limited to 'IkiWiki')
| -rw-r--r-- | IkiWiki/Plugin/git.pm | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/IkiWiki/Plugin/git.pm b/IkiWiki/Plugin/git.pm index 48e71aa9a..47e806209 100644 --- a/IkiWiki/Plugin/git.pm +++ b/IkiWiki/Plugin/git.pm @@ -794,8 +794,6 @@ sub git_parse_changes { die $@ if $@; my $fh; ($fh, $path)=File::Temp::tempfile("XXXXXXXXXX", UNLINK => 1); - # Ensure we run this in the right place, - # see comments in rcs_receive. my $cmd = ($no_chdir ? '' : "cd $config{srcdir} && ") . "git show $detail->{sha1_to} > '$path'"; if (system($cmd) != 0) { |