aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmitai Schlair <schmonz-web-ikiwiki@schmonz.com>2015-01-07 18:25:21 -0500
committerAmitai Schlair <schmonz-web-ikiwiki@schmonz.com>2015-01-07 18:25:21 -0500
commit50fba5d84432cd27c4a02e61c9ed5e03aa10ae30 (patch)
tree43d9105ff351b400aca9e039180a7d7db264856d
parent47f593f84f361fbee1d4ee11361cc0f629d21ca2 (diff)
downloadikiwiki-50fba5d84432cd27c4a02e61c9ed5e03aa10ae30.tar
ikiwiki-50fba5d84432cd27c4a02e61c9ed5e03aa10ae30.tar.gz
Mention schmonz/comments-anonymous-url-vcs
-rw-r--r--doc/plugins/comments/discussion.mdwn21
1 files changed, 21 insertions, 0 deletions
diff --git a/doc/plugins/comments/discussion.mdwn b/doc/plugins/comments/discussion.mdwn
index 2b8add938..0e5c5e669 100644
--- a/doc/plugins/comments/discussion.mdwn
+++ b/doc/plugins/comments/discussion.mdwn
@@ -230,3 +230,24 @@ Any suggestions or hints how to implement this?
> I've implemented this. See [[todo/Restrict_formats_allowed_for_comments]].
> --[[wentasah]]
+
+## URLs in anonymous-style comments committed directly via VCS
+
+[[!template id=gitbranch branch=schmonz/comments-anonymous-url-vcs author="[[schmonz]]"]]
+
+I recently imported my site from Textpattern into ikiwiki (using
+an `ikiwiki-import` program that may someday make its way into
+ikiwiki proper). Textpattern's comments behave much like ikiwiki's
+anonymous comments, so piping each imported comment through
+`ikiwiki-comment` and regenerating the site with `comments_allowauthor=1`
+preserved almost all the information.
+
+What's missing: if a comment directive has a `url` param, I'd expect
+the rendered page to href the author's name to that URL. This works
+as I expect for new comments added via the CGI, but not for imported
+comments added via the VCS directly.
+
+My branch has a fix that doesn't break `t/comments.t`, doesn't
+appear to break anonymous or signed-in comments via the CGI in any
+way I've tried, and lets me render my (incredibly valuable ;-)
+imported blog comments with full fidelity. OK to commit?