From 13b57422670eea8348758294fed07bec6346348d Mon Sep 17 00:00:00 2001
From: Christopher Baines <mail@cbaines.net>
Date: Sat, 17 Sep 2022 13:29:07 +0200
Subject: Avoid errors when various URLs can't be found

---
 guix-qa-frontpage/server.scm     | 38 ++++++++++++++++++++++----------------
 guix-qa-frontpage/view/issue.scm |  3 ++-
 2 files changed, 24 insertions(+), 17 deletions(-)

(limited to 'guix-qa-frontpage')

diff --git a/guix-qa-frontpage/server.scm b/guix-qa-frontpage/server.scm
index 2ab2bb2..3e0c69b 100644
--- a/guix-qa-frontpage/server.scm
+++ b/guix-qa-frontpage/server.scm
@@ -130,23 +130,29 @@
          (if series
              (let ((derivation-changes
                     change-details
-                    (with-sqlite-cache
-                     database
-                     'derivation-changes
-                     patch-series-derivation-changes
-                     #:args
-                     (list (patch-series-derivation-changes-url
-                            series
-                            #:systems %systems-to-submit-builds-for))
-                     #:ttl 6000))
+                    (or
+                     (and=> (patch-series-derivation-changes-url
+                             series
+                             #:systems %systems-to-submit-builds-for)
+                            (lambda (url)
+                              (with-sqlite-cache
+                               database
+                               'derivation-changes
+                               patch-series-derivation-changes
+                               #:args (list url)
+                               #:ttl 6000)))
+                     (values #f #f)))
                    (comparison-details
-                    (with-sqlite-cache
-                     database
-                     'lint-warnings
-                     patch-series-comparison
-                     #:args
-                     (list (patch-series-compare-url series))
-                     #:ttl 6000)))
+                    (and=>
+                     (patch-series-compare-url series)
+                     (lambda (url)
+                       (with-sqlite-cache
+                        database
+                        'lint-warnings
+                        patch-series-comparison
+                        #:args
+                        (list url)
+                        #:ttl 6000)))))
                (render-html
                 #:sxml (issue-view number
                                    series
diff --git a/guix-qa-frontpage/view/issue.scm b/guix-qa-frontpage/view/issue.scm
index 59b27c3..3a57598 100644
--- a/guix-qa-frontpage/view/issue.scm
+++ b/guix-qa-frontpage/view/issue.scm
@@ -237,7 +237,8 @@ td.bad {
               "Unknown")
           (th)))
         (tbody
-         ,@(if comparison-details
+         ,@(if (and comparison-details
+                    derivation-changes)
                (let* ((base-builds
                        (builds-by-system-excluding-cross-builds "base"))
                       (target-builds
-- 
cgit v1.2.3